tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool
Date Mon, 10 Sep 2018 09:26:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608928#comment-16608928
] 

ASF GitHub Bot commented on TINKERPOP-1774:
-------------------------------------------

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/903
  
    >>Why do you want to keep the connections in the pool when a read/write operation
is executed on them? They can't be used at that time anyway and I think that the current design
is a lot easier where a connection is taken from the pool for the request and returned simply
by disposing its ProxyConnection.
    
    >That's exactly why, because the connection can be used concurrently for requests.
    
    What I meant here is that the connection cannot be used again until `SendAsync` completed.
So, my suggestion for request pipelining is simply that the connection is taken out of the
pool and then returned back as soon as `SendAsync` was successfully awaited. (Opposed to the
current implementation where the connection will only be returned to the pool when `ReceiveAsync`
was also awaited which leads to the longer latencies.) That would lead to the same latencies
for your example and we could keep the current design of the `ConnectionPool` with the `ProxyConnection`.
    
    I just don't see what the advantage is to keep the connections in the pool while they
are in use (meaning that `SendAsync` or `ReceiveAsync` is currently awaited on them) as we
can't use them again in that case any way. So, it would only make the pool more complicated
without getting any performance improvements. Or am I missing something here?


> Gremlin .NET: Support min and max sizes in Connection pool
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1774
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Jorge Bay
>            Assignee: Florian Hockmann
>            Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of connections
and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of {{lock}} in
the pool implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message