tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool
Date Tue, 11 Sep 2018 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610466#comment-16610466
] 

ASF GitHub Bot commented on TINKERPOP-1774:
-------------------------------------------

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/903
  
    Thanks for the insight @spmallette. That means for this PR that we don't have to hurry
at the moment.
    
    > Max in-flight should be a threshold that, when reached, more connections are created.
    
    So, max in-flight would be a global threshold? I think it would be hard to set a meaningful
limit for that as it depends on the maximum pool pool size.
    The Java driver has a `maxSimultaneousUsagePerConnection` and creates a new connection
when the least used connection has reached that limit (until the max pool size is reached).
    
    > When max amount of connections is reached, we can either:
    a) Continue queueing at connection level (adding it to the queue).
    b) Throttle requests by throwing an error, like MaxLimitExceededException or something
like that.
    
    The Java driver waits for an available connection in that case which needs to have less
than the `maxSimultaneousUsagePerConnection` requests in progress.
    That approach makes sense to me and I don't really like throwing an exception only because
the limit is reached because of a high number of requests that might only be a temporary problem.
    
    If we want to follow a similar approach like that of the Java driver, then we still need
to wait for an available connection which would also require such an `AsyncAutoResetEvent`.


> Gremlin .NET: Support min and max sizes in Connection pool
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1774
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Jorge Bay
>            Assignee: Florian Hockmann
>            Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of connections
and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of {{lock}} in
the pool implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message