tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool
Date Tue, 11 Sep 2018 15:05:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610763#comment-16610763
] 

ASF GitHub Bot commented on TINKERPOP-1774:
-------------------------------------------

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/903
  
    > looks like you are focused on getting this one merged
    
    No, I don't really mind waiting for TINKERPOP-1775 and implementing both together. I just
had two motivations for merging this PR first independently of TINKERPOP-1775:
    
    1. Adding limits to the `ConnectionPool` is a breaking change and therefore can only go
into version 3.4.0 or 3.5.0.
    2. From my point of view, the changes from this PR would also be necessary to implement
request pipelining.
    
    Point 1 introduced some pressure of time for this PR as I don't want to wait for version
3.5.0. However, that isn't valid any more when we don't plan to release 3.4.0 in the next
few weeks.
    Point 2 was mainly motivated by the fact that the Java `ConnectionPool` has basically
the same implementation as introduced by this PR and I saw that as something like the reference
implementation.
    
    I know that you have way more experience with writing drivers and you made some good points
which convince me more and more that the .NET driver could look different than the Java driver
when we implement both tickets together.
    
    So, I agree and let's wait until we have a PR for both tickets. It should also be easier
to continue the discussion on the concrete implementation for the request pipelining once
we have a first implementation.


> Gremlin .NET: Support min and max sizes in Connection pool
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1774
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Jorge Bay
>            Assignee: Florian Hockmann
>            Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of connections
and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of {{lock}} in
the pool implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message