tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections
Date Sun, 16 Sep 2018 06:27:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616606#comment-16616606
] 

ASF GitHub Bot commented on TINKERPOP-2015:
-------------------------------------------

Github user deejvince commented on the issue:

    https://github.com/apache/tinkerpop/pull/928
  
    @FlorianHockmann this PR should enable  setting custom headers on the WebSocket, right?

    
    like:
    Options.SetRequestHeader("Authorization", "Bearer " + token);
    
    Thank you,
    DjV


> Allow users to configure the WebSocket connections
> --------------------------------------------------
>
>                 Key: TINKERPOP-2015
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2015
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.3.3, 3.2.9
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Major
>
> Gremlin.Net currently just creates instances of the {{ClientWebSocket}} class with default
options. That is probably appropriate for most users but it makes it impossible to change
the config and use certain features like client certificates or proxy settings.
> We could simply allow users to provide a [{{ClientWebSocketOptions}}|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions]
object. Since it's part of .NET Standard (and not a 3rd party library) it shouldn't be a problem
to expose this type. This would also have the nice advantage that users could immediately
use new options like the {{[RemoteCertificateValidationCallback|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions.remotecertificatevalidationcallback]}}
that was just added in .NET Core 2.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message