tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection
Date Thu, 13 Sep 2018 12:56:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613445#comment-16613445

ASF GitHub Bot commented on TINKERPOP-2035:

Github user jorgebay commented on a diff in the pull request:

    --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
    @@ -49,12 +49,14 @@ class DriverRemoteConnection extends RemoteConnection {
        * @param {String} [options.traversalSource] The traversal source. Defaults to: 'g'.
        * @param {GraphSONWriter} [options.writer] The writer to use.
        * @param {Authenticator} [options.authenticator] The authentication handler to use.
    +   * @param {String} [options.headers] Add custom headers to the request.
    --- End diff --
    The correct type of the `@param` is `{Object}`.
    What do you think about providing a little more detail, like: "An associative array containing
the additional header key/values for the initial request"

> Gremlin-JavaScript: Pass custom headers to the websocket connection
> -------------------------------------------------------------------
>                 Key: TINKERPOP-2035
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2035
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: javascript
>    Affects Versions: 3.3.3
>            Reporter: Brad Bebee
>            Priority: Major
> In some cases, it is required to pass extra header information to the Gremlin server
to successfully make a connection. This ticket is to add the feature to enable users to optionally
pass headers via the JavaScript client when connecting to a Gremlin Server.
> This was originally noted when connecting to Amazon Neptune with the SIGv4 signing required
when using IAM-based authentication, but is generally applicable for use of the JavaScript
client with Gremlin Servers that require additional header information. 
> The corresponding PR is below.
> [Pull Request|https://github.com/apache/tinkerpop/pull/929]

This message was sent by Atlassian JIRA

View raw message