tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-2039) Bump to Groovy 2.5.2
Date Tue, 25 Sep 2018 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627548#comment-16627548
] 

ASF GitHub Bot commented on TINKERPOP-2039:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/940

    TINKERPOP-2039 Bump to Groovy 2.5.2

    https://issues.apache.org/jira/browse/TINKERPOP-2039
    
    Required some minor changes to the Console as the CliBuilder is no longer the recommended
approach for Groovy - had to use picocli classes instead. Still couldn't make the command
line parsing work exclusively under picocli - I think we have somewhat nonstandard options
in our command line.
    
    Performed manual tests and builds with `mvn clean install && mvn verify -pl gremlin-console
-DskipIntegrationTests=false`.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2039

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
    
----
commit 0c2347b535e2120c72278b011fe3dce0ec36bdf5
Author: Stephen Mallette <spmva@...>
Date:   2018-09-19T14:50:20Z

    TINKERPOP-2039 Bump to Groovy 2.5.2
    
    Required some minor changes to the Console as the CliBuilder is no longer the recommended
approach for Groovy - had to use picocli classes instead. Still couldn't make the command
line parsing work exclusively under picocli - I think we have somewhat nonstandard options
in our command line.

----


> Bump to Groovy 2.5.2
> --------------------
>
>                 Key: TINKERPOP-2039
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2039
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: groovy
>    Affects Versions: 3.4.0
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>              Labels: breaking
>             Fix For: 3.4.0
>
>
> Bump to the most current version of Groovy at 2.5.2. This is a breaking change in a sense
as there were breaking code changes in Groovy itself coming from 2.4.x. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message