tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spmallette (GitHub) <git...@apache.org>
Subject [GitHub] [tinkerpop] spmallette commented on pull request #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy
Date Wed, 03 Apr 2019 20:15:42 GMT
This is good. A couple of questions: 

1. Can the message get any more helpful somehow? Maybe it should say more about "why" this
is important? Just a suggestion: "Always specify edge labels which restrict traversal paths
ensuring optimal performance - the following steps need edge labels: VertexStep(OUT,vertex)".
2. I guess my second question relates to my message - It looks like the strategy throws the
exception as soon as it runs into a problem. Would it be better to collect all the problems
at once and report them in batch for fixing?
3. I don't suppose we have a way to convert "VertexStep(OUT,vertex)` to simple `out()` do
we? Maybe `GroovyTranslator`  somehow? would be nice to actually somehow show the user exactly
where they messed up in code rather than the `Step` representation, but perhaps that's not
possible. I sorta think `profile()` would be more user friendly that way if it could be done.
Maybe not something for this PR, but just something to think about.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1087 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message