tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1553) Deprecate store() in favor of aggregate(Scope)
Date Thu, 27 Jun 2019 01:15:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873740#comment-16873740
] 

ASF GitHub Bot commented on TINKERPOP-1553:
-------------------------------------------

spmallette commented on pull request #1150: TINKERPOP-1553 Deprecate store(String) for aggregate(Scope,String)
URL: https://github.com/apache/tinkerpop/pull/1150
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-1553
   
   `store('x')` can now be accomplished with `aggregate(local,'x')` and `aggregate('x')` is
`aggregate(global,'x')`. this is a non-breaking change, just deprecation to consider for now.
See comments on the JIRA for more details on the choices made on the way to this PR.
   
   All tests pass with `docker/build.sh -t -i`
   
   VOTE +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate store() in favor of aggregate(Scope)
> ----------------------------------------------
>
>                 Key: TINKERPOP-1553
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1553
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.3
>            Reporter: Marko A. Rodriguez
>            Assignee: stephen mallette
>            Priority: Major
>              Labels: deprecation
>
> `AggregateStep` can be expressed as `StoreStep.NoOpBarrierStep`. There is no reason to
have the extra logic if we don't need it.
> That is:
> {code}
> aggregate('a') => store('a').barrier()
> {code}
> Next, we should get rid of {{aggregate()}} and have two methods:
> {code}
> store(global,'a') => store('a').barrier()
> store(local,'a') => store('a')
> {code}
> If you are storing global that means you are storing every traverser up to the current
step. Likewise, store local would only store the current traverser.
> Here is the crappy thing. All of our {{xxx(Scope)}} steps default to {{Scope.global}}:
{{range()}}, {{tail()}}, {{count()}}...
> We should probably keep the same pattern of {{Scope.global}} default, but then that means
that we would have a breaking change in the API.
> {code}
> store("a") -would-change-to-> store(local,"a")
> {code}
> We should have a {{storeV3d0()}} backward compatibility which would simply use {{store(local,"a")}}.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message