tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FlorianHockmann (GitHub) <git...@apache.org>
Subject [GitHub] [tinkerpop] FlorianHockmann commented on pull request #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192
Date Mon, 02 Mar 2020 15:15:16 GMT
I'm not sure about the value these tests add as they are basically just asserting how a JSON
deserializer should treat edge cases, but OK, they could become useful when we try out the
new .NET JSON serializer, so I'm also not against adding them.
Could you however please refactor the tests a bit if you want to add them to Gremlin.Net?
Each test should only test a single case, should have a clear name that reflects what the
expected behaviour is and it should ideally be split into the three phases _arrange_, _act_,
and _assert_, separated by newlines (see for example [here](http://wiki.c2.com/?ArrangeActAssert)
for a reference).
The [GremlinServerTests](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/test/Gremlin.Net.UnitTest/Driver/GremlinServerTests.cs#L29)
also show this nicely.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1250 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message