tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From heljoyLiu (GitHub) <git...@apache.org>
Subject [GitHub] [tinkerpop] heljoyLiu commented on issue #1257: dotnet: add session connection
Date Fri, 06 Mar 2020 13:31:25 GMT
> Thanks for the contribution, @heljoyLiu! The PR looks good at a first glance, but I'll
need some more time to do a full review.
> I'm not sure if you're aware of that but the Gremlin.NET driver has changed a lot between
`3.3-dev` and `3.4-dev`, so if you want this change to go into `3.3-dev` already, then it
would be good if you could create another PR that targets `3.4-dev` with this contribution.
That would make it a lot easier to get your contribution into all release branches.

ok, I will create another PR to `3.4-dev` after review, thanks @FlorianHockmann 

[ Full content available at: https://github.com/apache/tinkerpop/pull/1257 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message