tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Mallette (Jira)" <j...@apache.org>
Subject [jira] [Closed] (TINKERPOP-2336) Allow close of channel without having to wait for server
Date Thu, 05 Mar 2020 20:13:00 GMT

     [ https://issues.apache.org/jira/browse/TINKERPOP-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stephen Mallette closed TINKERPOP-2336.
---------------------------------------
    Fix Version/s: 3.4.7
                   3.3.11
                   3.5.0
       Resolution: Done

As part of this ticket I also took the step to remove {{maxWaitForSessionClose}} from 3.5.0
and removed driver functionality to send the session "close" message and removed the server
functionality to do anything with that message besides return a {{NO_CONTENT}} back.

https://github.com/apache/tinkerpop/commit/89faefc50848e957348ee615d6c72496c0621b43

> Allow close of channel without having to wait for server
> --------------------------------------------------------
>
>                 Key: TINKERPOP-2336
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2336
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.3.10
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Major
>              Labels: deprecation
>             Fix For: 3.5.0, 3.3.11, 3.4.7
>
>
> The java driver hangs about waiting for results to return after a {{Client.close()}}
is called. That creates problems if there is a desire to kill the client but there is a long
run query on the server and that query is configured to an especially long timeout. I think
there just needs to be a configuration for the amount of time the client will wait for results
before just giving up and shutting down. A byproduct of this change is that by allowing the
{{Client}} to close the channel while a query is executing creates a cancellation sort of
functionality which should issue an interrupt to the traversal executing on the server. 
> With this change in place it sort of creates a feature somewhat at odds with the session
"close" message which tries to release a specific session. The problem with that message is
that it really is only useful if there is not already a message ahead of it getting processed
and stuck otherwise it is queued and won't be processed until the message ahead of it is handled.
Obviously, if the goal is to kill the session because of a long run process then this feature
becomes a bit unhelpful. If the close of the channel accomplishes the same thing as the close
message then I think we would want to deprecate the close message and remove it for 3.5.0.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message