tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-2347) Remove invalid service descriptors from gremlin-shaded
Date Fri, 06 Mar 2020 17:55:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053642#comment-17053642
] 

ASF GitHub Bot commented on TINKERPOP-2347:
-------------------------------------------

olim7t commented on pull request #1259: TINKERPOP-2347 Remove invalid service descriptors
from gremlin-shaded
URL: https://github.com/apache/tinkerpop/pull/1259
 
 
   No automated test, but I published a small project to reproduce the issue [here](https://github.com/olim7t/dummy-jpms).
   
   It's actually only a warning when run from the command line, but I get an error in IntelliJ
IDEA.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove invalid service descriptors from gremlin-shaded
> ------------------------------------------------------
>
>                 Key: TINKERPOP-2347
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2347
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: build-release
>    Affects Versions: 3.4.5
>            Reporter: Olivier Michallat
>            Priority: Minor
>
> {{gremlin-shaded.jar}} contains a couple of service descriptors inherited from Jackson:
> {code}
> META-INF/services/com.fasterxml.jackson.core.JsonFactory
> META-INF/services/com.fasterxml.jackson.core.ObjectCodec
> {code}
> They still reference unshaded classes, for example in the first one:
> {code}
> com.fasterxml.jackson.core.JsonFactory
> {code}
> This creates a problem if the JAR is used as an automatic module in a JPMS application.
The module system tries to convert the files into {{provides}} directives in the dynamically
generated module descriptor, but it checks for the existence of the types in the process:
> {code}
> Error occurred during initialization of boot layer
> java.lang.module.FindException: Unable to derive module descriptor for /path/to/gremlin-shaded-3.4.5.jar
> Caused by: java.lang.module.InvalidModuleDescriptorException: Provider class com.fasterxml.jackson.core.JsonFactory
not in module
> {code}
> I didn't find a way to work around this error without modifying the JAR.
> I think the best approach would be to filter out those files during the shading process.
They were wrong anyway, so it's unlikely that anyone will miss them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message