tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andygumbre...@apache.org
Subject svn commit: r1511694 - in /tomee/tomee/trunk: container/openejb-core/src/test/java/org/apache/openejb/core/stateless/ server/openejb-client/src/main/java/org/apache/openejb/client/ server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/
Date Thu, 08 Aug 2013 11:07:44 GMT
Author: andygumbrecht
Date: Thu Aug  8 11:07:43 2013
New Revision: 1511694

URL: http://svn.apache.org/r1511694
Log:
Args should be null

Modified:
    tomee/tomee/trunk/container/openejb-core/src/test/java/org/apache/openejb/core/stateless/StatelessInstanceManagerPoolingTest.java
    tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBHomeHandler.java
    tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBObjectHandler.java
    tomee/tomee/trunk/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/MultithreadTest.java

Modified: tomee/tomee/trunk/container/openejb-core/src/test/java/org/apache/openejb/core/stateless/StatelessInstanceManagerPoolingTest.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/test/java/org/apache/openejb/core/stateless/StatelessInstanceManagerPoolingTest.java?rev=1511694&r1=1511693&r2=1511694&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/test/java/org/apache/openejb/core/stateless/StatelessInstanceManagerPoolingTest.java
(original)
+++ tomee/tomee/trunk/container/openejb-core/src/test/java/org/apache/openejb/core/stateless/StatelessInstanceManagerPoolingTest.java
Thu Aug  8 11:07:43 2013
@@ -266,7 +266,7 @@ public class StatelessInstanceManagerPoo
         public void explode(CountDownLatch invocations){
         	try{
         	    discardedInstances.incrementAndGet();
-        	    throw new NullPointerException();
+        	    throw new NullPointerException("Test expected this null pointer");
         	}finally{
         		invocations.countDown();
         	}

Modified: tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBHomeHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBHomeHandler.java?rev=1511694&r1=1511693&r2=1511694&view=diff
==============================================================================
--- tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBHomeHandler.java
(original)
+++ tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBHomeHandler.java
Thu Aug  8 11:07:43 2013
@@ -28,15 +28,16 @@ import java.io.ObjectOutput;
 import java.lang.reflect.Method;
 import java.rmi.RemoteException;
 
+@SuppressWarnings("NullArgumentToVariableArgMethod")
 public abstract class EJBHomeHandler extends EJBInvocationHandler implements Externalizable
{
 
-    protected static final Method GETEJBMETADATA = getMethod(EJBHome.class, "getEJBMetaData",
(Class) null);
-    protected static final Method GETHOMEHANDLE = getMethod(EJBHome.class, "getHomeHandle",
(Class) null);
+    protected static final Method GETEJBMETADATA = getMethod(EJBHome.class, "getEJBMetaData",
null);
+    protected static final Method GETHOMEHANDLE = getMethod(EJBHome.class, "getHomeHandle",
null);
     @SuppressWarnings("RedundantArrayCreation")
     protected static final Method REMOVE_W_KEY = getMethod(EJBHome.class, "remove", new Class[]{Object.class});
     @SuppressWarnings("RedundantArrayCreation")
     protected static final Method REMOVE_W_HAND = getMethod(EJBHome.class, "remove", new
Class[]{Handle.class});
-    protected static final Method GETHANDLER = getMethod(EJBHomeProxy.class, "getEJBHomeHandler",
(Class) null);
+    protected static final Method GETHANDLER = getMethod(EJBHomeProxy.class, "getEJBHomeHandler",
null);
 
     public EJBHomeHandler() {
     }

Modified: tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBObjectHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBObjectHandler.java?rev=1511694&r1=1511693&r2=1511694&view=diff
==============================================================================
--- tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBObjectHandler.java
(original)
+++ tomee/tomee/trunk/server/openejb-client/src/main/java/org/apache/openejb/client/EJBObjectHandler.java
Thu Aug  8 11:07:43 2013
@@ -48,12 +48,12 @@ public abstract class EJBObjectHandler e
     public static final String OPENEJB_CLIENT_INVOKER_THREADS = "openejb.client.invoker.threads";
     public static final String OPENEJB_CLIENT_INVOKER_QUEUE = "openejb.client.invoker.queue";
 
-    protected static final Method GETEJBHOME = getMethod(EJBObject.class, "getEJBHome", (Class)
null);
-    protected static final Method GETHANDLE = getMethod(EJBObject.class, "getHandle", (Class)
null);
-    protected static final Method GETPRIMARYKEY = getMethod(EJBObject.class, "getPrimaryKey",
(Class) null);
+    protected static final Method GETEJBHOME = getMethod(EJBObject.class, "getEJBHome", 
null);
+    protected static final Method GETHANDLE = getMethod(EJBObject.class, "getHandle", null);
+    protected static final Method GETPRIMARYKEY = getMethod(EJBObject.class, "getPrimaryKey",
 null);
     protected static final Method ISIDENTICAL = getMethod(EJBObject.class, "isIdentical",
EJBObject.class);
-    protected static final Method REMOVE = getMethod(EJBObject.class, "remove", (Class) null);
-    protected static final Method GETHANDLER = getMethod(EJBObjectProxy.class, "getEJBObjectHandler",
(Class) null);
+    protected static final Method REMOVE = getMethod(EJBObject.class, "remove", null);
+    protected static final Method GETHANDLER = getMethod(EJBObjectProxy.class, "getEJBObjectHandler",
 null);
     protected static final Method CANCEL = getMethod(Future.class, "cancel", boolean.class);
 
     //TODO figure out how to configure and manage the thread pool on the client side, this
will do for now...

Modified: tomee/tomee/trunk/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/MultithreadTest.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/MultithreadTest.java?rev=1511694&r1=1511693&r2=1511694&view=diff
==============================================================================
--- tomee/tomee/trunk/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/MultithreadTest.java
(original)
+++ tomee/tomee/trunk/server/openejb-ejbd/src/test/java/org/apache/openejb/server/ejbd/MultithreadTest.java
Thu Aug  8 11:07:43 2013
@@ -293,7 +293,7 @@ public class MultithreadTest {
         public void explode() {
             try {
                 discardedInstances.incrementAndGet();
-                throw new NullPointerException("Test expected this");
+                throw new NullPointerException("Test expected this null pointer");
             } finally {
                 invocations.countDown();
             }



Mime
View raw message