tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tveron...@apache.org
Subject svn commit: r1546013 - in /tomee/tomee/trunk/container/openejb-core: ./ src/main/config/ src/main/config/pmd/ src/main/java/org/apache/openejb/assembler/classic/ src/main/java/org/apache/openejb/assembler/classic/cmd/ src/main/java/org/apache/openejb/c...
Date Wed, 27 Nov 2013 12:21:13 GMT
Author: tveronezi
Date: Wed Nov 27 12:21:12 2013
New Revision: 1546013

URL: http://svn.apache.org/r1546013
Log:
https://issues.apache.org/jira/browse/OPENEJB-2049
PMD EmptyCatchBlock

Added:
    tomee/tomee/trunk/container/openejb-core/src/main/config/
    tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/
    tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml
Modified:
    tomee/tomee/trunk/container/openejb-core/pom.xml
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/CmpJarBuilder.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/cmd/Info2Properties.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Cipher.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/CleanEnvEntries.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Deploy.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentsResolver.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OpenEJBDeploymentManager.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/SunConversion.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Undeploy.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/VmDeploymentManager.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/WsDeployer.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckMethods.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/JaxbOpenejb.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ObjectMap.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ProviderGenerator.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/SimpleTransactionSynchronizationRegistry.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/CmpContainer.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/JaxWsServiceReference.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedHomeHandler.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jacc/BasicJaccProvider.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulEjbHomeHandler.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/DefaultTimerThreadPoolAdapter.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TxBeanManaged.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/ConfUtils.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/IntrospectionSupport.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SuperProperties.java
    tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/UrlCache.java

Modified: tomee/tomee/trunk/container/openejb-core/pom.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/pom.xml?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/pom.xml (original)
+++ tomee/tomee/trunk/container/openejb-core/pom.xml Wed Nov 27 12:21:12 2013
@@ -223,6 +223,15 @@
       org.apache.openejb;version=${openejb.osgi.export.version}
     </openejb.osgi.export>
   </properties>
+  <reporting>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-jxr-plugin</artifactId>
+        <version>2.3</version>
+      </plugin>
+    </plugins>
+  </reporting>
   <build>
     <resources>
       <resource>
@@ -239,6 +248,26 @@
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-pmd-plugin</artifactId>
+        <version>3.0.1</version>
+        <configuration>
+          <linkXRef>true</linkXRef>
+          <sourceEncoding>utf-8</sourceEncoding>
+          <targetJdk>1.6</targetJdk>
+          <rulesets>
+            <ruleset>${project.basedir}/src/main/config/pmd/openejb-empty.xml</ruleset>
+          </rulesets>
+        </configuration>
+        <executions>
+          <execution>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
         <configuration>
           <source>1.6</source>

Added: tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml?rev=1546013&view=auto
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml (added)
+++ tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml Wed Nov 27 12:21:12 2013
@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+
+<ruleset name="Basic"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+  <description>
+    Custom java-basic.xml for openejb-core
+  </description>
+
+  <!-- All the rules from empty.xml -->
+  <rule ref="rulesets/java/empty.xml">
+    <exclude name="EmptyCatchBlock"/>
+    <exclude name="EmptyIfStmt"/>
+    <exclude name="EmptyStatementNotInLoop"/>
+    <exclude name="EmptyWhileStmt"/>
+  </rule>
+
+  <!-- overriding EmptyCatchBlock -->
+  <rule ref="rulesets/java/empty.xml/EmptyCatchBlock">
+    <properties>
+      <property name="allowCommentedBlocks" value="true"/>
+    </properties>
+  </rule>
+
+</ruleset>

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/CmpJarBuilder.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/CmpJarBuilder.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/CmpJarBuilder.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/CmpJarBuilder.java Wed Nov 27 12:21:12 2013
@@ -281,6 +281,7 @@ public class CmpJarBuilder {
             try {
                 jarOutputStream.close();
             } catch (Throwable ignored) {
+                // no-op
             }
         }
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java Wed Nov 27 12:21:12 2013
@@ -300,6 +300,7 @@ public class InterceptorBindingBuilder {
                                 methods.add(method);
                             }
                         } catch (NoSuchMethodException e) {
+                            // no-op
                         }
                     }
                 }
@@ -366,6 +367,7 @@ public class InterceptorBindingBuilder {
                                 methods.add(method);
                             }
                         } catch (NoSuchMethodException e) {
+                            // no-op
                         }
                     }
                 }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java Wed Nov 27 12:21:12 2013
@@ -107,6 +107,7 @@ public class JndiBuilder {
                 Constructor constructor = strategyClass.getConstructor(EjbJarInfo.class, Map.class);
                 return (JndiNameStrategy) constructor.newInstance(ejbJar, deployments);
             } catch (NoSuchMethodException e) {
+                // no-op
             }
 
             Constructor constructor = strategyClass.getConstructor();

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java Wed Nov 27 12:21:12 2013
@@ -168,7 +168,7 @@ public class MethodInfoUtil {
             try {
                 params.add(getClassForParam(methodParam, cl));
             } catch (ClassNotFoundException cnfe) {
-
+                // no-op
             }
         }
         Method method = null;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/cmd/Info2Properties.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/cmd/Info2Properties.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/cmd/Info2Properties.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/cmd/Info2Properties.java Wed Nov 27 12:21:12 2013
@@ -268,6 +268,7 @@ public class Info2Properties {
                     query.put("type", info.types.get(0));
                     uri += "?" + URISupport.createQueryString(query);
                 } catch (Exception e) {
+                    // no-op
                 }
             }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java Wed Nov 27 12:21:12 2013
@@ -501,6 +501,7 @@ public class CdiPlugin extends AbstractO
             try {
                 return intface.getMethod(declaredMethod.getName(), declaredMethod.getParameterTypes());
             } catch (NoSuchMethodException ignore) {
+                // no-op
             }
         }
         return null;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java Wed Nov 27 12:21:12 2013
@@ -540,6 +540,7 @@ public class AnnotationDeployer implemen
         	try {
         		specVersion = Float.parseFloat(connector.getVersion());
         	} catch (Exception e) {
+                // no-op
         	}
 
 			if (specVersion < 1.6 || Boolean.TRUE.equals(connector.isMetadataComplete())) {
@@ -798,6 +799,7 @@ public class AnnotationDeployer implemen
 			// grab a list of ConfigProperty objects
 				configProperties = (List<ConfigProperty>) object.getClass().getDeclaredMethod("getConfigProperty").invoke(object);
 			} catch (Exception e) {
+                // no-op
 			}
 
 			if (configProperties == null) {
@@ -843,6 +845,7 @@ public class AnnotationDeployer implemen
 							try {
 								value = propertyDescriptor.getReadMethod().invoke(o);
 							} catch (Exception e) {
+                                // no-op
 							}
 
 							javax.resource.spi.ConfigProperty annotation = propertyDescriptor.getWriteMethod().getAnnotation(javax.resource.spi.ConfigProperty.class);
@@ -884,6 +887,7 @@ public class AnnotationDeployer implemen
 					try {
 						value = field.get(o);
 					} catch (Exception e) {
+                        // no-op
 					}
 
 					if (! containsConfigProperty(configProperties, name)) {
@@ -1355,6 +1359,7 @@ public class AnnotationDeployer implemen
                         final String ejbName = getEjbName(bean, clazz);
                         bean.setEjbName(ejbName);
                     } catch (Throwable handledInValidation) {
+                        // no-op
                     }
                     ejbModule.getEjbJar().addEnterpriseBean(bean);
                 }
@@ -1704,6 +1709,7 @@ public class AnnotationDeployer implemen
                     if (loader.findResource(path) != null) return true;
                 }
             } catch (Exception e) {
+                // no-op
             }
             return false;
         }
@@ -1927,6 +1933,7 @@ public class AnnotationDeployer implemen
                             }
                         }
                     } catch (ClassNotFoundException ignore) {
+                        // no-op
                     }
                 }
             }
@@ -1941,6 +1948,7 @@ public class AnnotationDeployer implemen
                             }
                         }
                     } catch (ClassNotFoundException ignore) {
+                        // no-op
                     }
                 }
             }
@@ -4562,6 +4570,7 @@ public class AnnotationDeployer implemen
             try {
                 refType = classLoader.loadClass(realClassName(serviceRef.getType()));
             } catch (ClassNotFoundException e) {
+                // no-op
             }
 
             // Set the mappedName

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Cipher.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Cipher.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Cipher.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Cipher.java Wed Nov 27 12:21:12 2013
@@ -109,6 +109,7 @@ public class Cipher {
             Map<String, Class<? extends PasswordCipher>> impls = finder.mapAllImplementations(PasswordCipher.class);
             System.out.println("Available ciphers are: "+ Join.join(", ", impls.keySet()));
         } catch (Exception dontCare) {
+            // no-op
         }
     }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/CleanEnvEntries.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/CleanEnvEntries.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/CleanEnvEntries.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/CleanEnvEntries.java Wed Nov 27 12:21:12 2013
@@ -219,6 +219,7 @@ public class CleanEnvEntries implements 
                 final Field field = clazz.getDeclaredField(target.getInjectionTargetName());
                 return field.getType();
             } catch (NoSuchFieldException e) {
+                // no-op
             }
 
             // TODO Technically we should match by case
@@ -240,6 +241,7 @@ public class CleanEnvEntries implements 
             }
 
         } catch (Throwable e) {
+            // no-op
         }
 
         return Object.class;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java Wed Nov 27 12:21:12 2013
@@ -70,7 +70,9 @@ public class ConfigUtils {
                         return file.getAbsolutePath();
                     }
                 } catch (FileNotFoundException ignored) {
+                    // no-op
                 } catch (IOException ignored) {
+                    // no-op
                 }
 
                 /*
@@ -82,7 +84,9 @@ public class ConfigUtils {
                         return file.getAbsolutePath();
                     }
                 } catch (FileNotFoundException ignored) {
+                    // no-op
                 } catch (IOException ignored) {
+                    // no-op
                 }
 
                 /*
@@ -94,6 +98,7 @@ public class ConfigUtils {
                     // it's so return it unchanged
                     return path;
                 } catch (MalformedURLException ignored) {
+                    // no-op
                 }
             }
             

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Deploy.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Deploy.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Deploy.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Deploy.java Wed Nov 27 12:21:12 2013
@@ -246,6 +246,7 @@ public class Deploy {
             try {
                 Undeploy.undeploy(path, dest, deployer);
             } catch (NoSuchApplicationException nothingToUndeploy) {
+                // no-op
             }
         }
     }
@@ -325,11 +326,13 @@ public class Deploy {
                 return true;
             }
         } catch (IOException e) {
+            // no-op
         } finally {
             if (jarFile != null) {
                 try {
                     jarFile.close();
                 } catch (IOException ignored) {
+                    // no-op
                 }
             }
         }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java Wed Nov 27 12:21:12 2013
@@ -525,6 +525,7 @@ public class DeploymentLoader implements
                             ejbUrl = ClassLoaderUtil.getUrlCachedName(appModule.getJarLocation(), ejbUrl).toURI().toURL();
 
                         } catch (MalformedURLException ignore) {
+                            // no-op
                         }
                     }
                     final File ejbFile = toFile(ejbUrl);
@@ -547,6 +548,7 @@ public class DeploymentLoader implements
                             clientUrl = ClassLoaderUtil.getUrlCachedName(appModule.getJarLocation(), clientUrl).toURI().toURL();
 
                         } catch (MalformedURLException ignore) {
+                            // no-op
                         }
                     }
                     final File clientFile = toFile(clientUrl);
@@ -570,6 +572,7 @@ public class DeploymentLoader implements
                             rarUrl = ClassLoaderUtil.getUrlCachedName(appModule.getJarLocation(), rarUrl).toURI().toURL();
 
                         } catch (MalformedURLException ignore) {
+                            // no-op
                         }
                     }
                     final ConnectorModule connectorModule = createConnectorModule(appId, URLs.toFilePath(rarUrl), appClassLoader, moduleName);

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentsResolver.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentsResolver.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentsResolver.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentsResolver.java Wed Nov 27 12:21:12 2013
@@ -403,6 +403,7 @@ public class DeploymentsResolver impleme
             } catch (IOException e) {
                 logger.warning("Unable to determine the module type of " + url.toExternalForm() + ": Exception: " + e.getMessage(), e);
             } catch (UnknownModuleTypeException ignore) {
+                // no-op
             }
         }
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OpenEJBDeploymentManager.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OpenEJBDeploymentManager.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OpenEJBDeploymentManager.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OpenEJBDeploymentManager.java Wed Nov 27 12:21:12 2013
@@ -370,6 +370,7 @@ public class OpenEJBDeploymentManager im
                 return (DConfigBeanVersionType) field.get(null);
             }
         } catch (Exception e) {
+            // no-op
         }
         throw new DeploymentManagerCreationException("Unknown DConfig bean version: " + string);
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java Wed Nov 27 12:21:12 2013
@@ -99,10 +99,12 @@ public class OutputGeneratedDescriptors 
                 marshaller.marshal(connector, out);
                 logger.info("Dumping Generated ra.xml to: " + tempFile.getAbsolutePath());
             } catch (JAXBException e) {
+                // no-op
             } finally {
                 IO.close(out);
             }
         } catch (IOException e) {
+            // no-op
         }
     }
 
@@ -142,11 +144,13 @@ public class OutputGeneratedDescriptors 
                         JpaJaxbUtil.marshal(Persistence.class, persistence, out);
                         logger.info("Dumping Generated CMP persistence.xml to: " + tempFile.getAbsolutePath());
                     } catch (JAXBException e) {
+                        // no-op
                     } finally {
                         IO.close(out);
                     }
                 }
             } catch (IOException e) {
+                // no-op
             }
         }
         try {
@@ -156,10 +160,12 @@ public class OutputGeneratedDescriptors 
                 JpaJaxbUtil.marshal(EntityMappings.class, appModule.getCmpMappings(), out);
                 logger.info("Dumping Generated CMP mappings.xml to: " + tempFile.getAbsolutePath());
             } catch (JAXBException e) {
+                // no-op
             } finally {
                 IO.close(out);
             }
         } catch (IOException e) {
+            // no-op
         }
     }
 
@@ -180,10 +186,12 @@ public class OutputGeneratedDescriptors 
                 JaxbOpenejbJar3.marshal(OpenejbJar.class, openejbJar, out);
                 logger.info("Dumping Generated openejb-jar.xml to: " + tempFile.getAbsolutePath());
             } catch (JAXBException e) {
+                // no-op
             } finally {
                 IO.close(out);
             }
         } catch (Exception e) {
+            // no-op
         }
     }
 
@@ -200,10 +208,12 @@ public class OutputGeneratedDescriptors 
                 JaxbOpenejbJar2.marshal(GeronimoEjbJarType.class, geronimoEjbJarType, out);
                 logger.info("Dumping Generated geronimo-openejb.xml to: " + tempFile.getAbsolutePath());
             } catch (JAXBException e) {
+                // no-op
             } finally {
                 IO.close(out);
             }
         } catch (Exception e) {
+            // no-op
         }
     }
 
@@ -217,10 +227,12 @@ public class OutputGeneratedDescriptors 
                 EjbJarXml.marshal(ejbJar, out);
                 logger.info("Dumping Generated ejb-jar.xml to: " + tempFile.getAbsolutePath());
             } catch (JAXBException e) {
+                // no-op
             } finally {
                 IO.close(out);
             }
         } catch (Exception e) {
+            // no-op
         }
     }
 }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java Wed Nov 27 12:21:12 2013
@@ -356,6 +356,7 @@ public class ReadDescriptors implements 
                             }
                         });
                     } catch (Exception dontCare) {
+                        // no-op
                     }
 
                     String filePath = "<error: could not be written>";
@@ -374,9 +375,11 @@ public class ReadDescriptors implements 
                         try {
                             IO.copy(source.get(), tempFile);
                         } catch (IOException e) {
+                            // no-op
                         }
                         filePath = tempFile.getAbsolutePath();
                     } catch (IOException e) {
+                        // no-op
                     }
 
                     final Exception e = realIssue[0];
@@ -691,6 +694,7 @@ public class ReadDescriptors implements 
                 }
             });
         } catch (Exception e) {
+            // no-op
         }
 
         return id[0];

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/SunConversion.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/SunConversion.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/SunConversion.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/SunConversion.java Wed Nov 27 12:21:12 2013
@@ -1076,12 +1076,14 @@ public class SunConversion implements Dy
             ClassLoader.getSystemClassLoader().loadClass(type);
             return type;
         } catch (ClassNotFoundException e) {
+            // no-op
         }
         try {
             String javaLangType = "java.lang" + type;
             ClassLoader.getSystemClassLoader().loadClass(javaLangType);
             return javaLangType;
         } catch (ClassNotFoundException e) {
+            // no-op
         }
         return type;
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Undeploy.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Undeploy.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Undeploy.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/Undeploy.java Wed Nov 27 12:21:12 2013
@@ -136,6 +136,7 @@ public class Undeploy {
         try {
             file = file.getCanonicalFile();
         } catch (IOException e) {
+            // no-op
         }
 
         boolean undeployed = false;
@@ -149,6 +150,7 @@ public class Undeploy {
                     throw new DeploymentTerminatedException(messages.format("cmd.undeploy.cantDelete", file.getAbsolutePath()));
                 }
             } catch (NoSuchApplicationException e) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/VmDeploymentManager.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/VmDeploymentManager.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/VmDeploymentManager.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/VmDeploymentManager.java Wed Nov 27 12:21:12 2013
@@ -292,6 +292,7 @@ public class VmDeploymentManager impleme
             try {
                 IO.readProperties(planFile, properties);
             } catch (IOException ignored) {
+                // no-op
             }
         }
 
@@ -316,6 +317,7 @@ public class VmDeploymentManager impleme
             try {
                 properties.load(planStream);
             } catch (IOException ignored) {
+                // no-op
             } finally {
                 close(planStream);
             }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/WsDeployer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/WsDeployer.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/WsDeployer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/WsDeployer.java Wed Nov 27 12:21:12 2013
@@ -448,6 +448,7 @@ public class WsDeployer implements Dynam
                 }
             }
         } catch (Exception e) {
+            // no-op
         }
         return null;
     }
@@ -459,6 +460,7 @@ public class WsDeployer implements Dynam
                 declaringClass = classLoader.loadClass(serviceEndpoint);
                 handlerChain = declaringClass.getAnnotation(HandlerChain.class);
             } catch (ClassNotFoundException ignored) {
+                // no-op
             }
         }
         HandlerChains handlerChains = null;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java Wed Nov 27 12:21:12 2013
@@ -182,6 +182,7 @@ public class CheckClasses extends Valida
         try {
             beanClass = loadClass(b.getEjbClass());
         } catch (OpenEJBException e) {
+            // no-op
         }
 
         if (b instanceof EntityBean){

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckMethods.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckMethods.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckMethods.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckMethods.java Wed Nov 27 12:21:12 2013
@@ -324,6 +324,7 @@ public class CheckMethods extends Valida
                     inLocalHome = true;
                 }
             } catch (NoSuchMethodException e) {
+                // no-op
             }
 
             try {
@@ -332,6 +333,7 @@ public class CheckMethods extends Valida
                     inHome = true;
                 }
             } catch (NoSuchMethodException e) {
+                // no-op
             }
 
             if (!inLocalHome && !inHome){

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/JaxbOpenejb.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/JaxbOpenejb.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/JaxbOpenejb.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/JaxbOpenejb.java Wed Nov 27 12:21:12 2013
@@ -255,6 +255,7 @@ public abstract class JaxbOpenejb {
                 try {
                     out.close();
                 } catch (Exception e) {
+                    // no-op
                 }
             }
         }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ObjectMap.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ObjectMap.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ObjectMap.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ObjectMap.java Wed Nov 27 12:21:12 2013
@@ -67,6 +67,7 @@ public class ObjectMap extends AbstractM
 
                 attributes.put(entry.getKey(), entry);
             } catch (NoSuchMethodException e) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ProviderGenerator.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ProviderGenerator.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ProviderGenerator.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/typed/util/ProviderGenerator.java Wed Nov 27 12:21:12 2013
@@ -378,6 +378,7 @@ public class ProviderGenerator extends R
                 Long.parseLong(value);
                 return "long";
             } catch (NumberFormatException e) {
+                // no-op
             }
         }
 
@@ -385,6 +386,7 @@ public class ProviderGenerator extends R
             Integer.parseInt(value);
             return "int";
         } catch (NumberFormatException e) {
+            // no-op
         }
 
         if (key.toLowerCase().endsWith("url")) {

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/SimpleTransactionSynchronizationRegistry.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/SimpleTransactionSynchronizationRegistry.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/SimpleTransactionSynchronizationRegistry.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/SimpleTransactionSynchronizationRegistry.java Wed Nov 27 12:21:12 2013
@@ -85,6 +85,7 @@ public class SimpleTransactionSynchroniz
         try {
             transaction.registerSynchronization(synchronization);
         } catch (Exception ignored) {
+            // no-op
         }
     }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/CmpContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/CmpContainer.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/CmpContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/CmpContainer.java Wed Nov 27 12:21:12 2013
@@ -396,6 +396,7 @@ public class CmpContainer implements Rpc
             }
             registeredEntities.add(entityBean);
         } catch (Exception e) {
+            // no-op
         }
     }
 
@@ -439,6 +440,7 @@ public class CmpContainer implements Rpc
             try {
                 entityBean.getClass().getMethod("OpenEJB_deleted").invoke(entityBean);
             } catch (Exception ignored) {
+                // no-op
             }
             cancelTimers(callContext);
             ThreadContext.exit(oldCallContext);

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java Wed Nov 27 12:21:12 2013
@@ -112,6 +112,7 @@ public class Cmp2Generator implements Op
                         continue; 
                     }
                 } catch (NoSuchFieldException e) {
+                    // no-op
                 }
                 throw new IllegalArgumentException("No such property " + cmpFieldName + " defined on bean class " + beanClassName);
             }
@@ -503,6 +504,7 @@ public class Cmp2Generator implements Op
             // check to see if we have the getter as an abstract class.  This might be an "is" method. 
             return beanClass.getMethod(getterName, new Class[0]); 
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         
         // we're just going to assume this is the valid name.  Other validation should already have been 
@@ -512,6 +514,7 @@ public class Cmp2Generator implements Op
             // check to see if we have the getter as an abstract class.  This might be an "is" method. 
             return beanClass.getMethod(getterName, new Class[0]); 
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         return null; 
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java Wed Nov 27 12:21:12 2013
@@ -189,6 +189,7 @@ public class IvmContext implements Conte
                 else if (obj != null)
                     return obj;
             } catch (Exception doNothing) {
+                // no-op
             }
         }
 
@@ -215,6 +216,7 @@ public class IvmContext implements Conte
                     ObjectFactory factoryInstance = (ObjectFactory) factoryClass.newInstance();
                     factories.add(factoryInstance);
                 } catch (ClassNotFoundException cnfe) {
+                    // no-op
 
                 } catch (Throwable e) {
                     NamingException ne = new NamingException("Federation failed: Cannot instantiate " + className);
@@ -246,6 +248,7 @@ public class IvmContext implements Conte
                     urlPackagePrefixes = getUrlPackagePrefixes(in);
                 }
             } catch (IOException ignored) {
+                // no-op
             }
         }
 
@@ -259,6 +262,7 @@ public class IvmContext implements Conte
                     in = IO.read(propertiesFile);
                     urlPackagePrefixes = getUrlPackagePrefixes(in);
                 } catch (FileNotFoundException ignored) {
+                    // no-op
                 } finally {
                     IO.close(in);
                 }
@@ -307,6 +311,7 @@ public class IvmContext implements Conte
         try {
             unbind(name);
         } catch (NameNotFoundException e) {
+            // no-op
         }
         bind(name, obj);
     }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/JaxWsServiceReference.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/JaxWsServiceReference.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/JaxWsServiceReference.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/JaxWsServiceReference.java Wed Nov 27 12:21:12 2013
@@ -81,6 +81,7 @@ public class JaxWsServiceReference exten
             try {
                 wsdlUrl = new URL(portAddress.getAddress() + "?wsdl");
             } catch (MalformedURLException e) {
+                // no-op
             }
             serviceQName = portAddress.getServiceQName();
         }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java Wed Nov 27 12:21:12 2013
@@ -131,6 +131,7 @@ public class ManagedContainer implements
                     final Method method = businessLocal.getMethod(removeMethod.getName());
                     methods.put(method, MethodType.REMOVE);
                 } catch (NoSuchMethodException ignore) {
+                    // no-op
                 }
             }
 
@@ -139,6 +140,7 @@ public class ManagedContainer implements
                     final Method method = businessRemote.getMethod(removeMethod.getName());
                     methods.put(method, MethodType.REMOVE);
                 } catch (NoSuchMethodException ignore) {
+                    // no-op
                 }
             }
         }
@@ -149,6 +151,7 @@ public class ManagedContainer implements
                 final Method method = legacyRemote.getMethod("remove");
                 methods.put(method, MethodType.REMOVE);
             } catch (NoSuchMethodException ignore) {
+                // no-op
             }
         }
 
@@ -158,6 +161,7 @@ public class ManagedContainer implements
                 final Method method = legacyLocal.getMethod("remove");
                 methods.put(method, MethodType.REMOVE);
             } catch (NoSuchMethodException ignore) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedHomeHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedHomeHandler.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedHomeHandler.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedHomeHandler.java Wed Nov 27 12:21:12 2013
@@ -46,6 +46,7 @@ public class ManagedHomeHandler extends 
                 field.setAccessible(true);
                 handler = (EjbObjectProxyHandler) field.get(proxy);
             } catch (Exception e1) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jacc/BasicJaccProvider.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jacc/BasicJaccProvider.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jacc/BasicJaccProvider.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jacc/BasicJaccProvider.java Wed Nov 27 12:21:12 2013
@@ -81,6 +81,7 @@ public class BasicJaccProvider extends J
 
                 return configuration.implies(domain, permission);
             } catch (PolicyContextException e) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java Wed Nov 27 12:21:12 2013
@@ -163,6 +163,7 @@ public class StatefulContainer implement
                 final Method method = legacyRemote.getMethod("remove");
                 methods.put(method, MethodType.REMOVE);
             } catch (NoSuchMethodException ignore) {
+                // no-op
             }
         }
 
@@ -172,6 +173,7 @@ public class StatefulContainer implement
                 final Method method = legacyLocal.getMethod("remove");
                 methods.put(method, MethodType.REMOVE);
             } catch (NoSuchMethodException ignore) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulEjbHomeHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulEjbHomeHandler.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulEjbHomeHandler.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulEjbHomeHandler.java Wed Nov 27 12:21:12 2013
@@ -46,6 +46,7 @@ public class StatefulEjbHomeHandler exte
                 field.setAccessible(true);
                 handler = (EjbObjectProxyHandler) field.get(proxy);
             } catch (Exception e1) {
+                // no-op
             }
         }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/DefaultTimerThreadPoolAdapter.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/DefaultTimerThreadPoolAdapter.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/DefaultTimerThreadPoolAdapter.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/DefaultTimerThreadPoolAdapter.java Wed Nov 27 12:21:12 2013
@@ -105,6 +105,7 @@ public class DefaultTimerThreadPoolAdapt
                     try {
                         this.threadAvailableLock.wait(500L);
                     } catch (InterruptedException ignore) {
+                        // no-op
                     }
                 }
                 return threadPoolExecutor.getMaximumPoolSize() - threadPoolExecutor.getActiveCount();

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java Wed Nov 27 12:21:12 2013
@@ -143,6 +143,7 @@ public class MemoryTimerStore implements
                 status = transaction.getStatus();
             }
         } catch (SystemException e) {
+            // no-op
         }
 
         if (status != Status.STATUS_ACTIVE && status != Status.STATUS_MARKED_ROLLBACK) {

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TxBeanManaged.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TxBeanManaged.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TxBeanManaged.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TxBeanManaged.java Wed Nov 27 12:21:12 2013
@@ -95,7 +95,7 @@ public class TxBeanManaged extends JtaTr
                 try {
                     rollbackTransaction(currentTx);
                 } catch (Throwable t) {
-
+                    // no-op
                 }
 
                 /* [3] Throw the RemoteException to the client */

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java Wed Nov 27 12:21:12 2013
@@ -289,6 +289,7 @@ public class JaxWsUtils {
                 Class serviceInterfaceClass = loader.loadClass(serviceInterfaceClassName);
                 return getWsdlLocation(serviceInterfaceClass);
             } catch (Exception e) {
+                // no-op
             }
         }
         return null;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java Wed Nov 27 12:21:12 2013
@@ -314,6 +314,7 @@ public class ProviderWrapper extends Pro
                     try {
                         intf = proxy.getClass().getClassLoader().loadClass(portRef.getServiceEndpointInterface());
                     } catch (Exception e) {
+                        // no-op
                     }
                 }
                 if (qname != null && qname.equals(portRef.getQName()) || intf != null && intf.isInstance(proxy)) {
@@ -366,16 +367,19 @@ public class ProviderWrapper extends Pro
                         return provider;
                     }
                 } catch (Exception ignored) {
+                    // no-op
                 } finally {
                     if (in != null) {
                         try {
                             in.close();
                         } catch (IOException e) {
+                            // no-op
                         }
                     }
                 }
             }
         } catch (Exception ingored) {
+            // no-op
         }
 
         // 2. $java.home/lib/jaxws.properties
@@ -391,6 +395,7 @@ public class ProviderWrapper extends Pro
                     return provider;
                 }
             } catch (Exception ignored) {
+                // no-op
             }
         }
 
@@ -529,6 +534,7 @@ public class ProviderWrapper extends Pro
                     String.class,
                     List.class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         createW3CEndpointReference = method;
 
@@ -539,6 +545,7 @@ public class ProviderWrapper extends Pro
                     Class.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         providerGetPort = method;
 
@@ -546,6 +553,7 @@ public class ProviderWrapper extends Pro
         try {
             method = Provider.class.getMethod("readEndpointReference", Source.class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         readEndpointReference = method;
 
@@ -558,6 +566,7 @@ public class ProviderWrapper extends Pro
                     Service.Mode.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         createDispatchReferenceJaxB = method;
 
@@ -569,6 +578,7 @@ public class ProviderWrapper extends Pro
                     Service.Mode.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         createDispatchReferenceClass = method;
 
@@ -580,6 +590,7 @@ public class ProviderWrapper extends Pro
                     Service.Mode.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         createDispatchJaxBContext = method;
 
@@ -591,6 +602,7 @@ public class ProviderWrapper extends Pro
                     Service.Mode.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         createDispatchInterface = method;
 
@@ -601,6 +613,7 @@ public class ProviderWrapper extends Pro
                     Class.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         serviceGetPortByEndpointReference = method;
 
@@ -611,6 +624,7 @@ public class ProviderWrapper extends Pro
                     Class.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         serviceGetPortByQName = method;
 
@@ -620,6 +634,7 @@ public class ProviderWrapper extends Pro
                     Class.class,
                     WebServiceFeature[].class);
         } catch (NoSuchMethodException e) {
+            // no-op
         }
         serviceGetPortByInterface = method;
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java Wed Nov 27 12:21:12 2013
@@ -286,22 +286,23 @@ public class PseudoTransactionService im
                     try {
                         xaRes.commit(null, true);
                     } catch (XAException e) {
-
+                        // no-op
                     }
                     try {
                         xaRes.end(null, XAResource.TMSUCCESS);
                     } catch (XAException e) {
-
+                        // no-op
                     }
                 } else {
                     try {
                         xaRes.rollback(null);
                     } catch (XAException e) {
-
+                        // no-op
                     }
                     try {
                         xaRes.end(null, XAResource.TMFAIL);
                     } catch (XAException e) {
+                        // no-op
                     }
                 }
             }

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/ConfUtils.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/ConfUtils.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/ConfUtils.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/ConfUtils.java Wed Nov 27 12:21:12 2013
@@ -46,6 +46,7 @@ public class ConfUtils {
                 resource = loginConfig.toURI().toURL();
             }
         } catch (IOException e) {
+            // no-op
         }
 
         return resource;

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/IntrospectionSupport.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/IntrospectionSupport.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/IntrospectionSupport.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/IntrospectionSupport.java Wed Nov 27 12:21:12 2013
@@ -72,6 +72,7 @@ public class IntrospectionSupport {
                     rc = true;
 
                 } catch (Throwable ignore) {
+                    // no-op
                 }
 
             }
@@ -275,6 +276,7 @@ public class IntrospectionSupport {
                     try {
                         o = Arrays.asList((Object[]) o);
                     } catch (Throwable e) {
+                        // no-op
                     }
                 }
                 map.put(field.getName(), o);

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SuperProperties.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SuperProperties.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SuperProperties.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SuperProperties.java Wed Nov 27 12:21:12 2013
@@ -763,6 +763,7 @@ public class SuperProperties extends Pro
         try {
             store(out, comment);
         } catch (IOException e) {
+            // no-op
         }
     }
 

Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/UrlCache.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/UrlCache.java?rev=1546013&r1=1546012&r2=1546013&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/UrlCache.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/UrlCache.java Wed Nov 27 12:21:12 2013
@@ -182,6 +182,7 @@ public class UrlCache {
             try {
                 url = sourceFile.toURI().toURL();
             } catch (MalformedURLException ignored) {
+                // no-op
             }
         }
 
@@ -404,6 +405,7 @@ public class UrlCache {
             try {
                 closeable.close();
             } catch (IOException ignored) {
+                // no-op
             }
         }
     }
@@ -413,6 +415,7 @@ public class UrlCache {
             try {
                 closeable.close();
             } catch (IOException ignored) {
+                // no-op
             }
         }
     }



Mime
View raw message