tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kasmeroglu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TOMEE-1401) Invalid module lookup of OpenEJBDeploymentManager
Date Mon, 13 Oct 2014 01:16:33 GMT

     [ https://issues.apache.org/jira/browse/TOMEE-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Kasmeroglu updated TOMEE-1401:
-------------------------------------
    Attachment: tomee-1401.patch

Patch for SVN trunk

> Invalid module lookup of OpenEJBDeploymentManager
> -------------------------------------------------
>
>                 Key: TOMEE-1401
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1401
>             Project: TomEE
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Daniel Kasmeroglu
>             Fix For: 2.0.0
>
>         Attachments: tomee-1401.patch
>
>
> There is an error in the following methods:
> * getAvailableModules
> * getRunningModules
> * getNonRunningModules
> The error makes the parameter _moduleType_ useless as it's basically ignored. I suspect
that this is the result of an incomplete refactoring attempt.
> See:
> https://kasisoft.com/stash/projects/TOMEE/repos/tomee/commits/b10129e0f66277e003c7ed9f5912faf1f4c65b78
> Apart from that these methods are basically all equal so they could be combined into
a single method (I didn't do that to keep the diff readable).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message