tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yann Blazart (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (TOMEE-1626) Maven Tomee Exec Mojo failed when provided server.xml use env vars
Date Wed, 12 Aug 2015 13:49:46 GMT

     [ https://issues.apache.org/jira/browse/TOMEE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yann Blazart reopened TOMEE-1626:
---------------------------------

Hello Romain.

I see that you didn't took my patch as it was.
So now, as I said to you yesterday, it bugs.

You made the modification to extract values from server.xml and place it in fields, changed
to String. Ok, great the tomee:exec work.

But the tomee:run crash now : 
Caused by: java.lang.NumberFormatException: For input string: "${http.port}"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:569)
	at java.lang.Integer.parseInt(Integer.java:615)
	at org.apache.openejb.maven.plugin.AbstractTomEEMojo.run(AbstractTomEEMojo.java:1013)
	at org.apache.openejb.maven.plugin.UpdatableTomEEMojo.run(UpdatableTomEEMojo.java:91)
	at org.apache.openejb.maven.plugin.AbstractTomEEMojo.execute(AbstractTomEEMojo.java:499)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)

In my patch, I made the code to take the values from system, as this, the same definition
should work to generate the delivring package with tomee:exec and make dev and debug with
tomee:run and tomee:debug.

With the following xml def : 

         <plugin>
                <groupId>org.apache.tomee.maven</groupId>
                <artifactId>tomee-maven-plugin</artifactId>
                <version>7.0.0-SNAPSHOT</version>
                <configuration>
                    <context>/slimer</context>
                    <tomeeVersion>${tomee.version}</tomeeVersion>
                    <systemVariables>
                        <http.port>18080</http.port>


> Maven Tomee Exec Mojo failed when provided server.xml use env vars
> ------------------------------------------------------------------
>
>                 Key: TOMEE-1626
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1626
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Maven Plugin
>    Affects Versions: 7.0.0
>         Environment: windows, unix
>            Reporter: Yann Blazart
>            Assignee: Romain Manni-Bucau
>              Labels: TomEE, maven
>             Fix For: 7.0.0
>
>         Attachments: patch-tome-exec.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When in the tomee exec we provide a server.xml that use en vars, the plugin try to convert
values directly in Integer, it fail.
> Exemple : 
> {code:xml}
>         <Connector port="${http.port}" protocol="HTTP/1.1"
>                    connectionTimeout="20000"
>                    redirectPort="8443" xpoweredBy="false" server="Apache TomEE" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message