tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yann Blazart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-1626) Maven Tomee Exec Mojo failed when provided server.xml use env vars
Date Wed, 12 Aug 2015 16:20:46 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693745#comment-14693745
] 

Yann Blazart commented on TOMEE-1626:
-------------------------------------

After speaking with Romain we can do the following thing :

use -Dtomee-plugin.http=XXXX on the command line with mvn tomee:run.

But surely not use the <tomeeHttpPort> tag in the pom, cause it will override the placeholders
in server.xml with tomee:exec.

So why not, but I find of course my solution more elegant cause it react as is should do with
the java -jar exec.jar.

I mean with the values setted in <systemVariables> tag are used to be replaced by the
tomcat in server.xml, then readed back into the plugin.

But there is anoter way : 

use property ${tomee-plugin.http} in server.xml and set it in <systemVariables> tag
should do the trick.
But the name of the property is not really prod friendly.

> Maven Tomee Exec Mojo failed when provided server.xml use env vars
> ------------------------------------------------------------------
>
>                 Key: TOMEE-1626
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1626
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Maven Plugin
>    Affects Versions: 7.0.0
>         Environment: windows, unix
>            Reporter: Yann Blazart
>            Assignee: Romain Manni-Bucau
>              Labels: TomEE, maven
>             Fix For: 7.0.0
>
>         Attachments: patch-tome-exec-2.diff, patch-tome-exec.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When in the tomee exec we provide a server.xml that use en vars, the plugin try to convert
values directly in Integer, it fail.
> Exemple : 
> {code:xml}
>         <Connector port="${http.port}" protocol="HTTP/1.1"
>                    connectionTimeout="20000"
>                    redirectPort="8443" xpoweredBy="false" server="Apache TomEE" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message