tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andygumbre...@apache.org
Subject tomee git commit: PMD
Date Mon, 02 Nov 2015 19:55:13 GMT
Repository: tomee
Updated Branches:
  refs/heads/tomee-1.7.x b2001c0b9 -> dd1c3412f


PMD


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/dd1c3412
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/dd1c3412
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/dd1c3412

Branch: refs/heads/tomee-1.7.x
Commit: dd1c3412f208cc6ae4dabb7e891316e7dd9a275a
Parents: b2001c0
Author: AndyGee <andy.is@gmx.de>
Authored: Mon Nov 2 20:54:44 2015 +0100
Committer: AndyGee <andy.is@gmx.de>
Committed: Mon Nov 2 20:54:44 2015 +0100

----------------------------------------------------------------------
 .../apache/tomee/jul/formatter/log/ReloadableLog.java   | 12 ++++++------
 .../tomee/jul/handler/rotating/LocalFileHandler.java    |  6 +++---
 .../org/apache/tomee/jul/handler/rotating/Size.java     |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/dd1c3412/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/log/ReloadableLog.java
----------------------------------------------------------------------
diff --git a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/log/ReloadableLog.java
b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/log/ReloadableLog.java
index 9ca1061..21fca4a 100644
--- a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/log/ReloadableLog.java
+++ b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/log/ReloadableLog.java
@@ -34,7 +34,7 @@ public final class ReloadableLog {
 
     public static Log newLog(final String name, final String factory) {
         return Log.class.cast(Proxy.newProxyInstance(
-            ReloadableLog.class.getClassLoader(), INTERFACES, new ReloadableLogHandler(factory,
name)));
+                ReloadableLog.class.getClassLoader(), INTERFACES, new ReloadableLogHandler(factory,
name)));
     }
 
     private static final class ReloadableLogHandler implements InvocationHandler {
@@ -46,7 +46,7 @@ public final class ReloadableLog {
         private volatile String factory;
         private final String name;
         private final AtomicReference<Log> delegate = new AtomicReference<Log>();
-        private volatile boolean done = false;
+        private volatile boolean done;
 
         public ReloadableLogHandler(final String factory, final String name) {
             this.factory = factory;
@@ -93,10 +93,10 @@ public final class ReloadableLog {
 
         private Log newInstance(final String impl) throws InstantiationException, IllegalAccessException,
InvocationTargetException, NoSuchMethodException, ClassNotFoundException {
             return Log.class.cast(Thread.currentThread()
-                        .getContextClassLoader()
-                        .loadClass(impl)
-                        .getConstructor(String.class)
-                        .newInstance(name));
+                    .getContextClassLoader()
+                    .loadClass(impl)
+                    .getConstructor(String.class)
+                    .newInstance(name));
         }
 
         @Override

http://git-wip-us.apache.org/repos/asf/tomee/blob/dd1c3412/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalFileHandler.java
----------------------------------------------------------------------
diff --git a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalFileHandler.java
b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalFileHandler.java
index 6160911..ed4e004 100644
--- a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalFileHandler.java
+++ b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalFileHandler.java
@@ -83,7 +83,7 @@ import java.util.zip.ZipOutputStream;
 public class LocalFileHandler extends Handler {
     private static final int BUFFER_SIZE = 8102;
 
-    private long limit = 0;
+    private long limit;
     private int bufferSize = -1;
     private Pattern filenameRegex;
     private Pattern archiveFilenameRegex;
@@ -569,13 +569,13 @@ public class LocalFileHandler extends Handler {
         }
 
         @Override
-        public void write(final byte buff[]) throws IOException {
+        public void write(final byte[] buff) throws IOException {
             out.write(buff);
             written += buff.length;
         }
 
         @Override
-        public void write(final byte buff[], final int off, final int len) throws IOException
{
+        public void write(final byte[] buff, final int off, final int len) throws IOException
{
             out.write(buff, off, len);
             written += len;
         }

http://git-wip-us.apache.org/repos/asf/tomee/blob/dd1c3412/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/Size.java
----------------------------------------------------------------------
diff --git a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/Size.java
b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/Size.java
index d0de8f0..a7d9844 100644
--- a/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/Size.java
+++ b/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/Size.java
@@ -111,7 +111,7 @@ class Size {
         return unit.toBytes(size);
     }
 
-    private static class Normalize {
+    private static final class Normalize {
         private final long a;
         private final long b;
         private final SizeUnit base;


Mime
View raw message