tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (TOMEE-1827) Possible java.util.ConcurrentModificationException with ValidatingGenericConnectionManager
Date Thu, 02 Jun 2016 20:04:59 GMT

     [ https://issues.apache.org/jira/browse/TOMEE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Romain Manni-Bucau resolved TOMEE-1827.
---------------------------------------
    Resolution: Fixed
      Assignee: Romain Manni-Bucau

resizeLock was badly retrieved, fixed on 7.0.1

> Possible java.util.ConcurrentModificationException with ValidatingGenericConnectionManager
> ------------------------------------------------------------------------------------------
>
>                 Key: TOMEE-1827
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1827
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>    Affects Versions: 7.0.0
>            Reporter: Roberto Cortez
>            Assignee: Romain Manni-Bucau
>             Fix For: 7.0.1
>
>         Attachments: TOMEE-1827.patch
>
>
> When validating Resource Adapters connections with ValidatingGenericConnectionManager,
there is a case that just hands over the pool object directly to the validate method, which
may cause multiple Timer threads to change the connections Set.
> For instance, the validate method might be iterating the connections set, while at the
same time the FillTask Timer thread is filling the min pool. Both in the same object.
> Here is the code:
> {code:java}
> else if (stack instanceof SinglePoolMatchAllConnectionInterceptor) {
>                         connections = (Map<ManagedConnection, ManagedConnectionInfo>)
pool;
>                     }
> ...
> final Set<ManagedConnection> invalids = ValidatingManagedConnectionFactory.class.cast(getManagedConnectionFactory())
>                             .getInvalidConnections(connections.keySet());
> {code}
> This can happen depending on the logic implemented by the Resource Adapter in the getInvalidConnections
method.
> A workaround is to extend the Resource Adapter, override the getInvalidConnections and
just place the original Set elements into a new Set and call the super method.
> Reproduced here:
> https://github.com/radcortez/tomee-resource-adapter
> mvn test -Dtest=com.radcortez.tomee.ra.SampleResourceAdapterValidationTest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message