tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej K (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-1842) Stripping version strips not only a version
Date Tue, 21 Jun 2016 10:18:57 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341510#comment-15341510
] 

Andrzej K commented on TOMEE-1842:
----------------------------------

Hello!
I've tested it and works great for simple scenarios. In my projects, I extensively use <finalName><finalName/>.
For settings where we want final name to be considered, it will not work (artifact name may
have nothing to do with filename).
I think, your solution is very convenient, but I think it should be mentioned that artifact
name is taken, not the final name. I think it can be easily assumed that if someone uses <finalName><finalName/>
he or she needs to pie special attention to naming convention.

Thanks for your activity!

> Stripping version strips not only a version
> -------------------------------------------
>
>                 Key: TOMEE-1842
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1842
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Maven Plugin
>    Affects Versions: 7.0.0
>            Reporter: Andrzej K
>            Assignee: Romain Manni-Bucau
>
> When eaither flag stripWarVersion, or StripVersion is true and artifact names is, for
example, bar.foo:abc-def then plugin strips "\-def" as it looks for first occurence of "\-".
It should rather look for a regex like \[\-\]\d+(.\d+(.\d+)?)?$



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message