tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svetlin Zarev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-1946) TomEE relies on deafult locale
Date Tue, 27 Sep 2016 12:26:21 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525962#comment-15525962
] 

Svetlin Zarev commented on TOMEE-1946:
--------------------------------------

In some places I left the usage of the default locale, because IMO using a fixed locale is
equally incorrect. Those places are: 
MultivaluedMap:144 
ProviderManager:78 
DeploymentResolver:186/464 
ConfigurationFactory:1554
BasicURLClassPath:83
ActiveMQ5Factory:409

> TomEE relies on deafult locale
> ------------------------------
>
>                 Key: TOMEE-1946
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1946
>             Project: TomEE
>          Issue Type: Bug
>            Reporter: Svetlin Zarev
>         Attachments: L_E4F7.tmp.PNG
>
>
> In several places TomEE does not use proper toLower()/toUpper(). The issue is that if
the server relies on the default locale and if the process was started with some non English
compatible locale such as Turkish, toUpper/Lower will yield an incorrect result. For instance
"URI".toLowerCase() will result in "urı" instead of "uri". The same applies to toUpperCase
-> "uri".toUpperCase() will become "URİ" and checks like "string.toUpperCase().equals(someConstant)"
will fail. 
> Patches will be provided via github PR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message