tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2060) EJB component can modify its naming context
Date Fri, 16 Jun 2017 08:13:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051567#comment-16051567
] 

ASF GitHub Bot commented on TOMEE-2060:
---------------------------------------

Github user rmannibucau commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/72#discussion_r122386083
  
    --- Diff: container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
---
    @@ -1049,6 +1058,19 @@ private AppContext createApplication(final AppInfo appInfo, ClassLoader
classLoa
             }
         }
     
    +    private void ensureAppNamingContextIsReadOnly(final List<BeanContext> allDeployments)
{
    +        for(BeanContext beanContext : allDeployments) {
    +            Context ctx = beanContext.getJndiContext();
    +            if(ctx instanceof IvmContext) {
    +               ((IvmContext) ctx).setReadOnly(true);
    +            } else if(ctx instanceof ContextHandler) {
    +            ((ContextHandler)ctx).setReadOnly();
    +            } else {
    +                //TODO: log only?
    --- End diff --
    
    shouldn't be possible so can be ignored for now


> EJB component can modify its naming context
> -------------------------------------------
>
>                 Key: TOMEE-2060
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2060
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>    Affects Versions: 7.0.3
>            Reporter: Katya Todorova
>
> According to the Java EE specification (6/7) EE.5.3.4:
> The container must ensure that the application component instances have only
> read access to their naming context. The container must throw the
> javax.naming.OperationNotSupportedException from all the methods of the
> javax.naming.Context interface that modify the environment naming context
> and its subcontexts.
> It seems that IvmContext checks if the naming context is read-only and throws the corresponding
exception but the flag is false by default and is never changed.
> Is this done on purpose or is this a todo functionality?  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message