tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2060) EJB component can modify its naming context
Date Tue, 20 Jun 2017 07:38:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055284#comment-16055284
] 

ASF GitHub Bot commented on TOMEE-2060:
---------------------------------------

Github user katya-stoycheva commented on the issue:

    https://github.com/apache/tomee/pull/72
  
    Thank you for reviewing this. Three more questions/comments from my side:
    - Is there Tomee code convention documented somewhere? I tried to stick to the original
format but obviously the IDE has applied some own preferences and I saw check-formatting step
is failing.
    - About the arquillian tests - I have added a test to check only the default behavior
since this is a config change and is applied on container start. (I didn't manage to change
it via the test framework) How do you test different behavior that depends on a system property
for example?  I was thinking of adding new container for each config set but it would require
specifying different mvn profile on build and someone has to invoke these which could be seen
as overhead. Do I need to add more arquillian tests for read-only context? 
    - About logging (on your request: if there is a one time - 10 calls will log a single
time - log line (warning?)) It would need to propagate and synchronize a counter among nested
contexts and it would be unnecessary overhead in my opinion. But if you think this would be
hepful, I can add it.


> EJB component can modify its naming context
> -------------------------------------------
>
>                 Key: TOMEE-2060
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2060
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>    Affects Versions: 7.0.3
>            Reporter: Katya Todorova
>
> According to the Java EE specification (6/7) EE.5.3.4:
> The container must ensure that the application component instances have only
> read access to their naming context. The container must throw the
> javax.naming.OperationNotSupportedException from all the methods of the
> javax.naming.Context interface that modify the environment naming context
> and its subcontexts.
> It seems that IvmContext checks if the naming context is read-only and throws the corresponding
exception but the flag is false by default and is never changed.
> Is this done on purpose or is this a todo functionality?  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message