tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gallimore (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TOMEE-1417) [TEST] Incorrect test function PropertiesTest assertTest
Date Mon, 23 Jul 2018 09:38:03 GMT

     [ https://issues.apache.org/jira/browse/TOMEE-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Gallimore updated TOMEE-1417:
--------------------------------------
    Fix Version/s:     (was: 7.0.5)
                   7.0.6

> [TEST] Incorrect test function PropertiesTest assertTest
> --------------------------------------------------------
>
>                 Key: TOMEE-1417
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1417
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 7.0.0
>            Reporter: Daniel Kasmeroglu
>            Priority: Trivial
>             Fix For: 7.0.6
>
>
> The helper function _PropertiesTest$assertProperties_ contains an invalid comparison
for a different property:
> {code:java}
> if (expectedValue != expectedValue && (expectedValue == null || !expectedValue.equals(actual)))
{
>   ...
> }
> {code}
> The comparison *expectedValue != expectedValue* obviously always returns false so the
contained code will never be executed.
> Furthermore the only use cases of this function returns at it's entry due to the fact
that the supplied parameters are always equal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message