tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2283) New Example: Websocket with TLS and Basic Auth
Date Mon, 26 Nov 2018 17:58:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699372#comment-16699372
] 

ASF GitHub Bot commented on TOMEE-2283:
---------------------------------------

Github user brunobat commented on the issue:

    https://github.com/apache/tomee/pull/214
  
    Hi @rmannibucau ,
    Thanks for your comments. 
    I've performed the following changes:
    * I've removed the NOTICE/LICENSE files.
    * Added missing headers to a few files. 
    * I updated the package name... I had forgot to rename the package name... :)
    * removed value= when 
    * correct, the deplyment name is not needed here. Removed.
    
    In relation to the server.xml and the keystore files...
    The setup is on purpose. My initial idea was to have an arquillian configuration that
can be easily migrated to an actual server. This way, The user can get inspiration to update
their configuration files.
    The keystore can be generated, but I fill it will complicate the example's interpretation.
I feel it's easier like this. 


> New Example: Websocket with TLS and Basic Auth
> ----------------------------------------------
>
>                 Key: TOMEE-2283
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2283
>             Project: TomEE
>          Issue Type: Improvement
>          Components: Examples and Documentation
>    Affects Versions: 8.0.0-Final
>            Reporter: Bruno Baptista
>            Priority: Major
>              Labels: Example, TLS, arquillian, pull-request-available, websocket
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message