tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (TOMEE-2290) Metrics Microprofile Example for @Timed
Date Fri, 23 Nov 2018 18:12:00 GMT


ASF GitHub Bot commented on TOMEE-2290:

GitHub user ivanjunckes opened a pull request:

    TOMEE-2290 - Metrics timed example


You can merge this pull request into a Git repository by running:

    $ git pull metrics-timed-example

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #218
commit db9022e95a0b0ea119146226de10c233f0ff679c
Author: ivanjunckes <ijunckes@...>
Date:   2018-11-23T13:57:51Z

    adding dependencies

commit 533afa8cfa3f8c60d20683603be8b0033a5852e6
Author: ivanjunckes <ijunckes@...>
Date:   2018-11-23T14:02:52Z

    Adding jax-rs resource

commit 1b7baccd47ea7816bf7c03fb2946f25a4cb63e12
Author: ivanjunckes <ijunckes@...>
Date:   2018-11-23T15:32:27Z

    Merge branch 'master' of into metrics-timed-example

commit a87cf682cef5e6ae4c0f46409a9df5f8f4453bef
Author: ivanjunckes <ijunckes@...>
Date:   2018-11-23T18:08:47Z

    Adding test and a few changes


> Metrics Microprofile Example for @Timed
> ---------------------------------------
>                 Key: TOMEE-2290
>                 URL:
>             Project: TomEE
>          Issue Type: Sub-task
>            Reporter: Ivan Junckes Filho
>            Assignee: Ivan Junckes Filho
>            Priority: Major
>              Labels: pull-request-available
> We would like to have an example for MicroProfile Metrics @Timed annotation.
> Here is a quick tutorial on MicroProfile Metrics if you are not aware:
> []
> Fork / clone the TomEE project from here:
> []
> Example name should be _mp-metrics-timed_, following the standard already in the project.
> All the examples are in:
> []
> See this example of @Counted for reference:
> []
> See these two PRs for the diff for @Counted, it will help you see how simple it is:
> []
> []
> What you have to do is:
> 1 - Create a JAX-RS resource WeatherService that has one method with @Timed
> 2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Timed
> 3 - Make sure you have tests for Prometheus and JSON formats
> 4 - Make sure all the tests pass
> After that submit a PR and we'll review it.

This message was sent by Atlassian JIRA

View raw message