[ https://issues.apache.org/jira/browse/TOMEE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698856#comment-16698856
]
ASF GitHub Bot commented on TOMEE-2290:
---------------------------------------
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/218#discussion_r236229984
--- Diff: pom.xml ---
@@ -208,7 +208,7 @@
<microprofile.health.version>1.0</microprofile.health.version>
<microprofile.health.impl.version>1.0.0</microprofile.health.impl.version>
<microprofile.metrics.version>1.1</microprofile.metrics.version>
- <microprofile.metrics.impl.version>1.0.0</microprofile.metrics.impl.version>
+ <microprofile.metrics.impl.version>1.0.1-SNAPSHOT</microprofile.metrics.impl.version>
--- End diff --
Hi @ivanjunckes I get an error here:
`[ERROR] Failed to execute goal on project tomee-microprofile-webapp: Could not resolve
dependencies for project org.apache.tomee:tomee-microprofile-webapp:war:8.0.0-SNAPSHOT: Failure
to find org.apache.geronimo:geronimo-metrics:jar:1.0.1-SNAPSHOT in https://repository.apache.org/service/local/repositories/orgapachegeronimo-1067/content/
was cached in the local repository, resolution will not be reattempted until the update interval
of Geronimo OpenAPI Staging has elapsed or updates are forced`
The lib is not found in the maven repo.
> Metrics Microprofile Example for @Timed
> ---------------------------------------
>
> Key: TOMEE-2290
> URL: https://issues.apache.org/jira/browse/TOMEE-2290
> Project: TomEE
> Issue Type: Sub-task
> Reporter: Ivan Junckes Filho
> Assignee: Ivan Junckes Filho
> Priority: Major
> Labels: pull-request-available
>
> We would like to have an example for MicroProfile Metrics @Timed annotation.
> Here is a quick tutorial on MicroProfile Metrics if you are not aware:
> [https://www.tomitribe.com/blog/getting-started-with-microprofile-metrics/]
> Fork / clone the TomEE project from here:
> [https://github.com/apache/tomee]
> Example name should be _mp-metrics-timed_, following the standard already in the project.
> All the examples are in:
> [https://github.com/apache/tomee/tree/master/examples]
> See this example of @Counted for reference:
> [https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]
> See these two PRs for the diff for @Counted, it will help you see how simple it is:
> [https://github.com/apache/tomee/pull/203]
> [https://github.com/apache/tomee/pull/207]
> What you have to do is:
> 1 - Create a JAX-RS resource WeatherService that has one method with @Timed
> 2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Timed
> 3 - Make sure you have tests for Prometheus and JSON formats
> 4 - Make sure all the tests pass
> After that submit a PR and we'll review it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
|