tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (TOMEE-2960) Add github actions for tomee-7.1.x branch
Date Thu, 21 Jan 2021 22:22:00 GMT

     [ https://issues.apache.org/jira/browse/TOMEE-2960?focusedWorklogId=539341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539341
]

ASF GitHub Bot logged work on TOMEE-2960:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/21 22:21
            Start Date: 21/Jan/21 22:21
    Worklog Time Spent: 10m 
      Work Description: cesarhernandezgt commented on pull request #752:
URL: https://github.com/apache/tomee/pull/752#issuecomment-764978908


   > On the `master`, we define an additional step
   > 
   > ```
   >     steps:
   >     - uses: actions/checkout@v2
   >     - name: Set up JDK 1.8
   >       uses: actions/setup-java@v1
   >       with:
   >         java-version: '8'
   > ```
   > 
   > to create a `tmp` directory and set it in the subsequent steps as `java.io.tmpdir`.
   > 
   > **Question:**
   > 
   > * Do we need it here too?
   > * Should we align the `master` workflow with this changes too? Separating the steps
seems reasonable to me.
   
   Really good questions @rzo1 .
   The `tmp` directory in the github action I created on master was basically inherited form
what I saw on buildbot: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1426
   
   > * Do we need it here too?
   I think we don't need it. My understanding is this was required in buildbot but now we
are not using it on Jenkins and I don't think we need it on Github Actions.
   
   > * Should we align the `master` workflow with this changes too? 
   Yes, I think we should remove this from master: https://github.com/apache/tomee/blob/master/.github/workflows/main.yml#L23-L24
   
   > Separating the steps seems reasonable to me.
   I like it too, I'm familiar with Jenkins pipelines, and having the ability to see specific
step when something went wrong is easier than trying to search within a unique file with a
lot of data. To implement this approach on master will require to double-check the result
we currently have when executing the profile created a couple of weeks ago that has been useful
for TCK related work: -Pstyle,rat
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 539341)
    Time Spent: 20m  (was: 10m)

> Add github actions for tomee-7.1.x branch
> -----------------------------------------
>
>                 Key: TOMEE-2960
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2960
>             Project: TomEE
>          Issue Type: Task
>          Components: TomEE Build
>            Reporter: Cesar Hernandez
>            Assignee: Cesar Hernandez
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, TomEE CI official server is build bot: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
> I'm creating this ticket to navigate the possibility to add the Github Actions to allow
PR test results right from the Github UI for the tomee-7.1.x branch.
>  This ticket doesn't' have as intent to replace the current TomEE apache CI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message