tomee-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan S. Fisher" <jonat...@springventuregroup.com>
Subject Re: ActiveMQ Artemis?
Date Tue, 27 Oct 2015 15:46:17 GMT
NICE!!! I see what I did wrong, I added DissociatableManagedConnection to
the actual connection interface, not the GenericManagedConnection



On Sun, Oct 25, 2015 at 1:43 PM, Romain Manni-Bucau <rmannibucau@gmail.com>
wrote:

> @Jonathan: Disassociable hack works fine:
>
> diff --git
> a/files/client/src/main/java/com/abien/filestore/FilesResource.java
> b/files/client/src/main/java/com/abien/filestore/FilesResource.java
> index 0dee533..3e5f200 100644
> --- a/files/client/src/main/java/com/abien/filestore/FilesResource.java
> +++ b/files/client/src/main/java/com/abien/filestore/FilesResource.java
> @@ -19,7 +19,7 @@ import org.connectorz.files.BucketStore;
>  @Produces(MediaType.TEXT_PLAIN)
>  public class FilesResource {
>
> -    @Resource(name = "jca/files")
> +    @Resource(name = "jca-file-store")
>      BucketStore bucketStore;
>
>      @PUT
> diff --git
>
> a/files/store/src/main/java/org/connectorz/files/store/GenericManagedConnection.java
>
> b/files/store/src/main/java/org/connectorz/files/store/GenericManagedConnection.java
> index 355c6c2..689ea00 100644
> ---
>
> a/files/store/src/main/java/org/connectorz/files/store/GenericManagedConnection.java
> +++
>
> b/files/store/src/main/java/org/connectorz/files/store/GenericManagedConnection.java
> @@ -26,7 +26,7 @@ import javax.security.auth.Subject;
>  import javax.transaction.xa.XAResource;
>
>  public class GenericManagedConnection
> -        implements ManagedConnection, LocalTransaction,Closeable {
> +        implements ManagedConnection, LocalTransaction,Closeable,
> DissociatableManagedConnection {
>
>      private ManagedConnectionFactory mcf;
>      private PrintWriter out;
> @@ -53,6 +53,11 @@ public class GenericManagedConnection
>      }
>
>      @Override
> +    public void dissociateConnections() throws ResourceException {
> +        fileConnection = null;
> +    }
> +
> +    @Override
>      public void destroy() {
>          out.println("#GenericManagedConnection.destroy");
>          this.fileConnection.destroy();
> @@ -213,5 +218,4 @@ public class GenericManagedConnection
>          hash = 83 * hash + (this.connectionRequestInfo != null ?
> this.connectionRequestInfo.hashCode() : 0);
>          return hash;
>      }
> -
>  }
>
> Note: i needed to move api jar in tomee/lib and remove it from the rar and
> the webapp as "known".
>
>
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2015-10-24 21:46 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>
> >
> > Le 24 oct. 2015 21:35, "Jonathan S. Fisher" <
> > jonathan@springventuregroup.com> a écrit :
> > >
> > > I was using https://github.com/AdamBien/connectorz Files project as a
> > > testbed. I made the Bucket interface extend
> > > the DissociatableManagedConnection interface and TomEE still proxied
> > it...
> > > oh well.
> > >
> > > I'm going to try and have the Artemis MCF expect the interface rather
> > than
> > > the impl class internally and it may fix the problem. The other
> > alternative
> > > that would make TomEE more compatible is to have the proxies extend the
> > > Implementation and implement the connection interface.
> > >
> >
> > Sounds like jca.next but not current version which relies on an interface
> > by spec.
> >
> > Will check soon this proxy issue with your sample.
> >
> > >
> > > *Jonathan S. Fisher*
> > > *VP - Information Technology*
> > > *Spring Venture Group*
> > > (o) 913-653-8820
> > >
> > > On Sat, Oct 24, 2015 at 9:33 AM, Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > @Jonathan: if you have a sampe ready to run I can check but the idea
> > is to
> > > > track connection usage and "disconnect" when needed -
> > > >
> > > >
> >
> https://docs.oracle.com/javaee/7/api/javax/resource/spi/DissociatableManagedConnection.html
> > > > Le 24 oct. 2015 16:22, "Jonathan S. Fisher" <
> > > > jonathan@springventuregroup.com>
> > > > a écrit :
> > > >
> > > > > Ah, thanks, found it:
> > > > >
> > > > >
> > > >
> >
> https://github.com/apache/activemq-artemis/blob/master/examples/features/sub-modules/artemis-ra-rar/src/main/resources/ra.xml
> > > > >
> > > > >
> > > > >
> > > > > On Sat, Oct 24, 2015 at 9:12 AM, Clebert <
> clebert.suconic@gmail.com>
> > > > > wrote:
> > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://github.com/apache/activemq-artemis/blob/master/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAConnectionFactory.java
> > > > > >
> > > > > > ???
> > > > > >
> > > > > >
> > > > > > I won't be able to come to the computer this weekend ... I Will
> (or
> > > > > > someone else might before then ) look on it properly on Monday.
> > > > > >
> > > > > >
> > > > > > There is also something under the examples as a place holder
for
> > the ra
> > > > > > descriptors.
> > > > > >
> > > > > > -- Clebert Suconic typing on the iPhone.
> > > > > >
> > > > > > > On Oct 24, 2015, at 09:54, Jonathan S. Fisher <
> > > > > > jonathan@springventuregroup.com> wrote:
> > > > > > >
> > > > > > > Also, to ask Clebert a stupid question... I'm looking at
the
> > > > > activemq-ra
> > > > > > > project here:
> > > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://github.com/apache/activemq-artemis/tree/master/artemis-ra/src/main
> > > > > > > And I don't see a rar JCA descriptor file nor the JCA
> > annotations on
> > > > > the
> > > > > > > connection classes. Am I missing something obvious?
> > > > > > >
> > > > > > > On Sat, Oct 24, 2015 at 8:47 AM, Jonathan S. Fisher <
> > > > > > > jonathan@springventuregroup.com> wrote:
> > > > > > >
> > > > > > >> Hey Romain, I'm trying to figure out what exactly the
> > > > > > javax.resource.spi.DissociatableManagedConnection
> > > > > > >> interface is *supposed* to do. Any clues?
> > > > > > >>
> > > > > > >> As an experiment, I used the ConnectorZ project as
a test bed
> > at had
> > > > > it
> > > > > > >> implement that method... TomEE still proxied the connection
> > class,
> > > > so
> > > > > it
> > > > > > >> might be a mute point anyway.
> > > > > > >>
> > > > > > >>
> > > > > > >> On Tue, Oct 6, 2015 at 12:07 PM, Romain Manni-Bucau
<
> > > > > > rmannibucau@gmail.com
> > > > > > >>> wrote:
> > > > > > >>
> > > > > > >>> :), let us know if we can help, I'm a bit time
constrained
> ATM
> > to
> > > > > work
> > > > > > on
> > > > > > >>> it by myself but can help on G-connector side/behavior
so
> dont
> > > > > hesitate
> > > > > > >>>
> > > > > > >>>
> > > > > > >>> Romain Manni-Bucau
> > > > > > >>> @rmannibucau <https://twitter.com/rmannibucau>
|  Blog
> > > > > > >>> <http://rmannibucau.wordpress.com> | Github
<
> > > > > > >>> https://github.com/rmannibucau> |
> > > > > > >>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
|
> > Tomitriber
> > > > > > >>> <http://www.tomitribe.com>
> > > > > > >>>
> > > > > > >>> 2015-10-06 19:05 GMT+02:00 Clebert Suconic <
> > > > > clebert.suconic@gmail.com
> > > > > > >:
> > > > > > >>>
> > > > > > >>>> sorry.. dumb copy & paste.. I meant...
Thanks.. it will have
> > to be
> > > > > > >>>> researched as part of this *task* when working
on it.
> > > > > > >>>>
> > > > > > >>>> On Tue, Oct 6, 2015 at 1:05 PM, Clebert Suconic
> > > > > > >>>> <clebert.suconic@gmail.com> wrote:
> > > > > > >>>>> Thanks.. it will have to be researched
as part of this
> class.
> > > > > > >>>>>
> > > > > > >>>>> On Tue, Oct 6, 2015 at 12:54 PM, Romain
Manni-Bucau
> > > > > > >>>>> <rmannibucau@gmail.com> wrote:
> > > > > > >>>>>> if artemis implements
> > > > > > >>> javax.resource.spi.DissociatableManagedConnection
> > > > > > >>>> we
> > > > > > >>>>>> shouldnt proxy it then, does artemis
knows how to handle
> > this
> > > > > event?
> > > > > > >>> If
> > > > > > >>>> not
> > > > > > >>>>>> the proxies is used to handle it.
> > > > > > >>>>>>
> > > > > > >>>>>> Side note: this is geronimo-connector
which handles this
> > code
> > > > (ie
> > > > > > you
> > > > > > >>>> can
> > > > > > >>>>>> reproduce it without tomee in a test
case if it can help
> on
> > > > > artemis
> > > > > > >>>> side)
> > > > > > >>>>>>
> > > > > > >>>>>>
> > > > > > >>>>>> Romain Manni-Bucau
> > > > > > >>>>>> @rmannibucau <https://twitter.com/rmannibucau>
|  Blog
> > > > > > >>>>>> <http://rmannibucau.wordpress.com>
| Github <
> > > > > > >>>> https://github.com/rmannibucau> |
> > > > > > >>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
|
> > Tomitriber
> > > > > > >>>>>> <http://www.tomitribe.com>
> > > > > > >>>>>>
> > > > > > >>>>>> 2015-10-06 18:50 GMT+02:00 Clebert
Suconic <
> > > > > > >>> clebert.suconic@gmail.com>:
> > > > > > >>>>>>
> > > > > > >>>>>>> The issue is not at the CreateEndpoint
method.. the issue
> > is
> > > > that
> > > > > > >>>>>>> Tomee RA requires an interface
returned and defined
> > somewhere
> > > > at
> > > > > > the
> > > > > > >>>>>>> configuration for the ConenctionManager:
> > > > > > >>>
> > > > > >
> > > > >
> > > >
> >
> http://docs.oracle.com/javaee/6/api/javax/resource/spi/ConnectionManager.html#allocateConnection(javax.resource.spi.ManagedConnectionFactory,%20javax.resource.spi.ConnectionRequestInfo)
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > > > > > >>>>>>> Artemis will return objects that
the Endpoints will
> > understand,
> > > > > but
> > > > > > >>>>>>> due to some classLoading model
on Tomee this has to be an
> > > > > interface
> > > > > > >>>>>>> due to the Dynamic proxies created.
> > > > > > >>>>>>>
> > > > > > >>>>>>> On Tue, Oct 6, 2015 at 12:41 PM,
Romain Manni-Bucau
> > > > > > >>>>>>> <rmannibucau@gmail.com> wrote:
> > > > > > >>>>>>>> @Clebert: seems a JCA requirement,
TomEE used it for its
> > JCA
> > > > > > >>>> integration
> > > > > > >>>>>>> -
> > > > > > >>>>>>>> maybe not other servers. I
can't find in the spec
> > something
> > > > > making
> > > > > > >>>> one or
> > > > > > >>>>>>>> the other choice wrong - which
is sounds like a lack to
> > me but
> > > > > > >>> maybe
> > > > > > >>>> I
> > > > > > >>>>>>>> missed a part, browsed the
spec quite quickly.
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>
> > > > > > >>>>>>>> Romain Manni-Bucau
> > > > > > >>>>>>>> @rmannibucau <https://twitter.com/rmannibucau>
|  Blog
> > > > > > >>>>>>>> <http://rmannibucau.wordpress.com>
| Github <
> > > > > > >>>>>>> https://github.com/rmannibucau>
|
> > > > > > >>>>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
|
> > > > Tomitriber
> > > > > > >>>>>>>> <http://www.tomitribe.com>
> > > > > > >>>>>>>>
> > > > > > >>>>>>>> 2015-10-06 18:27 GMT+02:00
clebertsuconic <
> > > > > > >>> clebert.suconic@gmail.com
> > > > > > >>>>> :
> > > > > > >>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>>> On the definition
of the RA, do you agree it should
> > define
> > > > a
> > > > > > >>>>>>> different
> > > > > > >>>>>>>>> interface though?
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> I couldn't understand your
last post well.. it seems
> your
> > > > > > >>> response
> > > > > > >>>> got
> > > > > > >>>>>>>>> garbled with the quote..
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> But anwering this specific
statement, I understand it
> as
> > a
> > > > > > >>>> requirement
> > > > > > >>>>>>> for
> > > > > > >>>>>>>>> Tomee... we can make the
change.. I try to make it
> before
> > > > next
> > > > > > >>>> release:
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> https://issues.apache.org/jira/browse/ARTEMIS-245
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>>
> > > > > > >>>>>>>>> --
> > > > > > >>>>>>>>> View this message in context:
> > > > > > >>>
> > > > > >
> > > > >
> > > >
> >
> http://tomee-openejb.979440.n4.nabble.com/ActiveMQ-Artemis-tp4676407p4676426.html
> > > > > > >>>>>>>>> Sent from the TomEE Users
mailing list archive at
> > Nabble.com.
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > > > > > >>>>>>>
> > > > > > >>>>>>> --
> > > > > > >>>>>>> Clebert Suconic
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > > >>>>> --
> > > > > > >>>>> Clebert Suconic
> > > > > > >>>>
> > > > > > >>>>
> > > > > > >>>>
> > > > > > >>>> --
> > > > > > >>>> Clebert Suconic
> > > > > > >
> > > > > > > --
> > > > > > > Email Confidentiality Notice: The information contained
in this
> > > > > > > transmission is confidential, proprietary or privileged
and may
> > be
> > > > > > subject
> > > > > > > to protection under the law, including the Health Insurance
> > > > Portability
> > > > > > and
> > > > > > > Accountability Act (HIPAA). The message is intended for
the
> sole
> > use
> > > > of
> > > > > > the
> > > > > > > individual or entity to whom it is addressed. If you are
not
> the
> > > > > intended
> > > > > > > recipient, you are notified that any use, distribution
or
> > copying of
> > > > > the
> > > > > > > message is strictly prohibited and may subject you to criminal
> or
> > > > civil
> > > > > > > penalties. If you received this transmission in error,
please
> > contact
> > > > > the
> > > > > > > sender immediately by replying to this email and delete
the
> > material
> > > > > from
> > > > > > > any computer.
> > > > > >
> > > > >
> > > > > --
> > > > > Email Confidentiality Notice: The information contained in this
> > > > > transmission is confidential, proprietary or privileged and may be
> > > > subject
> > > > > to protection under the law, including the Health Insurance
> > Portability
> > > > and
> > > > > Accountability Act (HIPAA). The message is intended for the sole
> use
> > of
> > > > the
> > > > > individual or entity to whom it is addressed. If you are not the
> > intended
> > > > > recipient, you are notified that any use, distribution or copying
> of
> > the
> > > > > message is strictly prohibited and may subject you to criminal or
> > civil
> > > > > penalties. If you received this transmission in error, please
> > contact the
> > > > > sender immediately by replying to this email and delete the
> material
> > from
> > > > > any computer.
> > > > >
> > > >
> > >
> > > --
> > > Email Confidentiality Notice: The information contained in this
> > > transmission is confidential, proprietary or privileged and may be
> > subject
> > > to protection under the law, including the Health Insurance Portability
> > and
> > > Accountability Act (HIPAA). The message is intended for the sole use of
> > the
> > > individual or entity to whom it is addressed. If you are not the
> intended
> > > recipient, you are notified that any use, distribution or copying of
> the
> > > message is strictly prohibited and may subject you to criminal or civil
> > > penalties. If you received this transmission in error, please contact
> the
> > > sender immediately by replying to this email and delete the material
> from
> > > any computer.
> >
>

-- 
Email Confidentiality Notice: The information contained in this 
transmission is confidential, proprietary or privileged and may be subject 
to protection under the law, including the Health Insurance Portability and 
Accountability Act (HIPAA). The message is intended for the sole use of the 
individual or entity to whom it is addressed. If you are not the intended 
recipient, you are notified that any use, distribution or copying of the 
message is strictly prohibited and may subject you to criminal or civil 
penalties. If you received this transmission in error, please contact the 
sender immediately by replying to this email and delete the material from 
any computer.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message