tomee-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: TomEE 7 logger heap leak?
Date Wed, 15 Jun 2016 15:57:04 GMT
2016-06-15 16:46 GMT+02:00 Steve Goldsmith <sgjava@gmail.com>:

> Right, but the container still uses log4j, correct? I want everything to
> use the same logger/format.
>
>
I assume you mean JUL (tomee doesn't use or provide log4j since a lot of
versions)

Normally no, at least for parts we control (so should include tomee,
tomcat, openwebbeans, CXF, openjpa from memory + all slf4j by default libs
of course)


>
> On Wed, Jun 15, 2016 at 10:43 AM, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> wrote:
>
> > this property just redirects logs to slf4j (and therefore logback if
> that's
> > your impl). Then the logger eviction per classloader is on your
> > charge/config.
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2016-06-15 16:41 GMT+02:00 Steve Goldsmith <sgjava@gmail.com>:
> >
> > > Well, I'm using logback as well with slf4j.
> > >
> > > On Wed, Jun 15, 2016 at 10:36 AM, Romain Manni-Bucau <
> > > rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > openejb.log.factory=slf4j is not good enough? We also need a
> > confirmation
> > > > our hypothesis are right or not.
> > > >
> > > >
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com> | JavaEE Factory
> > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > >
> > > > 2016-06-15 16:33 GMT+02:00 Steve Goldsmith <sgjava@gmail.com>:
> > > >
> > > > > OK, so what handler should I use?
> > > > >
> > > > > On Wed, Jun 15, 2016 at 3:20 AM, Romain Manni-Bucau <
> > > > rmannibucau@gmail.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > I see, can be linked to the bridge and I'm not sure logback/jul
> > > > > integration
> > > > > > is able to respect classloaders (didn't check) but tomcat default
> > > > > > LogManager does and we enforce the classloader normally where
we
> > can
> > > so
> > > > > it
> > > > > > shouldn't leak.
> > > > > >
> > > > > > openejb.log.factory=slf4j should allow you to use logback without
> > the
> > > > > > bridge (IIRC you can miss first 2 log lines but their data are
> > > > repeated a
> > > > > > bit later so not a big issue). If it doesn't leak without these
> > > changes
> > > > > > then it would be interesting to test this.
> > > > > >
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress
Blog
> > > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > > https://github.com/rmannibucau> |
> > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > > <http://www.tomitribe.com> | JavaEE Factory
> > > > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > > > >
> > > > > > 2016-06-15 1:21 GMT+02:00 Steve Goldsmith <sgjava@gmail.com>:
> > > > > >
> > > > > > > I sent you a link to the configuration I use, but here's
what I
> > > have:
> > > > > > >
> > > > > > > In TOMEE/bin:
> > > > > > >
> > > > > > >    - logback-config dir
> > > > > > >    - logback.xml
> > > > > > >       - jul-to-slf4j-1.7.7.jar
> > > > > > >    - setenv.sh
> > > > > > >       -
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> CLASSPATH=$CATALINA_HOME/bin/jul-to-slf4j-1.7.7.jar:$CATALINA_HOME/bin/slf4j-api-1.7.7.jar:$CATALINA_HOME/bin/logback-classic-1.1.2.jar:$CATALINA_HOME/bin/logback-core-1.1.2.jar:$CATALINA_HOME/bin/logback-config/
> > > > > > >       - logback-classic-1.1.2.jar
> > > > > > >    - logback-core-1.1.2.jar
> > > > > > >    - slf4j-api-1.7.7.jar
> > > > > > >
> > > > > > > In TOMEE/conf:
> > > > > > >
> > > > > > >    - logging.properties
> > > > > > >       - handlers = org.slf4j.bridge.SLF4JBridgeHandler
> > > > > > >
> > > > > > > I just upgraded to 7.0.0 release from an April snapshot.
First,
> > > I'll
> > > > > see
> > > > > > if
> > > > > > > it pops up again (it takes a week or so), then I'll remove
> > > > > logback/slf4j
> > > > > > > configuration changes. If there's a better way to integrate
> > logback
> > > > I'm
> > > > > > all
> > > > > > > ears.
> > > > > > >
> > > > > > > On Tue, Jun 14, 2016 at 6:37 PM, Romain Manni-Bucau <
> > > > > > rmannibucau@gmail.com
> > > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Not linked to jsonp.
> > > > > > > >
> > > > > > > > First time i see something linked to our logger and
only
> case i
> > > can
> > > > > > think
> > > > > > > > about are linked to bad config or not default setup
so need
> > more
> > > > > > details
> > > > > > > to
> > > > > > > > validate or not and potentially fix it.
> > > > > > > > Le 15 juin 2016 00:32, "Steve Goldsmith" <sgjava@gmail.com>
> a
> > > > écrit
> > > > > :
> > > > > > > >
> > > > > > > > It could be
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://tomee-openejb.979440.n4.nabble.com/TomEE-7-0-0-M3-memory-leak-suspect-td4678194.html
> > > > > > > > since that server is running a snapshot. I'll upgrade
to the
> > > final
> > > > > > > release.
> > > > > > > >
> > > > > > > > On Tue, Jun 14, 2016 at 5:04 PM, Romain Manni-Bucau
<
> > > > > > > rmannibucau@gmail.com
> > > > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Not known and quite unlikely since it is the
tomee/openejb
> > only
> > > > > > logger
> > > > > > > so
> > > > > > > > > should be very few mem.
> > > > > > > > >
> > > > > > > > > What is your logging config?
> > > > > > > > >
> > > > > > > > > Can you reproduce it? Have some instance in prod
for weeks
> > > > without
> > > > > > > issues
> > > > > > > > > but these ones are not in 1000TPS family so can
have missed
> > > sthg.
> > > > > > > > > Le 14 juin 2016 22:56, "sgjava" <sgjava@gmail.com>
a
> écrit :
> > > > > > > > >
> > > > > > > > > > I'm running into a situation where after
about a week of
> > > > runtime
> > > > > > the
> > > > > > > > heap
> > > > > > > > > > gets chewed up. I ran MAT on a heap dump
and get:
> > > > > > > > > >
> > > > > > > > > > The class "org.apache.openejb.util.Logger",
loaded by
> > > > > > > > > > "java.net.URLClassLoader @ 0x83332c88",
occupies
> > > 1,581,490,368
> > > > > > > (93.31%)
> > > > > > > > > > bytes. The memory is accumulated in one
instance of
> > > > > > > > > > "java.util.concurrent.ConcurrentHashMap$Node[]"
loaded by
> > > > > "<system
> > > > > > > > class
> > > > > > > > > > loader>".
> > > > > > > > > >
> > > > > > > > > > Now I'm using logback similar to this
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://hwellmann.blogspot.com/2012/11/logging-with-slf4j-and-logback-in.html
> > > > > > > > > >
> > > > > > > > > > Is this a known issue?
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > View this message in context:
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://tomee-openejb.979440.n4.nabble.com/TomEE-7-logger-heap-leak-tp4678876.html
> > > > > > > > > > Sent from the TomEE Users mailing list archive
at
> > Nabble.com.
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Steven P. Goldsmith
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Steven P. Goldsmith
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Steven P. Goldsmith
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Steven P. Goldsmith
> > >
> >
>
>
>
> --
> Steven P. Goldsmith
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message