tomee-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: Webscoket memory leak
Date Thu, 06 Jul 2017 06:59:15 GMT
yes this was exactly it, a workaround while tomcat was fixing it (to not
prevent us to release if we needed) and then the final fix when tomcat got
enhanced.

The last one is clearly what can be backported


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>

2017-07-06 8:54 GMT+02:00 Matej <gmatej@gmail.com>:

> Hi Romain.
>
> We tried with
> https://github.com/apache/tomee/commit/59e366a86f7b9455701ef520873b76
> 56d9626537
>
> But seems this was an attempt to hack fix withing Tomee.
>
> Then we switched to this to comits:
>
> https://github.com/apache/tomee/commit/fde16235fbf441016a0b44fb4a234c
> dc2394754f
>
> https://github.com/apache/tomee/commit/1b960482eb84513f220c73cca5a1b8
> 6d1770b8d6
> <https://github.com/apache/tomee/commit/fde16235fbf441016a0b44fb4a234c
> dc2394754f#diff-1cbcc8408b2d568b744dc07b68a0dba9>
>
> This fixes it buy using Tomcat destroy and this seems to work.
>
> Thanks.
>
> Any chance we encorporate this into the 1.7 trunk?
>
> BR
>
> Matej
>
>
> 2017-07-05 10:26 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>
> > Maybe debug where (Javaee)InstanceManager.destroy is called but fear
> there
> > was more than a single commit around it. A diff of the
> > JavaeeInstanceManager and WebContext can help
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2017-07-05 10:16 GMT+02:00 Matej <gmatej@gmail.com>:
> >
> > > Romain.
> > >
> > > We tried to cherry-pick the TOMEE-1649 commit and backport it to 1.7.x
> > > branch.
> > >
> > > It compiles, but the memory leaks is still present. Have you got any
> > clues
> > > where to look?
> > >
> > > BR
> > >
> > > Matej
> > >
> > >
> > >
> > >
> > > 2017-07-04 15:40 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
> > >
> > > > factually: it hasnt been done but can be since tomcat needed version
> > was
> > > > 7.0.71
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > > > rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > >
> > > > 2017-07-04 15:39 GMT+02:00 Jonathan Gallimore <
> > jgallimore@tomitribe.com
> > > >:
> > > >
> > > > > I'll check and let you know!
> > > > >
> > > > > Jon
> > > > >
> > > > > On 4 Jul 2017 2:37 pm, "Matej" <gmatej@gmail.com> wrote:
> > > > >
> > > > > > Hi all.
> > > > > >
> > > > > > Any chance this was fixed in the 1.7.x branch?
> > > > > >
> > > > > > http://tomee-openejb.979440.n4.nabble.com/Websocket-
> > > > > > Session-memory-leak-td4676663.html
> > > > > >
> > > > > > BR
> > > > > >
> > > > > > Matej
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message