trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zw...@apache.org
Subject svn commit: r982076 - in /trafficserver/traffic/trunk/proxy: hdrs/ http2/ http2/remap/ logging/ mgmt2/cli/
Date Tue, 03 Aug 2010 23:22:29 GMT
Author: zwoop
Date: Tue Aug  3 23:22:27 2010
New Revision: 982076

URL: http://svn.apache.org/viewvc?rev=982076&view=rev
Log:
TS-400 Checkpoint 9 in cleanup.

Modified:
    trafficserver/traffic/trunk/proxy/hdrs/HTTP.cc
    trafficserver/traffic/trunk/proxy/hdrs/HdrTest.cc
    trafficserver/traffic/trunk/proxy/hdrs/HdrToken.cc
    trafficserver/traffic/trunk/proxy/hdrs/MIME.cc
    trafficserver/traffic/trunk/proxy/hdrs/URL.cc
    trafficserver/traffic/trunk/proxy/http2/HttpTransact.cc
    trafficserver/traffic/trunk/proxy/http2/HttpTransactCache.cc
    trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.cc
    trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.h
    trafficserver/traffic/trunk/proxy/http2/HttpTunnel.cc
    trafficserver/traffic/trunk/proxy/http2/HttpUpdateSM.cc
    trafficserver/traffic/trunk/proxy/http2/HttpUpdateTester.cc
    trafficserver/traffic/trunk/proxy/http2/remap/UrlMappingPathIndex.h
    trafficserver/traffic/trunk/proxy/http2/remap/UrlRewrite.cc
    trafficserver/traffic/trunk/proxy/logging/Log.cc
    trafficserver/traffic/trunk/proxy/logging/LogAccess.cc
    trafficserver/traffic/trunk/proxy/logging/LogBuffer.cc
    trafficserver/traffic/trunk/proxy/logging/LogCollationAccept.h
    trafficserver/traffic/trunk/proxy/logging/LogCollationClientSM.cc
    trafficserver/traffic/trunk/proxy/logging/LogCollationHostSM.cc
    trafficserver/traffic/trunk/proxy/logging/LogConfig.cc
    trafficserver/traffic/trunk/proxy/logging/LogFile.cc
    trafficserver/traffic/trunk/proxy/logging/LogFilter.h
    trafficserver/traffic/trunk/proxy/logging/LogFormat.cc
    trafficserver/traffic/trunk/proxy/logging/LogHost.cc
    trafficserver/traffic/trunk/proxy/logging/LogObject.cc
    trafficserver/traffic/trunk/proxy/logging/LogObject.h
    trafficserver/traffic/trunk/proxy/logging/LogUtils.cc
    trafficserver/traffic/trunk/proxy/mgmt2/cli/CLI.cc
    trafficserver/traffic/trunk/proxy/mgmt2/cli/CLIlineBuffer.cc
    trafficserver/traffic/trunk/proxy/mgmt2/cli/CLImonitor.cc
    trafficserver/traffic/trunk/proxy/mgmt2/cli/CliMain.cc
    trafficserver/traffic/trunk/proxy/mgmt2/cli/CliUtils.cc

Modified: trafficserver/traffic/trunk/proxy/hdrs/HTTP.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/hdrs/HTTP.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/hdrs/HTTP.cc (original)
+++ trafficserver/traffic/trunk/proxy/hdrs/HTTP.cc Tue Aug  3 23:22:27 2010
@@ -60,7 +60,10 @@ static const char *cache_control_names[]
   "need-revalidate-once",
 };
 
+// TODO: We should enable the creation and use of these WKS. XXXX
+#if 0
 static const char *cache_control_values[SIZEOF(cache_control_names)];
+#endif
 
 static DFA *cache_control_names_dfa = NULL;
 
@@ -171,12 +174,6 @@ is_digit(char c)
   return ((c <= '9') && (c >= '0'));
 }
 
-inline static int
-is_ws(char c)
-{
-  return ((c == ParseRules::CHAR_SP) || (c == ParseRules::CHAR_HT));
-}
-
 /***********************************************************************
  *                                                                     *
  *                         M A I N    C O D E                          *
@@ -186,6 +183,10 @@ is_ws(char c)
 void
 http_hdr_adjust(HTTPHdrImpl * hdrp, int32 offset, int32 length, int32 delta)
 {
+  NOWARN_UNUSED(hdrp);
+  NOWARN_UNUSED(offset);
+  NOWARN_UNUSED(length);
+  NOWARN_UNUSED(delta);
   ink_release_assert(!"http_hdr_adjust not implemented");
 }
 
@@ -199,7 +200,6 @@ http_init(const char *path)
 
   if (init) {
     char buf[4096] = "";
-    int i;
 
     init = 0;
 
@@ -306,9 +306,12 @@ http_init(const char *path)
     HTTP_LEN_S_MAXAGE = hdrtoken_wks_to_length(HTTP_VALUE_S_MAXAGE);
     HTTP_LEN_NEED_REVALIDATE_ONCE = hdrtoken_wks_to_length(HTTP_VALUE_NEED_REVALIDATE_ONCE);
 
-    for (i = 0; i < (int) SIZEOF(cache_control_values); i++) {
+    // TODO: We need to look into enable these CC values as WKS XXX
+#if 0
+    for (int i = 0; i < (int) SIZEOF(cache_control_values); i++) {
       cache_control_values[i] = hdrtoken_string_to_wks(cache_control_names[i]);
     }
+#endif
   }
 }
 

Modified: trafficserver/traffic/trunk/proxy/hdrs/HdrTest.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/hdrs/HdrTest.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/hdrs/HdrTest.cc (original)
+++ trafficserver/traffic/trunk/proxy/hdrs/HdrTest.cc Tue Aug  3 23:22:27 2010
@@ -51,6 +51,7 @@
 int
 HdrTest::go(RegressionTest * t, int atype)
 {
+  NOWARN_UNUSED(atype);
   HdrTest::rtest = t;
 
   int status = 1;
@@ -546,9 +547,10 @@ HdrTest::test_mime()
 
   MIMEField *cc_field;
   StrList slist;
-  int slist_count;
+
   cc_field = hdr.field_find("Cache-Control", 13);
-  slist_count = cc_field->value_get_comma_list(&slist); // FIX: correct usage?
+  // TODO: Do we need to check the "count" returned?
+  cc_field->value_get_comma_list(&slist); // FIX: correct usage?
 
   mime_parser_clear(&parser);
 
@@ -740,7 +742,6 @@ HdrTest::test_http_aux(const char *reque
     char buf[NNN];
     int bufindex, last_bufindex;
     int tmp;
-    int err;
     int i;
 
     bufindex = 0;
@@ -1492,7 +1493,7 @@ HdrTest::test_arena_aux(Arena * arena, i
   int verify_len = (int) arena->str_length(str);
 
   if (len != verify_len) {
-    printf("FAILED: requested %d, got %u bytes\n", len, verify_len);
+    printf("FAILED: requested %d, got %d bytes\n", len, verify_len);
     return (1);                 // 1 error (different return convention)
   } else {
     return (0);                 // no errors (different return convention)

Modified: trafficserver/traffic/trunk/proxy/hdrs/HdrToken.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/hdrs/HdrToken.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/hdrs/HdrToken.cc (original)
+++ trafficserver/traffic/trunk/proxy/hdrs/HdrToken.cc Tue Aug  3 23:22:27 2010
@@ -430,7 +430,7 @@ hdrtoken_hash_init()
 
     unsigned int slot = hdrtoken_hash(wks, hdrtoken_str_lengths[wks_idx]);
     if (hdrtoken_hash_table[slot].wks) {
-      printf("ERROR: hdrtoken_hash_table[%d] collision: '%s' replacing '%s'\n",
+      printf("ERROR: hdrtoken_hash_table[%u] collision: '%s' replacing '%s'\n",
              slot, wks, hdrtoken_hash_table[slot].wks);
       ++num_collisions;
     }

Modified: trafficserver/traffic/trunk/proxy/hdrs/MIME.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/hdrs/MIME.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/hdrs/MIME.cc (original)
+++ trafficserver/traffic/trunk/proxy/hdrs/MIME.cc Tue Aug  3 23:22:27 2010
@@ -1055,6 +1055,7 @@ mime_hdr_init(MIMEHdrImpl * mh)
 MIMEFieldBlockImpl *
 _mime_field_block_copy(MIMEFieldBlockImpl * s_fblock, HdrHeap * s_heap, HdrHeap * d_heap)
 {
+  NOWARN_UNUSED(s_heap);
   MIMEFieldBlockImpl *d_fblock;
 
   d_fblock = (MIMEFieldBlockImpl *)
@@ -1810,6 +1811,7 @@ mime_hdr_prepare_for_value_set(HdrHeap *
 void
 mime_field_destroy(MIMEHdrImpl * mh, MIMEField * field)
 {
+  NOWARN_UNUSED(mh);
   ink_debug_assert(field->m_readiness == MIME_FIELD_SLOT_READINESS_DETACHED);
   field->m_readiness = MIME_FIELD_SLOT_READINESS_DELETED;
 }
@@ -1835,6 +1837,7 @@ mime_field_name_set(HdrHeap * heap,
                     MIMEHdrImpl * mh,
                     MIMEField * field, int16 name_wks_idx_or_neg1, const char *name, int length, bool must_copy_string)
 {
+  NOWARN_UNUSED(mh);
   ink_debug_assert(field->m_readiness == MIME_FIELD_SLOT_READINESS_DETACHED);
 
   field->m_wks_idx = name_wks_idx_or_neg1;
@@ -1902,10 +1905,8 @@ mime_field_value_get_comma_val(MIMEField
   } else {
     Str *str;
     StrList list(false);
-    int count = mime_field_value_get_comma_list(field, &list);
-
-    NOWARN_UNUSED(count);
 
+    mime_field_value_get_comma_list(field, &list);
     str = list.get_idx(idx);
     if (str != NULL) {
       *length = (int) (str->len);
@@ -2014,6 +2015,10 @@ _mime_field_value_str_replace_slice(char
                                     const char *old_slice, int old_slice_len,
                                     const char *new_slice, int new_slice_len, int l1, int l2, int l3)
 {
+  // TODO: These prototypes ought to be fixed...
+  NOWARN_UNUSED(new_str_len);
+  NOWARN_UNUSED(old_str_len);
+  NOWARN_UNUSED(old_slice);
   // compute from & to pointers for the copy
   char *f1 = (char *) old_str;
   char *t1 = new_str;
@@ -2945,6 +2950,7 @@ mime_hdr_describe(HdrHeapObjImpl * raw, 
 void
 mime_field_block_describe(HdrHeapObjImpl * raw, bool recurse)
 {
+  NOWARN_UNUSED(recurse); // TODO: This is here only to be compatible with http_hdr_...
   unsigned int i;
   static const char *readiness_names[] = { "EMPTY", "DETACHED", "LIVE", "DELETED" };
 
@@ -2982,6 +2988,7 @@ int
 mime_hdr_print(HdrHeap * heap,
                MIMEHdrImpl * mh, char *buf_start, int buf_length, int *buf_index_inout, int *buf_chars_to_skip_inout)
 {
+  NOWARN_UNUSED(heap);
   MIMEFieldBlockImpl *fblock;
   MIMEField *field;
   uint32 index;

Modified: trafficserver/traffic/trunk/proxy/hdrs/URL.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/hdrs/URL.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/hdrs/URL.cc (original)
+++ trafficserver/traffic/trunk/proxy/hdrs/URL.cc Tue Aug  3 23:22:27 2010
@@ -1577,6 +1577,7 @@ url_print(URLImpl * url, char *buf_start
 void
 url_describe(HdrHeapObjImpl * raw, bool recurse)
 {
+  NOWARN_UNUSED(recurse);
   URLImpl *obj = (URLImpl *) raw;
 
   Debug("http", "[URLTYPE: %d, SWKSIDX: %d,\n", obj->m_url_type, obj->m_scheme_wks_idx);
@@ -1598,7 +1599,7 @@ url_describe(HdrHeapObjImpl * raw, bool 
         obj->m_len_query, (obj->m_ptr_query ? obj->m_ptr_query : "NULL"), obj->m_len_query);
   Debug("http", "\tFRAGMENT: \"%.*s\", FRAGMENT_LEN: %d]\n",
         obj->m_len_fragment, (obj->m_ptr_fragment ? obj->m_ptr_fragment : "NULL"), obj->m_len_fragment);
-};
+}
 
 
 /*-------------------------------------------------------------------------

Modified: trafficserver/traffic/trunk/proxy/http2/HttpTransact.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpTransact.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpTransact.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpTransact.cc Tue Aug  3 23:22:27 2010
@@ -76,22 +76,6 @@ extern int cache_config_vary_on_user_age
 static const char local_host_ip_str[] = "127.0.0.1";
 
 
-/////////////////////////////
-// Inline Utility Routines //
-/////////////////////////////
-inline static bool
-is_empty(char *s)
-{
-  return (s[0] == NUL);
-}
-
-inline static bool
-is_asterisk(char *s)
-{
-  return ((s[0] == '*') && (s[1] == NUL));
-}
-
-
 // someday, reduce the amount of duplicate code between this
 // function and _process_xxx_connection_field_in_outgoing_header
 inline static HTTPKeepAlive
@@ -253,6 +237,7 @@ update_current_info(HttpTransact::Curren
 inline static void
 update_dns_info(HttpTransact::DNSLookupInfo * dns, HttpTransact::CurrentInfo * from, int attempts, Arena * arena)
 {
+  NOWARN_UNUSED(arena);
   dns->looking_up = from->request_to;
   dns->lookup_name = from->server->name;
   dns->attempts = attempts;
@@ -852,7 +837,7 @@ HttpTransact::StartRemapRequest(State * 
 
   HTTPHdr *incoming_request = &(s->hdr_info.client_request);
   URL *url = incoming_request->url_get();
-  int host_len, path_len, method;
+  int host_len, path_len;
   const char *host = url->host_get(&host_len);
   int port = url->port_get();
   const char *path = url->path_get(&path_len);
@@ -866,11 +851,10 @@ HttpTransact::StartRemapRequest(State * 
                  sizeof(local_host_ip_str) - 1) == 0) && (ptr_len_cmp(path, path_len, syntxt, sizeof(syntxt) - 1) == 0);
 
   // Determine whether the incoming request is a Traffic Net request.
-  s->traffic_net_req = ((method = incoming_request->method_get_wksidx()) == HTTP_WKSIDX_POST)
-    &&
-    (ptr_len_cmp
-     (host, host_len, s->http_config_param->tn_server,
-      s->http_config_param->tn_server_len) == 0) && (port == s->http_config_param->tn_port);
+  s->traffic_net_req = (incoming_request->method_get_wksidx() == HTTP_WKSIDX_POST)
+    && (ptr_len_cmp(host, host_len, s->http_config_param->tn_server,
+                    s->http_config_param->tn_server_len) == 0)
+    && (port == s->http_config_param->tn_port);
 
   //////////////////////////////////////////////////////////////////
   // FIX: this logic seems awfully convoluted and hard to follow; //
@@ -982,7 +966,7 @@ HttpTransact::EndRemapRequest(State * s)
 
       char *redirect_url = s->http_config_param->reverse_proxy_no_host_redirect;
       int redirect_url_len = s->http_config_param->reverse_proxy_no_host_redirect_len;
-      int host_len;
+
       const char *host_hdr = incoming_request->value_get(MIME_FIELD_HOST, MIME_LEN_HOST,
                                                          &host_len);
       SET_VIA_STRING(VIA_DETAIL_TUNNEL, VIA_DETAIL_TUNNEL_NO_FORWARD);
@@ -1120,7 +1104,7 @@ HttpTransact::ModifyRequest(State * s)
     if (port > 0) {
       buf = (char *) xmalloc(host_val_len + 15);
       strncpy(buf, hostname, host_val_len);
-      host_val_len += snprintf(buf + host_val_len, host_val_len + 15, ":%u", port);
+      host_val_len += snprintf(buf + host_val_len, host_val_len + 15, ":%d", port);
       host_val = (const char**)(&buf);
     }
 
@@ -5359,6 +5343,7 @@ HttpTransact::get_ka_info_from_host_db(S
                                        ConnectionAttributes *
                                        client_info, HostDBInfo * host_db_info, HttpConfigParams * config_params)
 {
+  NOWARN_UNUSED(client_info);
   ////////////////////////////////////////////////////////
   // Set the keep-alive and version flags for later use //
   // in request construction                            //
@@ -5819,6 +5804,7 @@ HttpTransact::did_forward_server_send_0_
 bool
 HttpTransact::handle_internal_request(State * s, HTTPHdr * incoming_hdr)
 {
+  NOWARN_UNUSED(s);
 #ifdef INK_NO_STAT_PAGES
   return false;
 #else
@@ -6425,6 +6411,7 @@ HttpTransact::url_looks_dynamic(URL * ur
 bool
 HttpTransact::is_request_cache_lookupable(State * s, HTTPHdr * incoming)
 {
+  NOWARN_UNUSED(incoming);
   // ummm, someone has already decided that proxy should tunnel
   if (s->current.mode == TUNNELLING_PROXY) {
     return false;
@@ -6994,12 +6981,14 @@ HttpTransact::is_response_valid(State * 
 bool
 HttpTransact::service_transaction_in_proxy_only_mode(State * s)
 {
+  NOWARN_UNUSED(s);
   return false;
 }
 
 bool
 HttpTransact::setup_transparency(State * s)
 {
+  NOWARN_UNUSED(s);
   bool set = false;
   /*
    * NOTE: removed ARM code from here
@@ -7712,6 +7701,7 @@ HttpTransact::calculate_document_freshne
                                                  int cache_guaranteed_max_lifetime,
                                                  time_t plugin_set_expire_time, State * s)
 {
+  NOWARN_UNUSED(arena);
   bool expires_set, date_set, last_modified_set;
   time_t date_value, expires_value, last_modified_value;
   int min_freshness_bounds, max_freshness_bounds, freshness_limit = 0;
@@ -7878,37 +7868,23 @@ HttpTransact::calculate_freshness_fuzz(S
 //          FRESHNESS_STALE             Too stale, don't use
 //
 //////////////////////////////////////////////////////////////////////////////
-HttpTransact::Freshness_t HttpTransact::what_is_document_freshness(State *
-                                                                   s,
-                                                                   const
-                                                                   HttpConfigParams
-                                                                   *
-                                                                   config,
-                                                                   HTTPHdr
-                                                                   *
-                                                                   client_request,
-                                                                   HTTPHdr
-                                                                   * cached_obj_request, HTTPHdr * cached_obj_response)
-{
-  bool
-    heuristic,
-    do_revalidate = false;
-  int
-    age_limit;
+HttpTransact::Freshness_t
+HttpTransact::what_is_document_freshness(State *s,
+                                         const HttpConfigParams *config,
+                                         HTTPHdr* client_request,
+                                         HTTPHdr* cached_obj_request,
+                                         HTTPHdr * cached_obj_response)
+{
+  NOWARN_UNUSED(cached_obj_request);
+  bool heuristic, do_revalidate = false;
+  int age_limit;
   // These aren't used.
   //HTTPValCacheControl *cc;
   //const char *cc_val;
-  int
-    fresh_limit,
-    current_age;
-  ink_time_t
-    response_date;
-  uint32
-    cc_mask,
-    cooked_cc_mask;
-  uint32
-    os_specifies_revalidate;
-
+  int fresh_limit, current_age;
+  ink_time_t response_date;
+  uint32 cc_mask, cooked_cc_mask;
+  uint32 os_specifies_revalidate;
 
   //////////////////////////////////////////////////////
   // If config file has a ttl-in-cache field set,     //
@@ -9302,31 +9278,21 @@ HttpTransact::update_aol_stats(State * s
 void
 HttpTransact::update_size_and_time_stats(State * s,
                                          ink_hrtime total_time,
-                                         ink_hrtime
-                                         user_agent_write_time,
-                                         ink_hrtime
-                                         origin_server_read_time,
+                                         ink_hrtime user_agent_write_time,
+                                         ink_hrtime origin_server_read_time,
                                          ink_hrtime cache_lookup_time,
-                                         int
-                                         user_agent_request_header_size,
-                                         int64
-                                         user_agent_request_body_size,
-                                         int
-                                         user_agent_response_header_size,
-                                         int64
-                                         user_agent_response_body_size,
-                                         int
-                                         origin_server_request_header_size,
-                                         int64
-                                         origin_server_request_body_size,
-                                         int
-                                         origin_server_response_header_size,
-                                         int64
-                                         origin_server_response_body_size,
+                                         int user_agent_request_header_size,
+                                         int64 user_agent_request_body_size,
+                                         int user_agent_response_header_size,
+                                         int64 user_agent_response_body_size,
+                                         int origin_server_request_header_size,
+                                         int64 origin_server_request_body_size,
+                                         int origin_server_response_header_size,
+                                         int64 origin_server_response_body_size,
                                          int pushed_response_header_size,
                                          int64 pushed_response_body_size, CacheAction_t cache_action)
 {
-
+  NOWARN_UNUSED(cache_action);
   int64 user_agent_request_size = user_agent_request_header_size + user_agent_request_body_size;
   int64 user_agent_response_size = user_agent_response_header_size + user_agent_response_body_size;
   int64 user_agent_bytes = user_agent_request_size + user_agent_response_size;
@@ -9473,7 +9439,7 @@ HttpTransact::update_size_and_time_stats
 void
 HttpTransact::initialize_bypass_variables(State * s)
 {
-
+  NOWARN_UNUSED(s);
   //////////////////////////////////////////
   // Handle potential transparency errors //
   //////////////////////////////////////////

Modified: trafficserver/traffic/trunk/proxy/http2/HttpTransactCache.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpTransactCache.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpTransactCache.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpTransactCache.cc Tue Aug  3 23:22:27 2010
@@ -515,7 +515,6 @@ HttpTransactCache::calculate_quality_of_
   bool wildcard_subtype_present = FALSE;
   float wildcard_type_q = 1.0;
   float wildcard_subtype_q = 1.0;
-  int count;
 
   ink_debug_assert((accept_field != NULL) && (content_field != NULL));
 
@@ -537,7 +536,7 @@ HttpTransactCache::calculate_quality_of_
   HttpCompat::parse_mime_type(c_param->str, c_type, c_subtype, sizeof(c_type), sizeof(c_subtype));
 
   // Now loop over Accept field values.
-  count = accept_field->value_get_comma_list(&a_values_list);
+  accept_field->value_get_comma_list(&a_values_list);
   for (a_value = a_values_list.head; a_value; a_value = a_value->next) {
     // Get the raw string to the current comma-sep Accept field value
     a_raw = a_value->str;
@@ -633,7 +632,6 @@ HttpTransactCache::calculate_quality_of_
   const char *default_charset = "iso-8859-1";
   bool wildcard_present = FALSE;
   float wildcard_q = 1.0;
-  int count;
 
   // prefer exact matches
   if (accept_field && cached_accept_field) {
@@ -661,7 +659,7 @@ HttpTransactCache::calculate_quality_of_
   //////////////////////////////////////////////////////////
 
   // Now loop over Accept-Charset field values.
-  count = accept_field->value_get_comma_list(&a_values_list);
+  accept_field->value_get_comma_list(&a_values_list);
   for (a_value = a_values_list.head; a_value; a_value = a_value->next) {
     // Get the raw string to the current comma-sep Accept-Charset field value
     a_raw = a_value->str;
@@ -768,20 +766,17 @@ does_encoding_match(char *enc1, const ch
 ContentEncoding
 HttpTransactCache::match_gzip(MIMEField * accept_field)
 {
-  int count;
   Str *a_value;
   const char *a_raw;
-  int a_raw_len;
   StrList a_values_list;
   if (!accept_field) {
     return NO_GZIP;
   }
-  count = accept_field->value_get_comma_list(&a_values_list);
+  accept_field->value_get_comma_list(&a_values_list);
   for (a_value = a_values_list.head; a_value; a_value = a_value->next) {
     char *a_encoding = NULL;
     StrList a_param_list;
     a_raw = a_value->str;
-    a_raw_len = a_value->len;
     HttpCompat::parse_semicolon_list(&a_param_list, a_raw);
     if (a_param_list.head)
       a_encoding = (char *) a_param_list.head->str;
@@ -798,13 +793,10 @@ HttpTransactCache::match_gzip(MIMEField 
 
 static inline bool
 match_accept_content_encoding(const char *c_raw,
-                              int c_raw_len,
                               MIMEField * accept_field, bool * wildcard_present, float *wildcard_q, float *q)
 {
-  int count;
   Str *a_value;
   const char *a_raw;
-  int a_raw_len;
   StrList a_values_list;
 
   if (!accept_field) {
@@ -813,14 +805,13 @@ match_accept_content_encoding(const char
   ///////////////////////////////////////////////////////////
   // loop over Accept-Encoding elements, looking for match //
   ///////////////////////////////////////////////////////////
-  count = accept_field->value_get_comma_list(&a_values_list);
+  accept_field->value_get_comma_list(&a_values_list);
   for (a_value = a_values_list.head; a_value; a_value = a_value->next) {
     char *a_encoding = NULL;
     StrList a_param_list;
 
     // Get the raw string to the current comma-sep Accept-Charset field value
     a_raw = a_value->str;
-    a_raw_len = a_value->len;
 
     /////////////////////////////////////////////////////////////////
     // break Accept-Encoding piece into semi-colon separated parts //
@@ -863,7 +854,6 @@ HttpTransactCache::calculate_quality_of_
   int c_encoding_len;
   bool wildcard_present = FALSE;
   float wildcard_q = 1.0;
-  int count;
   StrList c_values_list;
   Str *c_value;
   const char *a_raw, *ca_raw;
@@ -891,7 +881,7 @@ HttpTransactCache::calculate_quality_of_
     Debug("http_match", "[calculate_quality_accept_encoding_match]: " "response hdr does not have content-encoding.");
     is_identity_encoding = TRUE;
   } else {
-    count = content_field->value_get_comma_list(&c_values_list);
+    content_field->value_get_comma_list(&c_values_list);
     c_encoding = content_field->value_get(&c_encoding_len);
     if (c_encoding_len == 0) {
       is_identity_encoding = TRUE;
@@ -937,7 +927,7 @@ HttpTransactCache::calculate_quality_of_
   // field, with a q value;
   if (!content_field) {
 
-    if (!match_accept_content_encoding("identity", 8,   // size of "identity"
+    if (!match_accept_content_encoding("identity",
                                        accept_field, &wildcard_present, &wildcard_q, &q)) {
 
       // CE was not returned, and AE does not have identity
@@ -962,7 +952,7 @@ HttpTransactCache::calculate_quality_of_
     for (c_value = c_values_list.head; c_value; c_value = c_value->next) {
       float this_q = -1.0;
       if (!match_accept_content_encoding(c_value->str,
-                                         c_value->len, accept_field, &wildcard_present, &wildcard_q, &this_q)) {
+                                         accept_field, &wildcard_present, &wildcard_q, &this_q)) {
         goto encoding_wildcard;
       }
       combined_q *= this_q;
@@ -1033,12 +1023,10 @@ does_language_range_match(const char *ra
 
 static inline bool
 match_accept_content_language(const char *c_raw,
-                              int c_raw_len,
                               MIMEField * accept_field,
                               bool * wildcard_present,
-                              float *wildcard_q, float *q, int *a_range_length, int *max_a_range_length)
+                              float *wildcard_q, float *q, int *a_range_length)
 {
-  int count;
   const char *a_raw;
   int a_raw_len;
   StrList a_values_list;
@@ -1049,7 +1037,7 @@ match_accept_content_language(const char
   ///////////////////////////////////////////
   // loop over each language-range pattern //
   ///////////////////////////////////////////
-  count = accept_field->value_get_comma_list(&a_values_list);
+  accept_field->value_get_comma_list(&a_values_list);
   for (a_value = a_values_list.head; a_value; a_value = a_value->next) {
     a_raw = a_value->str;
     a_raw_len = a_value->len;
@@ -1080,6 +1068,7 @@ match_accept_content_language(const char
       return true;
     } else if (does_language_range_match(a_range, c_raw)) {
       *q = tq;
+// This is disabled, so removed max_a_range_length from prototype
 //          if (*a_range_length > *max_a_range_length) {
 //              *q = tq;
 //              *max_a_range_length = *a_range_length;
@@ -1105,17 +1094,14 @@ HttpTransactCache::calculate_quality_of_
 {
   float q = -1.0;
   int a_range_length;
-  int max_a_range_length = -1;
   bool wildcard_present = FALSE;
   float wildcard_q = 1.0;
   float min_q = 1.0;
   bool match_found = false;
-  int count;
   StrList c_values_list;
   Str *c_value;
   const char *c_raw, *a_raw, *ca_raw;
-  int c_raw_len, a_raw_len, ca_raw_len;
-
+  int a_raw_len, ca_raw_len;
 
   // Bug 2393700 prefer exact matches
   if (accept_field && cached_accept_field) {
@@ -1135,9 +1121,9 @@ HttpTransactCache::calculate_quality_of_
   // field, with a q value;
 
   if (!content_field) {
-    if (match_accept_content_language("identity", 8,    // strlen of "identity"
+    if (match_accept_content_language("identity",
                                       accept_field,
-                                      &wildcard_present, &wildcard_q, &q, &a_range_length, &max_a_range_length)) {
+                                      &wildcard_present, &wildcard_q, &q, &a_range_length)) {
       goto language_wildcard;
     }
     Debug("http_match", "[calculate_quality_accept_language_match]: " "response hdr does not have content-language.");
@@ -1146,19 +1132,17 @@ HttpTransactCache::calculate_quality_of_
   /////////////////////////////////
   // loop over content languages //
   /////////////////////////////////
-  count = content_field->value_get_comma_list(&c_values_list);
+  content_field->value_get_comma_list(&c_values_list);
   for (c_value = c_values_list.head; c_value; c_value = c_value->next) {
     c_raw = c_value->str;
-    c_raw_len = c_value->len;
 
     ////////////////////////////////
     // get Content-Language value //
     ////////////////////////////////
 
     if (match_accept_content_language(c_raw,
-                                      c_raw_len,
                                       accept_field,
-                                      &wildcard_present, &wildcard_q, &q, &a_range_length, &max_a_range_length)) {
+                                      &wildcard_present, &wildcard_q, &q, &a_range_length)) {
       min_q = (min_q < q ? min_q : q);
       match_found = true;
 //          goto language_wildcard;

Modified: trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.cc Tue Aug  3 23:22:27 2010
@@ -40,18 +40,6 @@
 /*-------------------------------------------------------------------------
   -------------------------------------------------------------------------*/
 
-static inline int
-nstrcpy(char *d, char *as)
-{
-  char *s = as;
-  while (*s)
-    *d++ = *s++;
-  return s - as;
-}
-
-/*-------------------------------------------------------------------------
-  -------------------------------------------------------------------------*/
-
 #define H(_x) (((_x)>9)?((_x)-10+'A'):((_x)+'0'))
 int
 nstrhex(char *d, unsigned int i)
@@ -399,6 +387,7 @@ HttpTransactHeaders::convert_to_1_1_requ
 void
 HttpTransactHeaders::convert_to_0_9_response_header(HTTPHdr * outgoing_response)
 {
+  NOWARN_UNUSED(outgoing_response);
   // Http 0.9 does not require a response header.
 
   // There used to be clear header here, but the state machine
@@ -1202,6 +1191,7 @@ HttpTransactHeaders::insert_via_header_i
                                                   HttpTransact::CacheLookupInfo * cache_info,
                                                   HTTPHdr * header, char *incoming_via, int proxy_ip_address)
 {
+  NOWARN_UNUSED(cache_info);
   char new_via_string[8192];
   char *via_string = new_via_string;
 
@@ -1298,6 +1288,7 @@ HttpTransactHeaders::insert_via_header_i
                                                    HttpTransact::CacheLookupInfo * cache_info,
                                                    HTTPHdr * header, char *incoming_via)
 {
+  NOWARN_UNUSED(cache_info);
   char new_via_string[8192];
   char *via_string = new_via_string;
 
@@ -1496,6 +1487,7 @@ HttpTransactHeaders::_process_xxx_connec
 void
 HttpTransactHeaders::remove_conditional_headers(HTTPHdr * base, HTTPHdr * outgoing)
 {
+  NOWARN_UNUSED(base);
   if (outgoing->presence(MIME_PRESENCE_IF_MODIFIED_SINCE |
                          MIME_PRESENCE_IF_UNMODIFIED_SINCE | MIME_PRESENCE_IF_MATCH | MIME_PRESENCE_IF_NONE_MATCH)) {
 

Modified: trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.h
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.h?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.h (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpTransactHeaders.h Tue Aug  3 23:22:27 2010
@@ -216,6 +216,7 @@ HttpTransactHeaders::nstrcpy(char *d, co
 inline bool
 HttpTransactHeaders::is_request_proxy_authorized(HTTPHdr * incoming_hdr)
 {
+  NOWARN_UNUSED(incoming_hdr);
   HTTP_DEBUG_ASSERT(incoming_hdr);
   return true;
 }

Modified: trafficserver/traffic/trunk/proxy/http2/HttpTunnel.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpTunnel.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpTunnel.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpTunnel.cc Tue Aug  3 23:22:27 2010
@@ -957,8 +957,8 @@ HttpTunnel::producer_handler_dechunked(i
   case HTTP_TUNNEL_EVENT_PRECOMPLETE:
   case VC_EVENT_EOS:
     p->chunked_handler.last_server_event = event;
-    bool done = p->chunked_handler.generate_chunked_content();
-    NOWARN_UNUSED(done);
+    // TODO: Should we check the return code?
+    p->chunked_handler.generate_chunked_content();
     break;
   };
   // Since we will consume all the data if the server is actually finished

Modified: trafficserver/traffic/trunk/proxy/http2/HttpUpdateSM.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpUpdateSM.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpUpdateSM.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpUpdateSM.cc Tue Aug  3 23:22:27 2010
@@ -213,7 +213,7 @@ HttpUpdateSM::set_next_state()
 int
 HttpUpdateSM::kill_this_async_hook(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   STATE_ENTER(&HttpUpdateSM::user_cb_handler, event, data);
 
   MUTEX_TRY_LOCK(lock, cb_action.mutex, this_ethread());

Modified: trafficserver/traffic/trunk/proxy/http2/HttpUpdateTester.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/HttpUpdateTester.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/HttpUpdateTester.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/HttpUpdateTester.cc Tue Aug  3 23:22:27 2010
@@ -93,7 +93,7 @@ UpTest::make_requests()
 int
 UpTest::main_handler(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("http_sch", "Received Event %s", HttpDebugNames::get_event_name(event));
 
   if (event != EVENT_NONE && event != VC_EVENT_IMMEDIATE) {

Modified: trafficserver/traffic/trunk/proxy/http2/remap/UrlMappingPathIndex.h
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/remap/UrlMappingPathIndex.h?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/remap/UrlMappingPathIndex.h (original)
+++ trafficserver/traffic/trunk/proxy/http2/remap/UrlMappingPathIndex.h Tue Aug  3 23:22:27 2010
@@ -73,8 +73,8 @@ private:
 
   // make copy-constructor and assignment operator private
   // till we properly implement them
-  UrlMappingPathIndex(const UrlMappingPathIndex &rhs) { };
-  UrlMappingPathIndex &operator =(const UrlMappingPathIndex &rhs) { return *this; }
+  UrlMappingPathIndex(const UrlMappingPathIndex &rhs) { NOWARN_UNUSED(rhs); };
+  UrlMappingPathIndex &operator =(const UrlMappingPathIndex &rhs) { NOWARN_UNUSED(rhs); return *this; }
 
   inline UrlMappingTrie *_GetTrie(URL *url, int &idx, int port, bool search = true) const
   {

Modified: trafficserver/traffic/trunk/proxy/http2/remap/UrlRewrite.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http2/remap/UrlRewrite.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/http2/remap/UrlRewrite.cc (original)
+++ trafficserver/traffic/trunk/proxy/http2/remap/UrlRewrite.cc Tue Aug  3 23:22:27 2010
@@ -205,7 +205,6 @@ validate_filter_args(acl_filter_rule ** 
   acl_filter_rule *rule;
   unsigned long ul;
   char *argptr, tmpbuf[1024];
-  const char *c;
   SRC_IP_INFO *ipi;
   int i, j, m;
   bool new_rule_flg = false;
@@ -337,7 +336,7 @@ validate_filter_args(acl_filter_rule ** 
         ipi->invert = true;
       strncpy(tmpbuf, argptr, sizeof(tmpbuf) - 1);
       tmpbuf[sizeof(tmpbuf) - 1] = 0; // important! use copy of argument
-      if ((c = ExtractIpRange(tmpbuf, (unsigned long*) &ipi->start, &ipi->end)) != NULL) {
+      if (ExtractIpRange(tmpbuf, (unsigned long*) &ipi->start, &ipi->end) != NULL) {
         Debug("url_rewrite", "[validate_filter_args] Unable to parse IP value in %s", argv[i]);
         snprintf(errStrBuf, errStrBufSize, "Unable to parse IP value in %s", argv[i]);
         errStrBuf[errStrBufSize - 1] = 0;
@@ -610,8 +609,6 @@ UrlRewrite::SetupPacMapping()
   const char *local_url = "http://127.0.0.1/";
 
   url_mapping *mapping;
-  int state = 0;
-  int error = 0;
   int pac_generator_port;
 
   mapping = new url_mapping;
@@ -619,7 +616,6 @@ UrlRewrite::SetupPacMapping()
   mapping->fromURL.create(NULL);
   mapping->fromURL.parse(from_url, strlen(from_url));
 
-  state = error = 0;
   mapping->_default_to_url.create(NULL);
   mapping->_default_to_url.parse(local_url, strlen(local_url));
 
@@ -730,7 +726,7 @@ UrlRewrite::PrintTable(InkHashTable * h_
       um = *mapping_iter;
       um->fromURL.string_get_buf(from_url_buf, (int) sizeof(from_url_buf));
       um->_default_to_url.string_get_buf(to_url_buf, (int) sizeof(to_url_buf));
-      printf("\t %s %s=> %s %s <%s> [plugins %s enabled; running with %d plugins]\n", from_url_buf,
+      printf("\t %s %s=> %s %s <%s> [plugins %s enabled; running with %u plugins]\n", from_url_buf,
              um->unique ? "(unique)" : "", to_url_buf,
              um->homePageRedirect ? "(R)" : "", um->tag ? um->tag : "",
              um->_plugin_count > 0 ? "are" : "not", um->_plugin_count);
@@ -749,6 +745,7 @@ url_mapping *
 UrlRewrite::_tableLookup(InkHashTable * h_table, URL * request_url,
                         int request_port, char *request_host, int request_host_len, char *tag)
 {
+  NOWARN_UNUSED(tag);
   UrlMappingPathIndex *ht_entry;
   url_mapping *um = NULL;
   int ht_result;
@@ -1121,16 +1118,16 @@ bool
       host_hdr = "";
       host_hdr_len = 0;
     }
-    char *tmp = (char *) memchr(host_hdr, ':', host_hdr_len);
+    char *tmpc = (char *) memchr(host_hdr, ':', host_hdr_len);
     int request_port;
 
-    if (tmp == NULL) {
+    if (tmpc == NULL) {
       host_len = host_hdr_len;
       // Get the default port from URL structure
       request_port = request_url->port_get();
     } else {
-      host_len = tmp - host_hdr;
-      request_port = ink_atoi(tmp + 1, host_hdr_len - host_len);
+      host_len = tmpc - host_hdr;
+      request_port = ink_atoi(tmpc + 1, host_hdr_len - host_len);
 
       // If atoi fails, try the default for the
       //   protocol
@@ -1550,7 +1547,7 @@ UrlRewrite::BuildTable()
 
   // Vars to parse line in file
   char *tok_state, *cur_line, *cur_line_tmp;
-  int rparse, cur_line_size, j, cln = 0;        // Our current line number
+  int rparse, cur_line_size, cln = 0;        // Our current line number
 
   // Vars to build the mapping
   const char *fromScheme, *toScheme;
@@ -1568,7 +1565,6 @@ UrlRewrite::BuildTable()
   referer_info *ri;
   int origLength;
   int length;
-  int state, error;
   int tok_count;
 
   RegexMapping reg_map;
@@ -1635,7 +1631,7 @@ UrlRewrite::BuildTable()
 
     tok_count = whiteTok.Initialize(cur_line, SHARE_TOKS);
 
-    for (j = 0; j < tok_count; j++) {
+    for (int j = 0; j < tok_count; j++) {
       if (((char *) whiteTok[j])[0] == '@') {
         if (((char *) whiteTok[j])[1])
           bti.argv[bti.argc++] = xstrdup(&(((char *) whiteTok[j])[1]));
@@ -1728,7 +1724,6 @@ UrlRewrite::BuildTable()
     }
 
     map_from = bti.paramv[1];
-    state = (error = 0);
     length = UrlWhack(map_from, &origLength);
 
     // FIX --- what does this comment mean?
@@ -1751,7 +1746,6 @@ UrlRewrite::BuildTable()
     }
 
     map_to = bti.paramv[2];
-    state = error = 0;
     length = UrlWhack(map_to, &origLength);
     map_to_start = map_to;
     tmp = map_to;
@@ -1951,12 +1945,12 @@ UrlRewrite::BuildTable()
         url_mapping *u_mapping;
         for (int i = 0; h->h_addr_list[i] != NULL; i++) {
           ipv4_name[0] = '\0';
-          int tmp = snprintf(ipv4_name, sizeof(ipv4_name), "%d.%d.%d.%d",
-                                 (unsigned char) h->h_addr_list[i][0],
-                                 (unsigned char) h->h_addr_list[i][1],
-                                 (unsigned char) h->h_addr_list[i][2],
-                                 (unsigned char) h->h_addr_list[i][3]);
-          if (tmp > 0 && tmp < (int) sizeof(ipv4_name)) {       // Create a new url mapping with the IPv4 address.
+          int ip_len = snprintf(ipv4_name, sizeof(ipv4_name), "%hu.%hu.%hu.%hu",
+                                (unsigned char) h->h_addr_list[i][0],
+                                (unsigned char) h->h_addr_list[i][1],
+                                (unsigned char) h->h_addr_list[i][2],
+                                (unsigned char) h->h_addr_list[i][3]);
+          if (ip_len > 0 && ip_len < (int) sizeof(ipv4_name)) {       // Create a new url mapping with the IPv4 address.
             u_mapping = NEW(new url_mapping);
             u_mapping->fromURL.create(NULL);
             u_mapping->fromURL.copy(&new_mapping->fromURL);
@@ -1992,12 +1986,12 @@ UrlRewrite::BuildTable()
         url_mapping *u_mapping;
         for (int i = 0; h->h_addr_list[i] != NULL; i++) {
           ipv4_name[0] = '\0';
-          int tmp;
-          tmp = snprintf(ipv4_name, sizeof(ipv4_name), "%d.%d.%d.%d",
-                             (unsigned char) h->h_addr_list[i][0],
-                             (unsigned char) h->h_addr_list[i][1],
-                             (unsigned char) h->h_addr_list[i][2], (unsigned char) h->h_addr_list[i][3]);
-          if (tmp > 0 && tmp < (int) sizeof(ipv4_name)) {
+          int ip_len;
+          ip_len = snprintf(ipv4_name, sizeof(ipv4_name), "%hu.%hu.%hu.%hu",
+                            (unsigned char) h->h_addr_list[i][0],
+                            (unsigned char) h->h_addr_list[i][1],
+                            (unsigned char) h->h_addr_list[i][2], (unsigned char) h->h_addr_list[i][3]);
+          if (ip_len > 0 && ip_len < (int) sizeof(ipv4_name)) {
             // Create a new url mapping with the IPv4 address.
             u_mapping = NEW(new url_mapping);
             u_mapping->fromURL.create(NULL);
@@ -2028,12 +2022,12 @@ UrlRewrite::BuildTable()
         url_mapping *u_mapping;
         for (int i = 0; h->h_addr_list[i] != NULL; i++) {
           ipv4_name[0] = '\0';
-          int tmp;
-          tmp = snprintf(ipv4_name, sizeof(ipv4_name), "%d.%d.%d.%d",
-                             (unsigned char) h->h_addr_list[i][0],
-                             (unsigned char) h->h_addr_list[i][1],
-                             (unsigned char) h->h_addr_list[i][2], (unsigned char) h->h_addr_list[i][3]);
-          if (tmp > 0 && tmp < (int) sizeof(ipv4_name)) {       // Create a new url mapping with the IPv4 address.
+          int ip_len;
+          ip_len = snprintf(ipv4_name, sizeof(ipv4_name), "%hu.%hu.%hu.%hu",
+                            (unsigned char) h->h_addr_list[i][0],
+                            (unsigned char) h->h_addr_list[i][1],
+                            (unsigned char) h->h_addr_list[i][2], (unsigned char) h->h_addr_list[i][3]);
+          if (ip_len > 0 && ip_len < (int) sizeof(ipv4_name)) {       // Create a new url mapping with the IPv4 address.
             u_mapping = NEW(new url_mapping);
             u_mapping->fromURL.create(NULL);
             u_mapping->fromURL.copy(&new_mapping->fromURL);
@@ -2493,6 +2487,7 @@ UrlRewrite::_regexMappingLookup(RegexMap
                                 const char *request_host, int request_host_len, char *tag, int rank_ceiling,
                                 UrlMappingContainer &mapping_container)
 {
+  NOWARN_UNUSED(tag);
   bool retval = false;
   RegexMappingList::iterator list_iter;
 

Modified: trafficserver/traffic/trunk/proxy/logging/Log.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/Log.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/Log.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/Log.cc Tue Aug  3 23:22:27 2010
@@ -274,10 +274,12 @@ Log::periodic_tasks(long time_now)
   MAIN INTERFACE
   -------------------------------------------------------------------------*/
 
-struct LoggingFlushContinuation:Continuation
+struct LoggingFlushContinuation: public Continuation
 {
   int mainEvent(int event, void *data)
   {
+    NOWARN_UNUSED(event);
+    NOWARN_UNUSED(data);
     Log::flush_thread_main(NULL);
     return 0;
   }
@@ -287,10 +289,12 @@ struct LoggingFlushContinuation:Continua
   }
 };
 
-struct LoggingCollateContinuation:Continuation
+struct LoggingCollateContinuation: public Continuation
 {
   int mainEvent(int event, void *data)
   {
+    NOWARN_UNUSED(event);
+    NOWARN_UNUSED(data);
     Log::collate_thread_main(NULL);
     return 0;
   }
@@ -995,6 +999,10 @@ Log::init_fields()
 int
 Log::handle_logging_mode_change(const char *name, RecDataT data_type, RecData data, void *cookie)
 {
+  NOWARN_UNUSED(name);
+  NOWARN_UNUSED(data_type);
+  NOWARN_UNUSED(data);
+  NOWARN_UNUSED(cookie);
   Debug("log2-config", "Enabled status changed");
   logging_mode_changed = true;
   return 0;

Modified: trafficserver/traffic/trunk/proxy/logging/LogAccess.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogAccess.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogAccess.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogAccess.cc Tue Aug  3 23:22:27 2010
@@ -729,6 +729,9 @@ LogAccess::marshal_client_quality_per(ch
 int
 LogAccess::marshal_http_header_field(LogField::Container container, char *field, char *buf)
 {
+  NOWARN_UNUSED(container);
+  NOWARN_UNUSED(field);
+  NOWARN_UNUSED(buf);
   DEFAULT_STR_FIELD;
 }
 
@@ -739,6 +742,9 @@ LogAccess::marshal_http_header_field(Log
 int
 LogAccess::marshal_http_header_field_escapify(LogField::Container container, char *field, char *buf)
 {
+  NOWARN_UNUSED(container);
+  NOWARN_UNUSED(field);
+  NOWARN_UNUSED(buf);
   DEFAULT_STR_FIELD;
 }
 
@@ -1004,6 +1010,7 @@ LogAccess::marshal_str(char *dest, const
 void
 LogAccess::marshal_mem(char *dest, const char *source, int actual_len, int padded_len)
 {
+  NOWARN_UNUSED(padded_len);
   if (source == NULL || source[0] == 0 || actual_len == 0) {
     source = DEFAULT_STR;
     actual_len = DEFAULT_STR_LEN;

Modified: trafficserver/traffic/trunk/proxy/logging/LogBuffer.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogBuffer.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogBuffer.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogBuffer.cc Tue Aug  3 23:22:27 2010
@@ -481,13 +481,8 @@ LogBuffer::LB_ResultCode LogBuffer::chec
   ink_assert(sign == CLASS_SIGN_LOGBUFFER);
   ink_assert(m_unaligned_buffer != NULL);
 
-  LB_ResultCode
-    ret_val = LB_OK;
-  size_t
-    writers_left;
-  LB_State
-    old_s,
-    new_s;
+  LB_ResultCode ret_val = LB_OK;
+  LB_State old_s, new_s;
 
   do {
     old_s = m_state;
@@ -499,7 +494,6 @@ LogBuffer::LB_ResultCode LogBuffer::chec
     if (--new_s.s.num_writers == 0) {
       ret_val = (old_s.s.full ? LB_ALL_WRITERS_DONE : LB_OK);
     }
-    writers_left = new_s.s.num_writers;
 
   } while (!switch_state(old_s, new_s));
 
@@ -633,7 +627,6 @@ LogBuffer::resolve_custom_entry(LogField
   if (fieldlist == NULL || printf_str == NULL)
     return 0;
 
-  bool use_alt_fieldlist = false;
   int *readfrom_map = NULL;
 
   if (alt_fieldlist && alt_printf_str) {
@@ -661,7 +654,6 @@ LogBuffer::resolve_custom_entry(LogField
         break;
       }
     }
-    use_alt_fieldlist = true;
   }
   //
   // Loop over the printf_str, copying everything to the write_to buffer

Modified: trafficserver/traffic/trunk/proxy/logging/LogCollationAccept.h
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogCollationAccept.h?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogCollationAccept.h (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogCollationAccept.h Tue Aug  3 23:22:27 2010
@@ -26,7 +26,7 @@
 
 #include "P_EventSystem.h"
 #include "P_Net.h"
-struct LogCollationAccept:Continuation
+struct LogCollationAccept: public Continuation
 {
 
 public:

Modified: trafficserver/traffic/trunk/proxy/logging/LogCollationClientSM.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogCollationClientSM.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogCollationClientSM.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogCollationClientSM.cc Tue Aug  3 23:22:27 2010
@@ -231,7 +231,7 @@ LogCollationClientSM::send(LogBuffer * l
 int
 LogCollationClientSM::client_auth(int event, VIO * vio)
 {
-
+  NOWARN_UNUSED(vio);
   Debug("log2-coll", "[%d]client::client_auth", m_id);
 
   switch (event) {
@@ -346,7 +346,7 @@ LogCollationClientSM::client_dns(int eve
 int
 LogCollationClientSM::client_done(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]client::client_done", m_id);
 
   switch (event) {
@@ -417,7 +417,7 @@ LogCollationClientSM::client_done(int ev
 int
 LogCollationClientSM::client_fail(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]client::client_fail", m_id);
 
   switch (event) {
@@ -476,7 +476,7 @@ LogCollationClientSM::client_fail(int ev
 int
 LogCollationClientSM::client_idle(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]client::client_idle", m_id);
 
   switch (event) {
@@ -506,7 +506,7 @@ LogCollationClientSM::client_idle(int ev
 int
 LogCollationClientSM::client_init(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]client::client_init", m_id);
 
   switch (event) {
@@ -634,7 +634,7 @@ LogCollationClientSM::client_open(int ev
 int
 LogCollationClientSM::client_send(int event, VIO * vio)
 {
-
+  NOWARN_UNUSED(vio);
   Debug("log2-coll", "[%d]client::client_send", m_id);
 
   switch (event) {

Modified: trafficserver/traffic/trunk/proxy/logging/LogCollationHostSM.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogCollationHostSM.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogCollationHostSM.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogCollationHostSM.cc Tue Aug  3 23:22:27 2010
@@ -155,7 +155,7 @@ LogCollationHostSM::read_handler(int eve
 int
 LogCollationHostSM::host_auth(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]host::host_auth", m_id);
 
   switch (event) {
@@ -208,7 +208,8 @@ LogCollationHostSM::host_auth(int event,
 int
 LogCollationHostSM::host_done(int event, void *data)
 {
-
+  NOWARN_UNUSED(event);
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]host::host_done", m_id);
 
   // close connections
@@ -242,7 +243,7 @@ LogCollationHostSM::host_done(int event,
 int
 LogCollationHostSM::host_init(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]host::host_init", m_id);
 
   switch (event) {
@@ -276,7 +277,7 @@ LogCollationHostSM::host_init(int event,
 int
 LogCollationHostSM::host_recv(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   Debug("log2-coll", "[%d]host::host_recv", m_id);
 
   switch (event) {
@@ -498,7 +499,7 @@ LogCollationHostSM::read_body(int event,
 int
 LogCollationHostSM::read_done(int event, void *data)
 {
-
+  NOWARN_UNUSED(data);
   SET_HANDLER((LogCollationHostSMHandler) & LogCollationHostSM::host_handler);
   return host_handler(event, NULL);
 

Modified: trafficserver/traffic/trunk/proxy/logging/LogConfig.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogConfig.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogConfig.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogConfig.cc Tue Aug  3 23:22:27 2010
@@ -200,6 +200,9 @@ LogConfig::setup_default_values()
 void *
 LogConfig::reconfigure_mgmt_variables(void *token, char *data_raw, int data_len)
 {
+  NOWARN_UNUSED(token);
+  NOWARN_UNUSED(data_raw);
+  NOWARN_UNUSED(data_len);
   Note("[TrafficServer:LogConfig] : Roll_Log_Files event received. rolling now");
   Log::config->roll_log_files_now = true;
   return NULL;
@@ -1277,7 +1280,10 @@ LogConfig::setup_log_objects()
 int
 LogConfig::reconfigure(const char *name, RecDataT data_type, RecData data, void *cookie)
 {
-  printf("x\n");
+  NOWARN_UNUSED(name);
+  NOWARN_UNUSED(data_type);
+  NOWARN_UNUSED(data);
+  NOWARN_UNUSED(cookie);
   Debug("log2-config", "Reconfiguration request accepted");
   Log::config->reconfiguration_needed = true;
   return 0;

Modified: trafficserver/traffic/trunk/proxy/logging/LogFile.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogFile.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogFile.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogFile.cc Tue Aug  3 23:22:27 2010
@@ -473,6 +473,7 @@ LogFile::roll(long interval_start, long 
 int
 LogFile::write(LogBuffer * lb, size_t * to_disk, size_t * to_net, size_t * to_pipe)
 {
+  NOWARN_UNUSED(to_net);
   if (lb == NULL) {
     Note("Cannot write LogBuffer to LogFile %s; LogBuffer is NULL", m_name);
     return -1;

Modified: trafficserver/traffic/trunk/proxy/logging/LogFilter.h
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogFilter.h?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogFilter.h (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogFilter.h Tue Aug  3 23:22:27 2010
@@ -328,6 +328,6 @@ LogFilterString::_checkCondition(Operato
     }
   }
   return retVal;
-};
+}
 
 #endif

Modified: trafficserver/traffic/trunk/proxy/logging/LogFormat.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogFormat.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogFormat.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogFormat.cc Tue Aug  3 23:22:27 2010
@@ -761,7 +761,7 @@ LogFormat::display(FILE * fd)
   };
 
   fprintf(fd, "--------------------------------------------------------\n");
-  fprintf(fd, "Format : %s (%s) (%p), %d fields.\n", m_name_str, types[m_format_type], this, m_field_count);
+  fprintf(fd, "Format : %s (%s) (%p), %u fields.\n", m_name_str, types[m_format_type], this, m_field_count);
   if (m_fieldlist_str) {
     fprintf(fd, "Symbols: %s\n", m_fieldlist_str);
     fprintf(fd, "Fields :\n");

Modified: trafficserver/traffic/trunk/proxy/logging/LogHost.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogHost.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogHost.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogHost.cc Tue Aug  3 23:22:27 2010
@@ -228,6 +228,7 @@ LogHost::disconnect()
 int
 LogHost::write(LogBuffer * lb, size_t * to_disk, size_t * to_net, size_t * to_pipe)
 {
+  NOWARN_UNUSED(to_pipe);
   if (lb == NULL) {
     Note("Cannot write LogBuffer to LogHost %s; LogBuffer is NULL", name());
     return -1;

Modified: trafficserver/traffic/trunk/proxy/logging/LogObject.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogObject.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogObject.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogObject.cc Tue Aug  3 23:22:27 2010
@@ -1036,6 +1036,7 @@ bool
   LogObjectManager::_has_internal_filename_conflict(char *filename,
                                                     uint64 signature, LogObject ** objects, int numObjects)
 {
+  NOWARN_UNUSED(signature);
   for (int i = 0; i < numObjects; i++) {
     LogObject *obj = objects[i];
     if (!obj->is_collation_client()) {
@@ -1109,7 +1110,7 @@ LogObjectManager::_roll_files(long time_
     RELEASE_API_MUTEX("R LogObjectManager::roll_files");
   }
   return num_rolled;
-};
+}
 
 LogObject *
 LogObjectManager::get_object_with_signature(uint64 signature)
@@ -1198,7 +1199,7 @@ LogObjectManager::unmanage_api_object(Lo
   }
   RELEASE_API_MUTEX("R LogObjectManager::unmanage_api_object");
   return 0;
-};
+}
 
 void
 LogObjectManager::add_filter_to_all(LogFilter * filter)

Modified: trafficserver/traffic/trunk/proxy/logging/LogObject.h
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogObject.h?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogObject.h (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogObject.h Tue Aug  3 23:22:27 2010
@@ -448,7 +448,7 @@ LogObjectManager::log(LogAccess * lad)
     ret |= _objects[i]->log(lad);
   }
   return ret;
-};
+}
 
 inline void
 LogObjectManager::display(FILE * str)
@@ -456,7 +456,7 @@ LogObjectManager::display(FILE * str)
   for (size_t i = 0; i < _numObjects; i++) {
     _objects[i]->display(str);
   }
-};
+}
 
 inline LogObject *
 LogObjectManager::find_by_format_name(const char *name)
@@ -467,7 +467,7 @@ LogObjectManager::find_by_format_name(co
     }
   }
   return NULL;
-};
+}
 
 inline size_t
 LogObjectManager::get_num_collation_clients()
@@ -479,7 +479,7 @@ LogObjectManager::get_num_collation_clie
     }
   }
   return coll_clients;
-};
+}
 
 inline bool
 LogObject::operator==(LogObject & old)
@@ -495,7 +495,7 @@ LogObject::operator==(LogObject & old)
              m_rolling_offset_hr == old.m_rolling_offset_hr && m_rolling_size_mb == old.m_rolling_size_mb));
   }
   return false;
-};
+}
 
 inline off_t
 LogObject::get_file_size_bytes()
@@ -515,6 +515,6 @@ LogObject::get_file_size_bytes()
     }
     return max_size;
   }
-};
+}
 
 #endif

Modified: trafficserver/traffic/trunk/proxy/logging/LogUtils.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/logging/LogUtils.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/logging/LogUtils.cc (original)
+++ trafficserver/traffic/trunk/proxy/logging/LogUtils.cc Tue Aug  3 23:22:27 2010
@@ -74,6 +74,7 @@
 
 LogUtils::LogUtils(DoNotConstruct object)
 {
+  NOWARN_UNUSED(object);
   ink_release_assert(!"you can't construct a LogUtils object");
 }
 
@@ -471,7 +472,7 @@ LogUtils::ip_to_hex_str(unsigned ip, cha
     retVal = (retVal == 8) ? 0 : 1;
   }
   return retVal;
-};
+}
 
 /*-------------------------------------------------------------------------
   LogUtils::timestamp_to_hex_str
@@ -506,7 +507,7 @@ LogUtils::timestamp_to_hex_str(unsigned 
     retVal = (retVal == 8) ? 0 : 1;
   }
   return retVal;
-};
+}
 
 /*
 int
@@ -606,7 +607,7 @@ LogUtils::ip_to_str(unsigned ip, char *b
     *numCharsPtr = numChars - 1;
   }
   return retVal;
-};
+}
 
 /*-------------------------------------------------------------------------
   LogUtils::str_to_ip

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli/CLI.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli/CLI.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli/CLI.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli/CLI.cc Tue Aug  3 23:22:27 2010
@@ -499,6 +499,7 @@ CLI_globals::QueryDeadhosts(char *largs,
                             textBuffer * output,        /* IN/OUT: output buffer */
                             cmdline_states plevel /*     IN: command level */ )
 {
+  NOWARN_UNUSED(largs);
   int fd = send_cli_congest_request("list");
   if (fd < 0) {                 // error
     CLI_globals::set_response(output, CLI_globals::failStr, "query for congested servers failed", plevel);
@@ -1108,7 +1109,7 @@ handleOverseer(int fd, int mode)
 {
   const char *ok = "Ok";
   char buf[8192], reply[2048];
-  RecDataT mtype = RECD_NULL;
+  RecDataT mtype;
 
   bool command_allowed;
 
@@ -1170,7 +1171,7 @@ handleOverseer(int fd, int mode)
             continue;
           }
 
-          RecDataT mtype = RECD_NULL;
+          mtype = RECD_NULL;
           if (RecGetRecordDataType(cur, &mtype) == REC_ERR_OKAY) {
             switch (mtype) {
             case RECD_COUNTER:{
@@ -1289,7 +1290,7 @@ handleOverseer(int fd, int mode)
 
       Debug("cli", "handleOverSeer: set config=%s, value=%s \n", var, config_value);
 
-      RecDataT mtype = RECD_NULL;
+      mtype = RECD_NULL;
       RecGetRecordDataType(var, &mtype);
       switch (mtype) {
       case RECD_COUNTER:{

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli/CLIlineBuffer.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli/CLIlineBuffer.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli/CLIlineBuffer.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli/CLIlineBuffer.cc Tue Aug  3 23:22:27 2010
@@ -84,7 +84,7 @@ int
 CLIlineBuffer::numFields()
 {
   return c_fields;
-};
+}
 
 // returns the size of a line i.e. sum of all the field widths
 int

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli/CLImonitor.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli/CLImonitor.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli/CLImonitor.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli/CLImonitor.cc Tue Aug  3 23:22:27 2010
@@ -483,8 +483,8 @@ CLI_monitor::doMonitorProtocolStats(CLI_
   const char *line3 = "                             Client \n";
   const char *line4 = "                             Server \n";
   const char *line6 = "                              ICP \n";
-  const char *line10 = "              Transaction Frequency and Speeds \n";
-  const char *line11 = "Transaction Type              Frequency        Speed(ms)\n";
+  // const char *line10 = "              Transaction Frequency and Speeds \n";
+  // const char *line11 = "Transaction Type              Frequency        Speed(ms)\n";
   const char *line12 = "                 Queries Originating From This Node \n";
   const char *line13 = "                 Queries Originating From ICP Peers\n";
   // const char *line14 = "                           Operations\n";
@@ -494,8 +494,6 @@ CLI_monitor::doMonitorProtocolStats(CLI_
   int highmark = 0;
   int i;
 
-  NOWARN_UNUSED(line10);
-  NOWARN_UNUSED(line11);
   Debug("cli_monitor", "Entering doMonitorProtocolStats, c_data->cevent=%d\n", c_data->cevent);
 
   //  set response header

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli/CliMain.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli/CliMain.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli/CliMain.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli/CliMain.cc Tue Aug  3 23:22:27 2010
@@ -81,8 +81,6 @@ static int ShutdownMgmtCluster;
 static int ShutdownMgmtLocal;
 static int ClearCluster;
 static int ClearNode;
-static int repeatCount;
-static int repeatInterval;
 static int timeout_arg;
 
 static void
@@ -312,8 +310,6 @@ main(int argc, char **argv)
   ShutdownMgmtLocal = 0;
   ClearCluster = 0;
   ClearNode = 0;
-  repeatCount = 1;
-  repeatInterval = 5;
   timeout_arg = -1;
 
   // build the application information structure

Modified: trafficserver/traffic/trunk/proxy/mgmt2/cli/CliUtils.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/mgmt2/cli/CliUtils.cc?rev=982076&r1=982075&r2=982076&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/mgmt2/cli/CliUtils.cc (original)
+++ trafficserver/traffic/trunk/proxy/mgmt2/cli/CliUtils.cc Tue Aug  3 23:22:27 2010
@@ -232,7 +232,6 @@ cli_write_timeout(int fd, const char *da
 {
   int sys_r;
   const char *requestCur;
-  int requestLen;
   int bytesToSend;
   const char *nullBuf = "\0";
   fd_set selectFDs;
@@ -248,11 +247,9 @@ cli_write_timeout(int fd, const char *da
   for (int i = 0; i < 2; i++) {
     if (i == 0) {
       requestCur = data;
-      requestLen = nbytes;
       bytesToSend = nbytes;
     } else {
       requestCur = nullBuf;
-      requestLen = 1;
       bytesToSend = 1;
     }
 



Mime
View raw message