trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a..@apache.org
Subject git commit: Quick fix - URL handling slow request logging.
Date Sat, 24 Aug 2013 03:33:03 GMT
Updated Branches:
  refs/heads/master a7f66aed5 -> c290ce0df


Quick fix - URL handling slow request logging.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/c290ce0d
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/c290ce0d
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/c290ce0d

Branch: refs/heads/master
Commit: c290ce0df2ab019853114599a3a63e6faf82dadb
Parents: a7f66ae
Author: Alan M. Carroll <amc@network-geographics.com>
Authored: Fri Aug 23 22:32:11 2013 -0500
Committer: Alan M. Carroll <amc@network-geographics.com>
Committed: Fri Aug 23 22:32:11 2013 -0500

----------------------------------------------------------------------
 proxy/http/HttpSM.cc | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/c290ce0d/proxy/http/HttpSM.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index 4b7b008..92bd92c 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -6588,16 +6588,15 @@ HttpSM::update_stats()
   // print slow requests if the threshold is set (> 0) and if we are over the time threshold
   if (t_state.http_config_param->slow_log_threshold != 0 &&
       ink_hrtime_from_msec(t_state.http_config_param->slow_log_threshold) < total_time)
{
-    // get the url to log
-    URL *url = t_state.hdr_info.client_request.url_get();
+    URL* url = t_state.hdr_info.client_request.url_get();
     char url_string[256] = "";
-    if (url != NULL && url->valid()) {
-      url->string_get_buf(url_string, sizeof(url_string));
-    }
+
+    t_state.hdr_info.client_request.url_print(url_string, sizeof url_string, 0, 0);
 
     // unique id
     char unique_id_string[128] = "";
-    if (url != NULL && url->valid()) {
+    // [amc] why do we check the URL to get a MIME field?
+    if (0 != url && url->valid()) {
       int length = 0;
       const char *field = t_state.hdr_info.client_request.value_get(MIME_FIELD_X_ID, MIME_LEN_X_ID,
&length);
       if (field != NULL) {


Mime
View raw message