trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: git commit: TS-2217: remove the option to turn off body factory - setting it to 0 will result in empty responses
Date Fri, 13 Sep 2013 15:49:56 GMT

On Sep 12, 2013, at 5:03 PM, bcall@apache.org wrote:

> Updated Branches:
> refs/heads/master 9e9569f3c -> cb9e4b517
> 
> 
> TS-2217: remove the option to turn off body factory - setting it to 0
> will result in empty responses

I'm curious ... is this a compatible change within our definition?

> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/cb9e4b51
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/cb9e4b51
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/cb9e4b51
> 
> Branch: refs/heads/master
> Commit: cb9e4b517679f925c661bb995dcdcdb274fb44bb
> Parents: 9e9569f
> Author: Bryan Call <bcall@apache.org>
> Authored: Thu Sep 12 17:03:07 2013 -0700
> Committer: Bryan Call <bcall@apache.org>
> Committed: Thu Sep 12 17:03:07 2013 -0700
> 
> ----------------------------------------------------------------------
> CHANGES               | 3 +++
> mgmt/RecordsConfig.cc | 4 ++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cb9e4b51/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index fa97bfc..5887a64 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,9 @@
>                                                         -*- coding: utf-8 -*-
> Changes with Apache Traffic Server 4.1.0
> 
> +  *) [TS-2217] remove the option to turn off body factory - setting it to 0 will
> +   result in empty responses
> +
>  *) [TS-2209] add support for lowercasing all substitutions in regex_remap
> 
>  *) [TS-2187] failed assert `nr == sizeof(uint64_t)` in EventNotify::signal()
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cb9e4b51/mgmt/RecordsConfig.cc
> ----------------------------------------------------------------------
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index 201216d..4a73f19 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -706,10 +706,10 @@ RecordElement RecordsConfig[] = {
>  //# Customizable User Response Pages
>  //#
>  //##############################################################################
> -  //# 0 - turn off customizable user response pages
>  //# 1 - enable customizable user response pages in only the "default" directory
>  //# 2 - enable language-targeted user response pages
> -  {RECT_CONFIG, "proxy.config.body_factory.enable_customizations", RECD_INT, "1", RECU_RESTART_TS,
RR_NULL, RECC_INT, "[0-2]", RECA_NULL}
> +  {RECT_CONFIG, "proxy.config.body_factory.enable_customizations", RECD_INT, "1", RECU_RESTART_TS,
RR_NULL, RECC_INT,
> +    "[1-2]", RECA_NULL}
>  ,
>  {RECT_CONFIG, "proxy.config.body_factory.enable_logging", RECD_INT, "0", RECU_RESTART_TS,
RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
>  ,
> 


Mime
View raw message