trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leif Hedstrom <zw...@apache.org>
Subject Re: git commit: TS-2172: Explicitly use subdir-objects in automake init
Date Wed, 04 Sep 2013 14:18:37 GMT
On Sep 3, 2013, at 11:58 PM, Yunkai Zhang <yunkai.me@gmail.com> wrote:

> I'll go back to try to fix this issue later.
> 


I thnk it also breaks out-of-source builds .

Cheers,

-- Leif 
> 
> On Wed, Sep 4, 2013 at 11:15 AM, James Peach <jpeach@apache.org> wrote:
> 
>> On Sep 2, 2013, at 8:02 PM, Yunkai Zhang <yunkai.me@gmail.com> wrote:
>> 
>>> Oh, I only tested it on my REHL6.
>>> 
>>> Does the latest patch: "TS-2172: automake subdir-objects requires
>>> AM_PROG_CC_C_O"
>>> fix the broken?
>> 
>> I updated the build farm to do a "make distclean", which demonstrates the
>> problem.
>> 
>>> 
>>> 
>>> On Tue, Sep 3, 2013 at 6:25 AM, Leif Hedstrom <zwoop@apache.org> wrote:
>>> 
>>>> On Sep 2, 2013, at 3:07 PM, James Peach <jamespeach@me.com> wrote:
>>>> 
>>>>> Last time I enabled subdir-objects, certain versions of automake broke
>>>> horribly. Make sure to watch the build farm for the results of this
>> commit
>>>> 
>>>> yes, this breaks on RHEL5. Also, this is a duplicate of
>>>> 
>>>>       https://issues.apache.org/jira/browse/TS-2068
>>>> 
>>>> 
>>>> Please close one of them as a duplicate.
>>>> 
>>>> -- leif
>>>> 
>>>>> 
>>>>> On Sep 2, 2013, at 11:57 AM, yunkai@apache.org wrote:
>>>>> 
>>>>>> Updated Branches:
>>>>>> refs/heads/master 2585a31cf -> 471655ca1
>>>>>> 
>>>>>> 
>>>>>> TS-2172: Explicitly use subdir-objects in automake init
>>>>>> 
>>>>>> This avoids warnings from automake 1.14 and generates correct
>> configure
>>>>>> script.
>>>>>> 
>>>>>> 
>>>>>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
>>>>>> Commit:
>>>> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/471655ca
>>>>>> Tree:
>>>> http://git-wip-us.apache.org/repos/asf/trafficserver/tree/471655ca
>>>>>> Diff:
>>>> http://git-wip-us.apache.org/repos/asf/trafficserver/diff/471655ca
>>>>>> 
>>>>>> Branch: refs/heads/master
>>>>>> Commit: 471655ca1f9469515444decaaa2f81fde0bd5a25
>>>>>> Parents: 2585a31
>>>>>> Author: Li-Wen Hsu <lwhsu@lwhsu.org>
>>>>>> Authored: Tue Sep 3 01:22:35 2013 +0800
>>>>>> Committer: Yunkai Zhang <qiushu.zyk@taobao.com>
>>>>>> Committed: Tue Sep 3 02:57:20 2013 +0800
>>>>>> 
>>>>>> ----------------------------------------------------------------------
>>>>>> configure.ac | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>> ----------------------------------------------------------------------
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/471655ca/configure.ac
>>>>>> ----------------------------------------------------------------------
>>>>>> diff --git a/configure.ac b/configure.ac
>>>>>> index 8765984..dfbf2e4 100644
>>>>>> --- a/configure.ac
>>>>>> +++ b/configure.ac
>>>>>> @@ -40,7 +40,7 @@ AC_PREREQ([2.59])
>>>>>> AC_CONFIG_AUX_DIR([build/aux])
>>>>>> AC_CONFIG_SRCDIR([proxy/Main.cc])
>>>>>> AC_CONFIG_MACRO_DIR([build])
>>>>>> -AM_INIT_AUTOMAKE([-Wall -Werror tar-ustar foreign no-installinfo
>>>> no-installman 1.9.2])
>>>>>> +AM_INIT_AUTOMAKE([-Wall -Werror tar-ustar foreign no-installinfo
>>>> no-installman subdir-objects 1.9.2])
>>>>>> AC_CONFIG_HEADERS([lib/ts/ink_autoconf.h])
>>>>>> 
>>>>>> # Configure with --disable-silent-rules to get verbose output. For
>> more
>>>> info, see
>>> 
>>> 
>>> --
>>> Yunkai Zhang
>>> Work at Taobao
> 
> 
> -- 
> Yunkai Zhang
> Work at Taobao

Mime
View raw message