trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leif Hedstrom <zw...@apache.org>
Subject Re: git commit: TS-2277: cluster alarm messages broadcast infinitely
Date Thu, 31 Oct 2013 14:52:05 GMT
On Oct 31, 2013, at 4:48 AM, zym@apache.org wrote:

> +      /*
>       lmgmt->alarm_keeper->signalAlarm(MGMT_ALARM_PROXY_SYSTEM_ERROR,
>                                        "[TrafficManager] Unable to write cluster.config,
membership unchanged");
> +      */


If this is dead code, why leave it? Or if we’re uncertain, at least add a comment as to
why the code is left commented out? Same with the rest of the patch.

— Leif


Mime
View raw message