trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leif Hedstrom <zw...@apache.org>
Subject Re: git commit: TS-2628: traffic_line: print restart status after setting a value
Date Tue, 11 Mar 2014 20:38:16 GMT
On Mar 11, 2014, at 2:01 PM, jpeach@apache.org wrote:

> Repository: trafficserver
> +      switch (action) {
> +      case TS_ACTION_SHUTDOWN:
> +        printf("Set %s, full shutdown required\n", SetVar);
> +        break;
> +      case TS_ACTION_RESTART:
> +        printf("Set %s, restart required\n", SetVar);
> +        break;
> +      case TS_ACTION_RECONFIGURE:
> +        printf("Set %s, reconfiguration required\n", SetVar);
> +        break;
> +      case TS_ACTION_DYNAMIC:
> +


As we discussed, a configuration that doesn’t require a restart of traffic_server does not
require a “reconfiguration” if you use the traffic_line -s command. I.e. there’s generally
never necessary to do “traffic_line -s” followed by a “traffic_line -x”. traffic_line
-x is there to reload other configs (e.g. remap.config) or if you modify records.config some
other way (e.g. Emacs).

I agree with you that fixing the APIs to avoid this confusion would be a good idea. Hence,
I figured I’d post it here too, since there might be confusion in this area re: how traffic_line
-s works :).

Cheers,

— Leif


Mime
View raw message