trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject git commit: TS-2780: Core dump in SpdyRequest::clear() in production testing of SPDY
Date Tue, 06 May 2014 00:29:11 GMT
Repository: trafficserver
Updated Branches:
  refs/heads/master 3f0bb5bf8 -> 4bae1eef6


TS-2780: Core dump in SpdyRequest::clear() in production testing of SPDY


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/4bae1eef
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/4bae1eef
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/4bae1eef

Branch: refs/heads/master
Commit: 4bae1eef6dd33f8f56c0c15a9848ffcde3b9d577
Parents: 3f0bb5b
Author: Sudheer Vinukonda <sudheerv@yahoo-inc.com>
Authored: Mon May 5 17:28:38 2014 -0700
Committer: Bryan Call <bcall@apache.org>
Committed: Mon May 5 17:28:38 2014 -0700

----------------------------------------------------------------------
 proxy/spdy/SpdySM.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/4bae1eef/proxy/spdy/SpdySM.cc
----------------------------------------------------------------------
diff --git a/proxy/spdy/SpdySM.cc b/proxy/spdy/SpdySM.cc
index 9ab019d..4fe2d4d 100644
--- a/proxy/spdy/SpdySM.cc
+++ b/proxy/spdy/SpdySM.cc
@@ -113,8 +113,12 @@ SpdySM::clear()
   map<int, SpdyRequest*>::iterator endIter = req_map.end();
   for(; iter != endIter; ++iter) {
     SpdyRequest *req = iter->second;
-    req->clear();
-    spdyRequestAllocator.free(req);
+    if (req) {
+      req->clear();
+      spdyRequestAllocator.free(req);
+    } else {
+      Error("req null in SpdSM::clear");
+    }
   }
   req_map.clear();
 


Mime
View raw message