trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject git commit: TS-2881: Redirection handling broken
Date Mon, 09 Jun 2014 17:53:26 GMT
Repository: trafficserver
Updated Branches:
  refs/heads/master a8938835a -> a4b079632


TS-2881: Redirection handling broken


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a4b07963
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a4b07963
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a4b07963

Branch: refs/heads/master
Commit: a4b0796325f729c04e880a25c7ae219a77ad5c11
Parents: a893883
Author: Sudheer Vinukonda <sudheerv@yahoo-inc.com>
Authored: Mon Jun 9 10:43:40 2014 -0700
Committer: Bryan Call <bcall@apache.org>
Committed: Mon Jun 9 10:46:47 2014 -0700

----------------------------------------------------------------------
 CHANGES              | 2 ++
 proxy/http/HttpSM.cc | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a4b07963/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 4474410..9228160 100644
--- a/CHANGES
+++ b/CHANGES
@@ -11,6 +11,8 @@ Changes with Apache Traffic Server 5.1.0
 
 Changes with Apache Traffic Server 5.0.0
 
+  *) [TS-2881] Redirection handling broken
+
   *) [TS-2875] Change hwloc library env variables from hwloc_ to HWLOC_.
 
   *) [TS-2874] Make some of the SPDY metrics persistent, and also fix how we

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a4b07963/proxy/http/HttpSM.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index 858499f..1d455cd 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -7588,6 +7588,8 @@ HttpSM::is_redirect_required()
 {
   bool redirect_required = (enable_redirection && (redirection_tries <= HttpConfig::m_master.number_of_redirections));
 
+  DebugSM("http_redirect", "is_redirect_required %u", redirect_required);
+
   if (redirect_required == true) {
     HTTPStatus status = t_state.hdr_info.client_response.status_get();
     // check to see if the response from the orgin was a 301, 302, or 303
@@ -7609,8 +7611,6 @@ HttpSM::is_redirect_required()
     // if redirect_url is set by an user's plugin, ats will redirect to this url anyway.
     if (redirect_url != NULL) {
       redirect_required = true;
-    } else {
-      redirect_required = false;
     }
   }
   return redirect_required;


Mime
View raw message