trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shinr...@apache.org
Subject [trafficserver] branch master updated: TS-3485: Remove Warning message about ip-allow enforcement not being present for HTTP2.
Date Tue, 03 May 2016 23:03:47 GMT
This is an automated email from the ASF dual-hosted git repository.

shinrich pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  2dd1c4f   TS-3485: Remove Warning message about ip-allow enforcement not being
present for HTTP2.
2dd1c4f is described below

commit 2dd1c4f02414f7639e6cddc580d26f1bc5f1502c
Author: shinrich <shinrich@ieee.org>
AuthorDate: Tue May 3 18:02:00 2016 -0500

    TS-3485: Remove Warning message about ip-allow enforcement not being present for HTTP2.
---
 lib/records/RecHttp.cc            | 2 --
 proxy/http2/Http2SessionAccept.cc | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/lib/records/RecHttp.cc b/lib/records/RecHttp.cc
index 61c208f..32f8e12 100644
--- a/lib/records/RecHttp.cc
+++ b/lib/records/RecHttp.cc
@@ -616,8 +616,6 @@ ts_session_protocol_well_known_name_indices_init()
   REC_ReadConfigInteger(http2_enabled, "proxy.config.http2.enabled");
   if (!http2_enabled) {
     DEFAULT_TLS_SESSION_PROTOCOL_SET.markOut(HTTP2_PROTOCOL_SET);
-  } else {
-    Warning("Be aware that access control checks for HTTP/2 connections are not active!");
   }
 
   DEFAULT_NON_TLS_SESSION_PROTOCOL_SET = HTTP_PROTOCOL_SET;
diff --git a/proxy/http2/Http2SessionAccept.cc b/proxy/http2/Http2SessionAccept.cc
index c32c9d9..7aeefc7 100644
--- a/proxy/http2/Http2SessionAccept.cc
+++ b/proxy/http2/Http2SessionAccept.cc
@@ -38,10 +38,6 @@ Http2SessionAccept::~Http2SessionAccept()
 void
 Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer *iobuf, IOBufferReader *reader)
 {
-  // XXX we need to refactor the ACL checks from HttpSessionAccept so that we can invoke
them here, and also in
-  // the SPDY protocol layer ...
-  // Warning("skipping access control checks for HTTP/2 connection");
-
   netvc->attributes = this->options.transport_type;
 
   const sockaddr *client_ip = netvc->get_remote_addr();

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message