trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject [trafficserver] branch master updated: Clang-analyzer failure, Called C++ object pointer is null
Date Tue, 24 May 2016 20:41:09 GMT
This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  722b6b1   Clang-analyzer failure, Called C++ object pointer is null
722b6b1 is described below

commit 722b6b14625f19fdc98c627edc3cbf6219699c25
Author: Bryan Call <bcall@apache.org>
AuthorDate: Tue May 24 12:02:50 2016 -0700

    Clang-analyzer failure, Called C++ object pointer is null
---
 plugins/experimental/esi/esi.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/experimental/esi/esi.cc b/plugins/experimental/esi/esi.cc
index 87e17ee..7783762 100644
--- a/plugins/experimental/esi/esi.cc
+++ b/plugins/experimental/esi/esi.cc
@@ -1175,7 +1175,7 @@ checkHeaderValue(TSMBuffer bufp, TSMLoc hdr_loc, const char *name, int
name_len,
     int n_values = TSMimeHdrFieldValuesCount(bufp, hdr_loc, field_loc);
     for (int i = 0; i < n_values; ++i) {
       value = TSMimeHdrFieldValueStringGet(bufp, hdr_loc, field_loc, i, &value_len);
-      if (NULL != value || value_len) {
+      if (NULL != value && value_len) {
         if (prefix) {
           if ((value_len >= exp_value_len) && (strncasecmp(value, exp_value, exp_value_len)
== 0)) {
             retval = true;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message