trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject [trafficserver] branch master updated: Coverity - 1021688 Uninitialized scalar field.
Date Tue, 09 May 2017 19:07:12 GMT
This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  cec4801   Coverity - 1021688 Uninitialized scalar field.
cec4801 is described below

commit cec48015cd389513a5282b2d6833f1b0f35df47b
Author: Steven Feltner <sfeltner@godaddy.com>
AuthorDate: Tue May 9 08:09:34 2017 -0700

    Coverity - 1021688 Uninitialized scalar field.
---
 proxy/http/remap/UrlMapping.cc | 16 ----------------
 proxy/http/remap/UrlMapping.h  | 30 +++++++++++++++---------------
 2 files changed, 15 insertions(+), 31 deletions(-)

diff --git a/proxy/http/remap/UrlMapping.cc b/proxy/http/remap/UrlMapping.cc
index 08c335b..e324c1c 100644
--- a/proxy/http/remap/UrlMapping.cc
+++ b/proxy/http/remap/UrlMapping.cc
@@ -29,22 +29,6 @@
  *
 **/
 url_mapping::url_mapping(int rank /* = 0 */)
-  : from_path_len(0),
-    fromURL(),
-    toUrl(),
-    homePageRedirect(false),
-    unique(false),
-    default_redirect_url(false),
-    optional_referer(false),
-    negative_referer(false),
-    wildcard_from_scheme(false),
-    tag(nullptr),
-    filter_redirect_url(nullptr),
-    referer_list(nullptr),
-    redir_chunk_list(nullptr),
-    filter(nullptr),
-    _plugin_count(0),
-    _rank(rank)
 {
   memset(_plugin_list, 0, sizeof(_plugin_list));
   memset(_instance_data, 0, sizeof(_instance_data));
diff --git a/proxy/http/remap/UrlMapping.h b/proxy/http/remap/UrlMapping.h
index 73f87c7..f8c18c8 100644
--- a/proxy/http/remap/UrlMapping.h
+++ b/proxy/http/remap/UrlMapping.h
@@ -93,23 +93,23 @@ public:
   void delete_instance(unsigned int index);
   void Print();
 
-  int from_path_len;
+  int from_path_len = 0;
   URL fromURL;
   URL toUrl; // Default TO-URL (from remap.config)
-  bool homePageRedirect;
-  bool unique; // INKqa11970 - unique mapping
-  bool default_redirect_url;
-  bool optional_referer;
-  bool negative_referer;
-  bool wildcard_from_scheme; // from url is '/foo', only http or https for now
-  char *tag;                 // tag
-  char *filter_redirect_url; // redirect url when referer filtering enabled
-  unsigned int map_id;
-  referer_info *referer_list;
-  redirect_tag_str *redir_chunk_list;
-  bool ip_allow_check_enabled_p;
-  acl_filter_rule *filter; // acl filtering (list of rules)
-  unsigned int _plugin_count;
+  bool homePageRedirect              = false;
+  bool unique                        = false; // INKqa11970 - unique mapping
+  bool default_redirect_url          = false;
+  bool optional_referer              = false;
+  bool negative_referer              = false;
+  bool wildcard_from_scheme          = false;   // from url is '/foo', only http or https
for now
+  char *tag                          = nullptr; // tag
+  char *filter_redirect_url          = nullptr; // redirect url when referer filtering enabled
+  unsigned int map_id                = 0;
+  referer_info *referer_list         = nullptr;
+  redirect_tag_str *redir_chunk_list = nullptr;
+  bool ip_allow_check_enabled_p      = false;
+  acl_filter_rule *filter            = nullptr; // acl filtering (list of rules)
+  unsigned int _plugin_count         = 0;
   LINK(url_mapping, link); // For use with the main Queue linked list holding all the mapping
 
   int

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message