trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zw...@apache.org
Subject [trafficserver] branch 7.1.x updated: Revert "background_fetch heap-buffer-overflow fix"
Date Tue, 19 Jun 2018 22:58:18 GMT
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/7.1.x by this push:
     new 8eb8e56  Revert "background_fetch heap-buffer-overflow fix"
8eb8e56 is described below

commit 8eb8e564da8bd085648a8b7058972052e2e46538
Author: Leif Hedstrom <leif@ogre.com>
AuthorDate: Tue Jun 19 15:57:50 2018 -0700

    Revert "background_fetch heap-buffer-overflow fix"
    
    This reverts commit 054a208010a3fd6969b4b9575b541f54332f5f84.
---
 plugins/background_fetch/rules.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/plugins/background_fetch/rules.cc b/plugins/background_fetch/rules.cc
index e513424..3e7bfa5 100644
--- a/plugins/background_fetch/rules.cc
+++ b/plugins/background_fetch/rules.cc
@@ -23,7 +23,6 @@
 */
 
 #include <cstdlib>
-#include <string_view>
 
 #include "configs.h"
 #include "rules.h"
@@ -132,7 +131,7 @@ BgFetchRule::check_field_configured(TSHttpTxn txnp) const
           TSDebug(PLUGIN_NAME, "invalid field");
         } else {
           TSDebug(PLUGIN_NAME, "comparing with %s", _value);
-          if (std::string_view::npos != std::string_view(val_str, val_len).find(_value))
{
+          if (nullptr != strstr(val_str, _value)) {
             hdr_found = true;
           }
         }


Mime
View raw message