trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject [trafficserver] branch master updated: HdrHeap: Remove pointless code and misleading comment. By design for serialization, HdrHeap has no virtual methods and therefore no virtual function pointer.
Date Tue, 12 Feb 2019 00:44:24 GMT
This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 7680a52  HdrHeap: Remove pointless code and misleading comment. By design for serialization,
HdrHeap has no virtual methods and therefore no virtual function pointer.
7680a52 is described below

commit 7680a52ffe4afd4fd9b6c70c19cfc85ee88f49cc
Author: Alan M. Carroll <amc@apache.org>
AuthorDate: Mon Feb 11 17:20:35 2019 -0600

    HdrHeap: Remove pointless code and misleading comment.
    By design for serialization, HdrHeap has no virtual methods and therefore no virtual function
pointer.
---
 proxy/hdrs/HdrHeap.cc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/proxy/hdrs/HdrHeap.cc b/proxy/hdrs/HdrHeap.cc
index 70cf6d5..243d6ce 100644
--- a/proxy/hdrs/HdrHeap.cc
+++ b/proxy/hdrs/HdrHeap.cc
@@ -40,7 +40,6 @@
 #define MAX_LOST_STR_SPACE 1024
 
 Allocator hdrHeapAllocator("hdrHeap", HDR_HEAP_DEFAULT_SIZE);
-static HdrHeap proto_heap;
 
 Allocator strHeapAllocator("hdrStrHeap", HDR_STR_HEAP_DEFAULT_SIZE);
 
@@ -122,11 +121,6 @@ new_HdrHeap(int size)
     h = (HdrHeap *)ats_malloc(size);
   }
 
-  //    Debug("hdrs", "Allocated header heap in size %d", size);
-
-  // Patch virtual function table ptr
-  *((void **)h) = *((void **)&proto_heap);
-
   h->m_size = size;
   h->init();
 


Mime
View raw message