trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From masa...@apache.org
Subject [trafficserver] branch quic-latest updated: Fix compiler warnings - unused parameter
Date Fri, 15 Feb 2019 05:26:20 GMT
This is an automated email from the ASF dual-hosted git repository.

masaori pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new d06806f  Fix compiler warnings - unused parameter
d06806f is described below

commit d06806f97669e402d53cb7c42299956fbfcd9cf8
Author: Masaori Koshiba <masaori@apache.org>
AuthorDate: Fri Feb 15 14:26:02 2019 +0900

    Fix compiler warnings - unused parameter
---
 iocore/net/quic/QUICAckFrameCreator.cc      | 5 ++++-
 iocore/net/quic/QUICAltConnectionManager.cc | 5 ++++-
 iocore/net/quic/QUICFlowController.cc       | 6 +++++-
 iocore/net/quic/QUICHandshake.cc            | 3 ---
 iocore/net/quic/QUICPathValidator.cc        | 9 +++++----
 iocore/net/quic/QUICPinger.cc               | 5 ++++-
 iocore/net/quic/QUICStream.cc               | 6 +++++-
 7 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/iocore/net/quic/QUICAckFrameCreator.cc b/iocore/net/quic/QUICAckFrameCreator.cc
index 55b8d6f..db93cd2 100644
--- a/iocore/net/quic/QUICAckFrameCreator.cc
+++ b/iocore/net/quic/QUICAckFrameCreator.cc
@@ -57,8 +57,11 @@ QUICAckFrameManager::update(QUICEncryptionLevel level, QUICPacketNumber
packet_n
   return 0;
 }
 
+/**
+ * @param connection_credit This is not used. Because ACK frame is not flow-controlled
+ */
 QUICFrame *
-QUICAckFrameManager::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
+QUICAckFrameManager::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t /*
connection_credit */,
                                     uint16_t maximum_frame_size)
 {
   QUICAckFrame *ack_frame = nullptr;
diff --git a/iocore/net/quic/QUICAltConnectionManager.cc b/iocore/net/quic/QUICAltConnectionManager.cc
index ad05d8d..0e284e8 100644
--- a/iocore/net/quic/QUICAltConnectionManager.cc
+++ b/iocore/net/quic/QUICAltConnectionManager.cc
@@ -260,8 +260,11 @@ QUICAltConnectionManager::will_generate_frame(QUICEncryptionLevel level)
   return this->_need_advertise || !this->_retired_seq_nums.empty();
 }
 
+/**
+ * @param connection_credit This is not used. Because NEW_CONNECTION_ID frame is not flow-controlled
+ */
 QUICFrame *
-QUICAltConnectionManager::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t
connection_credit,
+QUICAltConnectionManager::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t
/* connection_credit */,
                                          uint16_t maximum_frame_size)
 {
   QUICFrame *frame = nullptr;
diff --git a/iocore/net/quic/QUICFlowController.cc b/iocore/net/quic/QUICFlowController.cc
index 03a685a..84f120a 100644
--- a/iocore/net/quic/QUICFlowController.cc
+++ b/iocore/net/quic/QUICFlowController.cc
@@ -105,8 +105,12 @@ QUICFlowController::will_generate_frame(QUICEncryptionLevel level)
   return this->_should_create_frame;
 }
 
+/**
+ * @param connection_credit This is not used. Because MAX_(STREAM_)DATA frame are not flow-controlled
+ */
 QUICFrame *
-QUICFlowController::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
uint16_t maximum_frame_size)
+QUICFlowController::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t /* connection_credit
*/,
+                                   uint16_t maximum_frame_size)
 {
   QUICFrame *frame = nullptr;
 
diff --git a/iocore/net/quic/QUICHandshake.cc b/iocore/net/quic/QUICHandshake.cc
index ef69639..dfd6ed1 100644
--- a/iocore/net/quic/QUICHandshake.cc
+++ b/iocore/net/quic/QUICHandshake.cc
@@ -349,9 +349,6 @@ QUICHandshake::will_generate_frame(QUICEncryptionLevel level)
 QUICFrame *
 QUICHandshake::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
uint16_t maximum_frame_size)
 {
-  // CRYPTO frame is not flow-controlled
-  // connection_credit = UINT64_MAX;
-
   QUICFrame *frame = nullptr;
 
   if (this->_is_level_matched(level)) {
diff --git a/iocore/net/quic/QUICPathValidator.cc b/iocore/net/quic/QUICPathValidator.cc
index 6f29c3c..4436f58 100644
--- a/iocore/net/quic/QUICPathValidator.cc
+++ b/iocore/net/quic/QUICPathValidator.cc
@@ -126,14 +126,15 @@ QUICPathValidator::will_generate_frame(QUICEncryptionLevel level)
   return (this->_has_outgoing_challenge || this->_has_outgoing_response);
 }
 
+/**
+ * @param connection_credit This is not used. Because PATH_CHALLENGE and PATH_RESPONSE frame
are not flow-controlled
+ */
 QUICFrame *
-QUICPathValidator::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
uint16_t maximum_frame_size)
+QUICPathValidator::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t /* connection_credit
*/,
+                                  uint16_t maximum_frame_size)
 {
   QUICFrame *frame = nullptr;
 
-  // PATH_CHALLENGE and PATH_RESPONSE are not flow-controlled
-  connection_credit = UINT64_MAX;
-
   if (!this->_is_level_matched(level)) {
     return frame;
   }
diff --git a/iocore/net/quic/QUICPinger.cc b/iocore/net/quic/QUICPinger.cc
index f2e40a5..eb892bc 100644
--- a/iocore/net/quic/QUICPinger.cc
+++ b/iocore/net/quic/QUICPinger.cc
@@ -54,8 +54,11 @@ QUICPinger::will_generate_frame(QUICEncryptionLevel level)
   return this->_need_to_fire[QUICTypeUtil::pn_space_index(level)] > 0;
 }
 
+/**
+ * @param connection_credit This is not used. Because PING frame is not flow-controlled
+ */
 QUICFrame *
-QUICPinger::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
uint16_t maximum_frame_size)
+QUICPinger::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t /* connection_credit
*/, uint16_t maximum_frame_size)
 {
   QUICFrame *frame = nullptr;
 
diff --git a/iocore/net/quic/QUICStream.cc b/iocore/net/quic/QUICStream.cc
index 132df1f..32516cc 100644
--- a/iocore/net/quic/QUICStream.cc
+++ b/iocore/net/quic/QUICStream.cc
@@ -876,8 +876,12 @@ QUICCryptoStream::will_generate_frame(QUICEncryptionLevel level)
   return this->_write_buffer_reader->is_read_avail_more_than(0);
 }
 
+/**
+ * @param connection_credit This is not used. Because CRYPTO frame is not flow-controlled
+ */
 QUICFrame *
-QUICCryptoStream::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t connection_credit,
uint16_t maximum_frame_size)
+QUICCryptoStream::generate_frame(uint8_t *buf, QUICEncryptionLevel level, uint64_t /* connection_credit
*/,
+                                 uint16_t maximum_frame_size)
 {
   QUICConnectionErrorUPtr error = nullptr;
 


Mime
View raw message