trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject [trafficserver] branch master updated: clang analyzer: Suppress nullptr dereference error in SSLNetVConnection::update_rbio
Date Fri, 17 May 2019 16:37:05 GMT
This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 1e25ecd  clang analyzer: Suppress nullptr dereference error in SSLNetVConnection::update_rbio
1e25ecd is described below

commit 1e25ecd4b59a139e36bb5436c63f123c33a56a4c
Author: Alan M. Carroll <amc@apache.org>
AuthorDate: Fri May 17 10:03:38 2019 -0500

    clang analyzer: Suppress nullptr dereference error in SSLNetVConnection::update_rbio
---
 iocore/net/SSLNetVConnection.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/iocore/net/SSLNetVConnection.cc b/iocore/net/SSLNetVConnection.cc
index 0958003..18e7820 100644
--- a/iocore/net/SSLNetVConnection.cc
+++ b/iocore/net/SSLNetVConnection.cc
@@ -582,6 +582,7 @@ SSLNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
       this->read.triggered = 0;
       readSignalError(nh, err);
     } else if (ret == SSL_HANDSHAKE_WANT_READ || ret == SSL_HANDSHAKE_WANT_ACCEPT) {
+      ink_assert(this->handShakeReader != nullptr);
       if (SSLConfigParams::ssl_handshake_timeout_in > 0) {
         double handshake_time = ((double)(Thread::get_hrtime() - sslHandshakeBeginTime) /
1000000000);
         Debug("ssl", "ssl handshake for vc %p, took %.3f seconds, configured handshake_timer:
%d", this, handshake_time,


Mime
View raw message