trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jrushf...@apache.org
Subject [trafficserver] branch master updated: Fixes a bug where the nexthop markNextHop method to mark a host down is not called when because the wrapper function was not used.
Date Wed, 08 Apr 2020 17:45:46 GMT
This is an automated email from the ASF dual-hosted git repository.

jrushford pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 9035757  Fixes a bug where the nexthop markNextHop method to mark a host down is
not called when because the wrapper function was not used.
9035757 is described below

commit 90357576c4cbd8c172047955d385b7ba0cd62627
Author: John Rushford <jrushford@apache.org>
AuthorDate: Wed Apr 8 16:38:52 2020 +0000

    Fixes a bug where the nexthop markNextHop method
    to mark a host down is not called when because
    the wrapper function was not used.
---
 proxy/http/HttpTransact.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index 3523428..1495399 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -3621,7 +3621,7 @@ HttpTransact::handle_response_from_parent(State *s)
         //  us to mark the parent down
         if (s->current.state == CONNECTION_ERROR) {
           HTTP_INCREMENT_DYN_STAT(http_total_parent_marked_down_count);
-          s->parent_params->markParentDown(&s->parent_result, s->txn_conf->parent_fail_threshold,
s->txn_conf->parent_retry_time);
+          markParentDown(s);
         }
         // We are done so look for another parent if any
         next_lookup = find_server_and_update_current_info(s);
@@ -3633,7 +3633,7 @@ HttpTransact::handle_response_from_parent(State *s)
       TxnDebug("http_trans", "[handle_response_from_parent] Error. No more retries.");
       if (s->current.state == CONNECTION_ERROR) {
         HTTP_INCREMENT_DYN_STAT(http_total_parent_marked_down_count);
-        s->parent_params->markParentDown(&s->parent_result, s->txn_conf->parent_fail_threshold,
s->txn_conf->parent_retry_time);
+        markParentDown(s);
       }
       s->parent_result.result = PARENT_FAIL;
       next_lookup             = HOST_NONE;


Mime
View raw message