trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shinr...@apache.org
Subject [trafficserver] branch master updated: Increase the default max_record_entries to match the original compiled in value (#6697)
Date Wed, 22 Apr 2020 17:52:51 GMT
This is an automated email from the ASF dual-hosted git repository.

shinrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new eb232ed  Increase the default max_record_entries to match the original compiled in
value (#6697)
eb232ed is described below

commit eb232ed3bbcbfa5835825cec20d5bb0ddee87172
Author: Susan Hinrichs <shinrich@yahoo-inc.com>
AuthorDate: Wed Apr 22 12:52:38 2020 -0500

    Increase the default max_record_entries to match the original compiled in value (#6697)
    
    Co-authored-by: Susan Hinrichs <shinrich@verizonmedia.com>
---
 lib/records/P_RecDefs.h | 2 +-
 lib/records/RecCore.cc  | 2 +-
 mgmt/api/CoreAPI.cc     | 3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/records/P_RecDefs.h b/lib/records/P_RecDefs.h
index e987e63..46e4456 100644
--- a/lib/records/P_RecDefs.h
+++ b/lib/records/P_RecDefs.h
@@ -31,7 +31,7 @@
 // additional slots in librecords will be allocated to the plugin metrics. These should be
 // updated if we change the internal librecords size significantly.
 #define REC_INTERNAL_RECORDS 1100
-#define REC_MIN_API_RECORDS 500
+#define REC_DEFAULT_API_RECORDS 1400
 
 #define REC_CONFIG_UPDATE_INTERVAL_MS 3000
 #define REC_REMOTE_SYNC_INTERVAL_MS 5000
diff --git a/lib/records/RecCore.cc b/lib/records/RecCore.cc
index 8ab0683..fcb6474 100644
--- a/lib/records/RecCore.cc
+++ b/lib/records/RecCore.cc
@@ -34,7 +34,7 @@
 
 // This is needed to manage the size of the librecords record. It can't be static, because
it needs to be modified
 // and used (read) from several binaries / modules.
-int max_records_entries = REC_INTERNAL_RECORDS + REC_MIN_API_RECORDS;
+int max_records_entries = REC_INTERNAL_RECORDS + REC_DEFAULT_API_RECORDS;
 
 static bool g_initialized = false;
 
diff --git a/mgmt/api/CoreAPI.cc b/mgmt/api/CoreAPI.cc
index be5bce4..c9b19e0 100644
--- a/mgmt/api/CoreAPI.cc
+++ b/mgmt/api/CoreAPI.cc
@@ -170,7 +170,8 @@ ProxyStateSet(TSProxyStateT state, TSCacheClearT clear)
 
     // Start with the default options from records.config.
     if (RecGetRecordString_Xmalloc("proxy.config.proxy_binary_opts", &proxy_options)
== REC_ERR_OKAY) {
-      if (max_records_entries == (REC_INTERNAL_RECORDS + REC_MIN_API_RECORDS)) { // Default
size, don't need to pass down to _server
+      if (max_records_entries ==
+          (REC_INTERNAL_RECORDS + REC_DEFAULT_API_RECORDS)) { // Default size, don't need
to pass down to _server
         snprintf(tsArgs, sizeof(tsArgs), "%s", proxy_options);
       } else {
         snprintf(tsArgs, sizeof(tsArgs), "%s --maxRecords %d", proxy_options, max_records_entries);


Mime
View raw message