trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1423] Indexes on traf...
Date Mon, 03 Aug 2015 22:16:40 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/37#discussion_r36138238
  
    --- Diff: core/sql/optimizer/NATable.h ---
    @@ -576,7 +576,17 @@ class NATable : public NABasicObject
       }
     
       NABoolean isSQLMXAlignedTable() const
    -  {  return (flags_ & SQLMX_ALIGNED_ROW_FORMAT) != 0; }
    +  {
    --- End diff --
    
    Now that we have file formats per index, we should move this method from NATable to NAFileSet,
for example as NAFileSet::isSQLMXAlignedFormat(). Instead of calling this method on an NATable
*t, the caller should then call t->getClusteringIndex()->isSQLMXAlignedFormat(). I would
also have some comments on the implementation below, but they are irrelevant if you replace
this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message