trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1423] Indexes on traf...
Date Mon, 03 Aug 2015 22:25:26 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/37#discussion_r36138975
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
    @@ -8358,6 +8358,19 @@ desc_struct * CmpSeabaseDDL::getSeabaseUserTableDesc(const NAString
&catName,
           Lng32 keyColCount = *(Lng32*)vi->get(6);
           Lng32 nonKeyColCount = *(Lng32*)vi->get(7);
           Lng32 idxNumSaltPartns = *(Lng32*)vi->get(8);
    +      char * format = vi->get(9);
    +      Lng32 idxRowFormat;
    +
    +      if (memcmp(format, COM_ALIGNED_FORMAT_LIT, 2) == 0)
    --- End diff --
    
    Not sure I understand this: This gets the row format from the TABLES table, so the index
row format is the same for all the indexes, is that correct? Wouldn't we need to do that per
index? For example, older tables could have an aligned base table and unaligned indexes, while
newer tables and indexes could both be aligned?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message